From: Damien Lespiau <damien.lespiau@intel.com>
To: "Chris Wilson" <chris@chris-wilson.co.uk>,
"Michał Winiarski" <michal.winiarski@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] tests/gem_reg_read: Extend and check for valid 36b counter
Date: Thu, 16 Jul 2015 13:04:39 +0100 [thread overview]
Message-ID: <20150716120438.GA19217@strange.ger.corp.intel.com> (raw)
In-Reply-To: <20150716112419.GP9115@nuc-i3427.alporthouse.com>
On Thu, Jul 16, 2015 at 12:24:19PM +0100, Chris Wilson wrote:
> On Thu, Jul 16, 2015 at 01:19:09PM +0200, Michał Winiarski wrote:
> > When reading the timestamp register with single 64b read, we are observing
> > invalid values on x86_64:
> >
> > [f = valid counter value | X = garbage]
> >
> > i386: 0x0000000fffffffff
> > x86_64: 0xffffffffXXXXXXXX
> >
> > Test checks if the counter is moving and increasing.
> > Add a check to see if we can use (reg | 1) flag to get a proper 36b timestamp,
> > shifting the value on x86_64 if we can't.
> >
> > v2: More iterations of monotonic test, comments, minor fixups (Chris)
> > v3: Skip tests if reg_read is not supported
> >
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Michał Winiarski <michal.winiarski@intel.com>
>
> Lgtm,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Pushed! thanks for the patch and review.
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-16 12:04 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-15 13:17 [PATCH v2] drm/i915: Use two 32bit reads for select 64bit REG_READ ioctls Chris Wilson
2015-07-16 9:06 ` [PATCH] tests/gem_reg_read: Extend and check for valid 36b counter Michał Winiarski
2015-07-16 9:53 ` Chris Wilson
2015-07-16 10:37 ` [PATCH v2] " Michał Winiarski
2015-07-16 10:53 ` Chris Wilson
2015-07-16 11:19 ` [PATCH v3] " Michał Winiarski
2015-07-16 11:24 ` Chris Wilson
2015-07-16 12:04 ` Damien Lespiau [this message]
2015-07-21 6:48 ` Daniel Vetter
2015-07-21 7:10 ` Damien Lespiau
2015-07-16 11:37 ` [PATCH v3] drm/i915: Use two 32bit reads for select 64bit REG_READ ioctls Chris Wilson
2015-07-17 15:10 ` Michał Winiarski
2015-07-21 6:49 ` [Intel-gfx] " Daniel Vetter
2015-07-21 9:45 ` Chris Wilson
2015-07-21 9:49 ` Daniel Vetter
2015-07-19 22:05 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150716120438.GA19217@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michal.winiarski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox