From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/i915: remove unnecessary null test Date: Mon, 20 Jul 2015 17:33:50 +0200 Message-ID: <20150720153350.GK16722@phenom.ffwll.local> References: <1437404761-2617-1-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id D55D26E55B for ; Mon, 20 Jul 2015 08:31:12 -0700 (PDT) Received: by wibud3 with SMTP id ud3so90832084wib.1 for ; Mon, 20 Jul 2015 08:31:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1437404761-2617-1-git-send-email-sudipm.mukherjee@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sudip Mukherjee Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKdWwgMjAsIDIwMTUgYXQgMDg6MzY6MDFQTSArMDUzMCwgU3VkaXAgTXVraGVyamVl IHdyb3RlOgo+IFdoaWxlIGNyZWF0aW5nIHRoZSBkZWJ1Z2ZzIGZpbGUgd2UgYXJlIHNldHRpbmcg dGhlIGlub2RlLT5pX3ByaXZhdGUgdG8KPiBkZXYuIFRoYXQgc2FtZSBkZXYgaXMgcGFzc2VkIHRv IHRoZXNlIGZ1bmN0aW9ucyBhcyBwcml2YXRlIG9mIHN0cnVjdAo+IHNlcV9maWxlIHZpYSBzaW5n bGVfb3BlbigpLiBTbyBhdCB0aGlzIHBvaW50IGl0IGNhbiBuZXZlciBiZSBOVUxMLgo+IAo+IFNp Z25lZC1vZmYtYnk6IFN1ZGlwIE11a2hlcmplZSA8c3VkaXBAdmVjdG9yaW5kaWEub3JnPgo+IC0t LQo+IAo+IHYxIHdhcyBkcm0vaTkxNTogZml4IHBvc3NpYmxlIG51bGwgcG9pbnRlciBkZXJlZmVy ZW5jZQoKVGhlcmUncyBzdGlsbCBvbmUgbGVmdCBpbiBpOTE1X2Rpc3BsYXlwb3J0X3Rlc3RfYWN0 aXZlX3dyaXRlLiBBbHNvIHBsZWFzZQptZW50aW9uIHRoZSBjb21taXQgdGhhdCBpbnRyb2R1Y2Vk IHRoZXNlIGFuZCBDYzogdGhlIGF1dGhvci4gQWxzbyBwbGVhc2UKQ2M6IENocmlzIHNpbmNlIGhl J3MgY29tbWVudGVkIG9uIHYxIG9mIHRoaXMgcGF0Y2guCgpUaGFua3MsIERhbmllbAoKPiAKPiAg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgfCA5IC0tLS0tLS0tLQo+ICAxIGZp bGUgY2hhbmdlZCwgOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVn ZnMuYwo+IGluZGV4IGJjODE3ZGEuLjYzY2I4ODYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2RlYnVnZnMuYwo+IEBAIC00MTAzLDkgKzQxMDMsNiBAQCBzdGF0aWMgaW50IGk5MTVfZGlzcGxh eXBvcnRfdGVzdF9hY3RpdmVfc2hvdyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKmRhdGEpCj4g IAlzdHJ1Y3QgbGlzdF9oZWFkICpjb25uZWN0b3JfbGlzdCA9ICZkZXYtPm1vZGVfY29uZmlnLmNv bm5lY3Rvcl9saXN0Owo+ICAJc3RydWN0IGludGVsX2RwICppbnRlbF9kcDsKPiAgCj4gLQlpZiAo IWRldikKPiAtCQlyZXR1cm4gLUVOT0RFVjsKPiAtCj4gIAlsaXN0X2Zvcl9lYWNoX2VudHJ5KGNv bm5lY3RvciwgY29ubmVjdG9yX2xpc3QsIGhlYWQpIHsKPiAgCj4gIAkJaWYgKGNvbm5lY3Rvci0+ Y29ubmVjdG9yX3R5cGUgIT0KPiBAQCAtNDE1MCw5ICs0MTQ3LDYgQEAgc3RhdGljIGludCBpOTE1 X2Rpc3BsYXlwb3J0X3Rlc3RfZGF0YV9zaG93KHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqZGF0 YSkKPiAgCXN0cnVjdCBsaXN0X2hlYWQgKmNvbm5lY3Rvcl9saXN0ID0gJmRldi0+bW9kZV9jb25m aWcuY29ubmVjdG9yX2xpc3Q7Cj4gIAlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwOwo+ICAKPiAt CWlmICghZGV2KQo+IC0JCXJldHVybiAtRU5PREVWOwo+IC0KPiAgCWxpc3RfZm9yX2VhY2hfZW50 cnkoY29ubmVjdG9yLCBjb25uZWN0b3JfbGlzdCwgaGVhZCkgewo+ICAKPiAgCQlpZiAoY29ubmVj dG9yLT5jb25uZWN0b3JfdHlwZSAhPQo+IEBAIC00MTkyLDkgKzQxODYsNiBAQCBzdGF0aWMgaW50 IGk5MTVfZGlzcGxheXBvcnRfdGVzdF90eXBlX3Nob3coc3RydWN0IHNlcV9maWxlICptLCB2b2lk ICpkYXRhKQo+ICAJc3RydWN0IGxpc3RfaGVhZCAqY29ubmVjdG9yX2xpc3QgPSAmZGV2LT5tb2Rl X2NvbmZpZy5jb25uZWN0b3JfbGlzdDsKPiAgCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHA7Cj4g IAo+IC0JaWYgKCFkZXYpCj4gLQkJcmV0dXJuIC1FTk9ERVY7Cj4gLQo+ICAJbGlzdF9mb3JfZWFj aF9lbnRyeShjb25uZWN0b3IsIGNvbm5lY3Rvcl9saXN0LCBoZWFkKSB7Cj4gIAo+ICAJCWlmIChj b25uZWN0b3ItPmNvbm5lY3Rvcl90eXBlICE9Cj4gLS0gCj4gMS44LjEuMgo+IAo+IF9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK