Re: [PATCH 5/5] drm/i915: Make wait_for_flips interruptible.

From: Daniel Vetter <daniel@ffwll.ch>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 5/5] drm/i915: Make wait_for_flips interruptible.
Date: Tue, 21 Jul 2015 08:51:31 +0200	[thread overview]
Message-ID: <20150721065131.GN16722@phenom.ffwll.local> (raw)
In-Reply-To: <55AD0B1B.90703@linux.intel.com>

On Mon, Jul 20, 2015 at 04:52:11PM +0200, Maarten Lankhorst wrote:
> Op 16-07-15 om 14:57 schreef Maarten Lankhorst:
> > Move it from intel_crtc_atomic_commit to prepare_plane_fb.
> > Waiting is done before committing, otherwise it's too late
> > to undo the changes.
> >
> > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > ---
> >  drivers/gpu/drm/i915/intel_atomic.c  |  2 -
> >  drivers/gpu/drm/i915/intel_display.c | 72 +++++++++++++++++-------------------
> >  drivers/gpu/drm/i915/intel_drv.h     |  2 -
> >  3 files changed, 33 insertions(+), 43 deletions(-)
> >
> This breaks DPMS off, because it might wait for flips before continuing.
> It looks like all drivers use drmModeConnectorSetProperty correctly,
> so it's safe to fix dpms to return an error.
> 
> Can I get the changes to dpms handling in intel applied first, and the first 4 patches from this series?

Yeah makes sense.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx