From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 1/2] drm/i915: remove unnecessary null test Date: Tue, 21 Jul 2015 15:51:40 +0200 Message-ID: <20150721135140.GM16722@phenom.ffwll.local> References: <1437480406-19285-1-git-send-email-sudipm.mukherjee@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f54.google.com (mail-wg0-f54.google.com [74.125.82.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 49B0F6E7E8 for ; Tue, 21 Jul 2015 06:49:02 -0700 (PDT) Received: by wgkl9 with SMTP id l9so156820469wgk.1 for ; Tue, 21 Jul 2015 06:49:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1437480406-19285-1-git-send-email-sudipm.mukherjee@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Sudip Mukherjee Cc: David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdWwgMjEsIDIwMTUgYXQgMDU6MzY6NDVQTSArMDUzMCwgU3VkaXAgTXVraGVyamVl IHdyb3RlOgo+IFdoaWxlIGNyZWF0aW5nIHRoZSBkZWJ1Z2ZzIGZpbGUgd2UgYXJlIHNldHRpbmcg dGhlIGlub2RlLT5pX3ByaXZhdGUgdG8KPiBkZXYuIFRoYXQgc2FtZSBkZXYgaXMgcGFzc2VkIHRv IHRoZXNlIGZ1bmN0aW9ucyBhcyBwcml2YXRlIG9mIHN0cnVjdAo+IHNlcV9maWxlIHZpYSBzaW5n bGVfb3BlbigpLiBNb3Jlb3ZlciBzaW5nbGVfb3BlbiBpcyBzZXR0aW5nCj4gZmlsZS0+cHJpdmF0 ZV9kYXRhLT5wcml2YXRlIHRvIGRldi4KPiBTbyBhdCB0aGlzIHBvaW50IGl0IGNhbiBuZXZlciBi ZSBOVUxMLgo+IFRoaXMgY2hlY2sgd2FzIGFkZGVkIGJ5IGNvbW1pdCBlYjMzOTRmYWViOTcgKCJk cm0vaTkxNTogQWRkIGRlYnVnZnMgdGVzdAo+IGNvbnRyb2wgZmlsZXMgZm9yIERpc3BsYXlwb3J0 IGNvbXBsaWFuY2UgdGVzdGluZyIpCj4gCgpTdGlsbCBtaXNzaW5nCgpDYzogQ2hyaXMgV2lsc29u IC4uLgpDYzogVG9kZCBQcmV2aXRlIC4uLgoKaGVyZSB0byBtYWtlIHN1cmUgcmV2aWV3ZXJzL29y aWdpbmFsIGF1dGhvcnMgYXJlIGluIHRoZSBsb29wLiBBbnl3YXkgdGhpcwppcyBhIHNpbXBsZSBl bm91Z2ggcGF0Y2gsIHNvIEkganVzdCBwdWxsZWQgdGhlbSBib3RoIGluLgoKVGhhbmtzLCBEYW5p ZWwKCj4gU2lnbmVkLW9mZi1ieTogU3VkaXAgTXVraGVyamVlIDxzdWRpcEB2ZWN0b3JpbmRpYS5v cmc+Cj4gLS0tCj4gCj4gdjM6IHJlbW92ZWQgdGhlIGNoZWNrIGluIGk5MTVfZGlzcGxheXBvcnRf dGVzdF9hY3RpdmVfd3JpdGUgYWxzbwo+IHYyOiByZW1vdmVkIG51bGwgY2hlY2sKPiB2MSB3YXMg ZHJtL2k5MTU6IGZpeCBwb3NzaWJsZSBudWxsIHBvaW50ZXIgZGVyZWZlcmVuY2UKPiAKPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgfCAyMSArLS0tLS0tLS0tLS0tLS0tLS0t LS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAyMCBkZWxldGlvbnMoLSkKPiAK PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IGluZGV4IGJjODE3ZGEuLmZmY2U2MmUg MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiArKysg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IEBAIC00MDI4LDI0ICs0MDI4 LDE0IEBAIHN0YXRpYyBzc2l6ZV90IGk5MTVfZGlzcGxheXBvcnRfdGVzdF9hY3RpdmVfd3JpdGUo c3RydWN0IGZpbGUgKmZpbGUsCj4gIHsKPiAgCWNoYXIgKmlucHV0X2J1ZmZlcjsKPiAgCWludCBz dGF0dXMgPSAwOwo+IC0Jc3RydWN0IHNlcV9maWxlICptOwo+ICAJc3RydWN0IGRybV9kZXZpY2Ug KmRldjsKPiAgCXN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3I7Cj4gIAlzdHJ1Y3QgbGlz dF9oZWFkICpjb25uZWN0b3JfbGlzdDsKPiAgCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHA7Cj4g IAlpbnQgdmFsID0gMDsKPiAgCj4gLQltID0gZmlsZS0+cHJpdmF0ZV9kYXRhOwo+IC0JaWYgKCFt KSB7Cj4gLQkJc3RhdHVzID0gLUVOT0RFVjsKPiAtCQlyZXR1cm4gc3RhdHVzOwo+IC0JfQo+IC0J ZGV2ID0gbS0+cHJpdmF0ZTsKPiArCWRldiA9ICgoc3RydWN0IHNlcV9maWxlICopZmlsZS0+cHJp dmF0ZV9kYXRhKS0+cHJpdmF0ZTsKPiAgCj4gLQlpZiAoIWRldikgewo+IC0JCXN0YXR1cyA9IC1F Tk9ERVY7Cj4gLQkJcmV0dXJuIHN0YXR1czsKPiAtCX0KPiAgCWNvbm5lY3Rvcl9saXN0ID0gJmRl di0+bW9kZV9jb25maWcuY29ubmVjdG9yX2xpc3Q7Cj4gIAo+ICAJaWYgKGxlbiA9PSAwKQo+IEBA IC00MTAzLDkgKzQwOTMsNiBAQCBzdGF0aWMgaW50IGk5MTVfZGlzcGxheXBvcnRfdGVzdF9hY3Rp dmVfc2hvdyhzdHJ1Y3Qgc2VxX2ZpbGUgKm0sIHZvaWQgKmRhdGEpCj4gIAlzdHJ1Y3QgbGlzdF9o ZWFkICpjb25uZWN0b3JfbGlzdCA9ICZkZXYtPm1vZGVfY29uZmlnLmNvbm5lY3Rvcl9saXN0Owo+ ICAJc3RydWN0IGludGVsX2RwICppbnRlbF9kcDsKPiAgCj4gLQlpZiAoIWRldikKPiAtCQlyZXR1 cm4gLUVOT0RFVjsKPiAtCj4gIAlsaXN0X2Zvcl9lYWNoX2VudHJ5KGNvbm5lY3RvciwgY29ubmVj dG9yX2xpc3QsIGhlYWQpIHsKPiAgCj4gIAkJaWYgKGNvbm5lY3Rvci0+Y29ubmVjdG9yX3R5cGUg IT0KPiBAQCAtNDE1MCw5ICs0MTM3LDYgQEAgc3RhdGljIGludCBpOTE1X2Rpc3BsYXlwb3J0X3Rl c3RfZGF0YV9zaG93KHN0cnVjdCBzZXFfZmlsZSAqbSwgdm9pZCAqZGF0YSkKPiAgCXN0cnVjdCBs aXN0X2hlYWQgKmNvbm5lY3Rvcl9saXN0ID0gJmRldi0+bW9kZV9jb25maWcuY29ubmVjdG9yX2xp c3Q7Cj4gIAlzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwOwo+ICAKPiAtCWlmICghZGV2KQo+IC0J CXJldHVybiAtRU5PREVWOwo+IC0KPiAgCWxpc3RfZm9yX2VhY2hfZW50cnkoY29ubmVjdG9yLCBj b25uZWN0b3JfbGlzdCwgaGVhZCkgewo+ICAKPiAgCQlpZiAoY29ubmVjdG9yLT5jb25uZWN0b3Jf dHlwZSAhPQo+IEBAIC00MTkyLDkgKzQxNzYsNiBAQCBzdGF0aWMgaW50IGk5MTVfZGlzcGxheXBv cnRfdGVzdF90eXBlX3Nob3coc3RydWN0IHNlcV9maWxlICptLCB2b2lkICpkYXRhKQo+ICAJc3Ry dWN0IGxpc3RfaGVhZCAqY29ubmVjdG9yX2xpc3QgPSAmZGV2LT5tb2RlX2NvbmZpZy5jb25uZWN0 b3JfbGlzdDsKPiAgCXN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHA7Cj4gIAo+IC0JaWYgKCFkZXYp Cj4gLQkJcmV0dXJuIC1FTk9ERVY7Cj4gLQo+ICAJbGlzdF9mb3JfZWFjaF9lbnRyeShjb25uZWN0 b3IsIGNvbm5lY3Rvcl9saXN0LCBoZWFkKSB7Cj4gIAo+ICAJCWlmIChjb25uZWN0b3ItPmNvbm5l Y3Rvcl90eXBlICE9Cj4gLS0gCj4gMS44LjEuMgo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBF bmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK