* [PATCH] drm/i915: fix checksum write for automated test reply
@ 2015-07-22 10:06 Sivakumar Thulasimani
2015-07-22 12:00 ` Daniel Vetter
0 siblings, 1 reply; 11+ messages in thread
From: Sivakumar Thulasimani @ 2015-07-22 10:06 UTC (permalink / raw)
To: tprevite, intel-gfx
From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
DP spec requires the checksum of the last block read to be written
when replying to TEST_EDID_READ. This patch fixes the current code
to do the same.
Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index f1b9f93..9617d04 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4090,9 +4090,18 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
intel_dp->aux.i2c_defer_count);
intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
} else {
+ struct edid *block = intel_connector->detect_edid;
+ uint8_t temp = intel_connector->detect_edid->extensions;
+
+ /* We have to write the checksum
+ * of the last block read
+ */
+ while (temp--)
+ block++;
+
if (!drm_dp_dpcd_write(&intel_dp->aux,
DP_TEST_EDID_CHECKSUM,
- &intel_connector->detect_edid->checksum,
+ &block->checksum,
1))
DRM_DEBUG_KMS("Failed to write EDID checksum\n");
--
1.7.9.5
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix checksum write for automated test reply
2015-07-22 10:06 [PATCH] drm/i915: fix checksum write for automated test reply Sivakumar Thulasimani
@ 2015-07-22 12:00 ` Daniel Vetter
2015-07-22 12:59 ` Sivakumar Thulasimani
0 siblings, 1 reply; 11+ messages in thread
From: Daniel Vetter @ 2015-07-22 12:00 UTC (permalink / raw)
To: Sivakumar Thulasimani; +Cc: intel-gfx
On Wed, Jul 22, 2015 at 03:36:48PM +0530, Sivakumar Thulasimani wrote:
> From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
>
> DP spec requires the checksum of the last block read to be written
> when replying to TEST_EDID_READ. This patch fixes the current code
> to do the same.
>
> Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index f1b9f93..9617d04 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4090,9 +4090,18 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
> intel_dp->aux.i2c_defer_count);
> intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
> } else {
> + struct edid *block = intel_connector->detect_edid;
> + uint8_t temp = intel_connector->detect_edid->extensions;
> +
> + /* We have to write the checksum
> + * of the last block read
> + */
> + while (temp--)
> + block++;
block += block->extensions;
instead of implementing addition by adding lots of 1? Also if you want to
simplify computation by extracting local variables, give them a better
name than "temp". That's somewhat ok for a reused u32 tmp for register
read-modify-writes over lots of registers, but not really for anything
else.
-Daniel
> +
> if (!drm_dp_dpcd_write(&intel_dp->aux,
> DP_TEST_EDID_CHECKSUM,
> - &intel_connector->detect_edid->checksum,
> + &block->checksum,
> 1))
> DRM_DEBUG_KMS("Failed to write EDID checksum\n");
>
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix checksum write for automated test reply
2015-07-22 12:00 ` Daniel Vetter
@ 2015-07-22 12:59 ` Sivakumar Thulasimani
0 siblings, 0 replies; 11+ messages in thread
From: Sivakumar Thulasimani @ 2015-07-22 12:59 UTC (permalink / raw)
To: Daniel Vetter; +Cc: intel-gfx
On 7/22/2015 5:30 PM, Daniel Vetter wrote:
> On Wed, Jul 22, 2015 at 03:36:48PM +0530, Sivakumar Thulasimani wrote:
>> From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
>>
>> DP spec requires the checksum of the last block read to be written
>> when replying to TEST_EDID_READ. This patch fixes the current code
>> to do the same.
>>
>> Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_dp.c | 11 ++++++++++-
>> 1 file changed, 10 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index f1b9f93..9617d04 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -4090,9 +4090,18 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
>> intel_dp->aux.i2c_defer_count);
>> intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
>> } else {
>> + struct edid *block = intel_connector->detect_edid;
>> + uint8_t temp = intel_connector->detect_edid->extensions;
>> +
>> + /* We have to write the checksum
>> + * of the last block read
>> + */
>> + while (temp--)
>> + block++;
> block += block->extensions;
>
> instead of implementing addition by adding lots of 1? Also if you want to
> simplify computation by extracting local variables, give them a better
> name than "temp". That's somewhat ok for a reused u32 tmp for register
> read-modify-writes over lots of registers, but not really for anything
> else.
> -Daniel
>
Done. uploaded v2 with this change.
>> +
>> if (!drm_dp_dpcd_write(&intel_dp->aux,
>> DP_TEST_EDID_CHECKSUM,
>> - &intel_connector->detect_edid->checksum,
>> + &block->checksum,
>> 1))
>> DRM_DEBUG_KMS("Failed to write EDID checksum\n");
>>
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
>
--
regards,
Sivakumar
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] drm/i915: fix checksum write for automated test reply
@ 2015-07-22 13:01 Sivakumar Thulasimani
2015-07-23 21:47 ` shuang.he
2015-07-27 4:41 ` Sivakumar Thulasimani
0 siblings, 2 replies; 11+ messages in thread
From: Sivakumar Thulasimani @ 2015-07-22 13:01 UTC (permalink / raw)
To: tprevite, intel-gfx
From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
DP spec requires the checksum of the last block read to be written
when replying to TEST_EDID_READ. This patch fixes the current code
to do the same.
Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index f1b9f93..fa6e202 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
intel_dp->aux.i2c_defer_count);
intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
} else {
+ struct edid *block = intel_connector->detect_edid;
+
+ /* We have to write the checksum
+ * of the last block read
+ */
+ block += intel_connector->detect_edid->extensions;
+
if (!drm_dp_dpcd_write(&intel_dp->aux,
DP_TEST_EDID_CHECKSUM,
- &intel_connector->detect_edid->checksum,
+ &block->checksum,
1))
DRM_DEBUG_KMS("Failed to write EDID checksum\n");
--
1.7.9.5
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix checksum write for automated test reply
2015-07-22 13:01 Sivakumar Thulasimani
@ 2015-07-23 21:47 ` shuang.he
2015-07-27 4:41 ` Sivakumar Thulasimani
1 sibling, 0 replies; 11+ messages in thread
From: shuang.he @ 2015-07-23 21:47 UTC (permalink / raw)
To: shuang.he, julianx.dumez, christophe.sureau, lei.a.liu, intel-gfx,
sivakumar.thulasimani
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang.he@intel.com)
Task id: 6848
-------------------------------------Summary-------------------------------------
Platform Delta drm-intel-nightly Series Applied
ILK 295/295 295/295
SNB 315/315 315/315
IVB 342/342 342/342
BYT 285/285 285/285
HSW 378/380 378/380
-------------------------------------Detailed-------------------------------------
Platform Test drm-intel-nightly Series Applied
Note: You need to pay more attention to line start with '*'
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix checksum write for automated test reply
2015-07-22 13:01 Sivakumar Thulasimani
2015-07-23 21:47 ` shuang.he
@ 2015-07-27 4:41 ` Sivakumar Thulasimani
1 sibling, 0 replies; 11+ messages in thread
From: Sivakumar Thulasimani @ 2015-07-27 4:41 UTC (permalink / raw)
To: tprevite, intel-gfx
Any comments for this change ?
On 7/22/2015 6:31 PM, Sivakumar Thulasimani wrote:
> From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
>
> DP spec requires the checksum of the last block read to be written
> when replying to TEST_EDID_READ. This patch fixes the current code
> to do the same.
>
> Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index f1b9f93..fa6e202 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
> intel_dp->aux.i2c_defer_count);
> intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
> } else {
> + struct edid *block = intel_connector->detect_edid;
> +
> + /* We have to write the checksum
> + * of the last block read
> + */
> + block += intel_connector->detect_edid->extensions;
> +
> if (!drm_dp_dpcd_write(&intel_dp->aux,
> DP_TEST_EDID_CHECKSUM,
> - &intel_connector->detect_edid->checksum,
> + &block->checksum,
> 1))
> DRM_DEBUG_KMS("Failed to write EDID checksum\n");
>
--
regards,
Sivakumar
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH] drm/i915: fix checksum write for automated test reply
@ 2015-08-07 9:44 Sivakumar Thulasimani
2015-08-12 6:06 ` Sivakumar Thulasimani
2015-08-14 8:27 ` Jindal, Sonika
0 siblings, 2 replies; 11+ messages in thread
From: Sivakumar Thulasimani @ 2015-08-07 9:44 UTC (permalink / raw)
To: daniel, intel-gfx
From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
DP spec requires the checksum of the last block read to be written
when replying to TEST_EDID_READ. This patch fixes the current code
to do the same.
v2: removed loop for jumping blocks and performed direct addition
as recommended by Daniel
Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index f1b9f93..fa6e202 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
intel_dp->aux.i2c_defer_count);
intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
} else {
+ struct edid *block = intel_connector->detect_edid;
+
+ /* We have to write the checksum
+ * of the last block read
+ */
+ block += intel_connector->detect_edid->extensions;
+
if (!drm_dp_dpcd_write(&intel_dp->aux,
DP_TEST_EDID_CHECKSUM,
- &intel_connector->detect_edid->checksum,
+ &block->checksum,
1))
DRM_DEBUG_KMS("Failed to write EDID checksum\n");
--
1.7.9.5
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix checksum write for automated test reply
2015-08-07 9:44 Sivakumar Thulasimani
@ 2015-08-12 6:06 ` Sivakumar Thulasimani
2015-08-12 12:43 ` Daniel Vetter
2015-08-14 8:27 ` Jindal, Sonika
1 sibling, 1 reply; 11+ messages in thread
From: Sivakumar Thulasimani @ 2015-08-12 6:06 UTC (permalink / raw)
To: daniel, intel-gfx
Hi Daniel,
any comments for the patch below ?
regards,
Sivakumar
On Friday 07 August 2015 03:14 PM, Sivakumar Thulasimani wrote:
> From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
>
> DP spec requires the checksum of the last block read to be written
> when replying to TEST_EDID_READ. This patch fixes the current code
> to do the same.
>
> v2: removed loop for jumping blocks and performed direct addition
> as recommended by Daniel
>
> Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index f1b9f93..fa6e202 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
> intel_dp->aux.i2c_defer_count);
> intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
> } else {
> + struct edid *block = intel_connector->detect_edid;
> +
> + /* We have to write the checksum
> + * of the last block read
> + */
> + block += intel_connector->detect_edid->extensions;
> +
> if (!drm_dp_dpcd_write(&intel_dp->aux,
> DP_TEST_EDID_CHECKSUM,
> - &intel_connector->detect_edid->checksum,
> + &block->checksum,
> 1))
> DRM_DEBUG_KMS("Failed to write EDID checksum\n");
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix checksum write for automated test reply
2015-08-12 6:06 ` Sivakumar Thulasimani
@ 2015-08-12 12:43 ` Daniel Vetter
0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2015-08-12 12:43 UTC (permalink / raw)
To: Sivakumar Thulasimani; +Cc: intel-gfx
On Wed, Aug 12, 2015 at 11:36:07AM +0530, Sivakumar Thulasimani wrote:
> Hi Daniel,
> any comments for the patch below ?
Find me a reviewer to r-b stamp this patch and I'll merge.
-Daniel
>
> regards,
> Sivakumar
>
> On Friday 07 August 2015 03:14 PM, Sivakumar Thulasimani wrote:
> >From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
> >
> >DP spec requires the checksum of the last block read to be written
> >when replying to TEST_EDID_READ. This patch fixes the current code
> >to do the same.
> >
> >v2: removed loop for jumping blocks and performed direct addition
> >as recommended by Daniel
> >
> >Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
> >---
> > drivers/gpu/drm/i915/intel_dp.c | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> >index f1b9f93..fa6e202 100644
> >--- a/drivers/gpu/drm/i915/intel_dp.c
> >+++ b/drivers/gpu/drm/i915/intel_dp.c
> >@@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
> > intel_dp->aux.i2c_defer_count);
> > intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
> > } else {
> >+ struct edid *block = intel_connector->detect_edid;
> >+
> >+ /* We have to write the checksum
> >+ * of the last block read
> >+ */
> >+ block += intel_connector->detect_edid->extensions;
> >+
> > if (!drm_dp_dpcd_write(&intel_dp->aux,
> > DP_TEST_EDID_CHECKSUM,
> >- &intel_connector->detect_edid->checksum,
> >+ &block->checksum,
> > 1))
> > DRM_DEBUG_KMS("Failed to write EDID checksum\n");
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix checksum write for automated test reply
2015-08-07 9:44 Sivakumar Thulasimani
2015-08-12 6:06 ` Sivakumar Thulasimani
@ 2015-08-14 8:27 ` Jindal, Sonika
2015-08-14 9:12 ` Daniel Vetter
1 sibling, 1 reply; 11+ messages in thread
From: Jindal, Sonika @ 2015-08-14 8:27 UTC (permalink / raw)
To: Thulasimani, Sivakumar, daniel@ffwll.ch,
intel-gfx@lists.freedesktop.org
Looks good to me.
Reviewed-by: Sonika Jindal <sonika.jindal@intel.com>
-----Original Message-----
From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of Sivakumar Thulasimani
Sent: Friday, August 7, 2015 3:15 PM
To: daniel@ffwll.ch; intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915: fix checksum write for automated test reply
From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
DP spec requires the checksum of the last block read to be written when replying to TEST_EDID_READ. This patch fixes the current code to do the same.
v2: removed loop for jumping blocks and performed direct addition as recommended by Daniel
Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
---
drivers/gpu/drm/i915/intel_dp.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index f1b9f93..fa6e202 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
intel_dp->aux.i2c_defer_count);
intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
} else {
+ struct edid *block = intel_connector->detect_edid;
+
+ /* We have to write the checksum
+ * of the last block read
+ */
+ block += intel_connector->detect_edid->extensions;
+
if (!drm_dp_dpcd_write(&intel_dp->aux,
DP_TEST_EDID_CHECKSUM,
- &intel_connector->detect_edid->checksum,
+ &block->checksum,
1))
DRM_DEBUG_KMS("Failed to write EDID checksum\n");
--
1.7.9.5
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] drm/i915: fix checksum write for automated test reply
2015-08-14 8:27 ` Jindal, Sonika
@ 2015-08-14 9:12 ` Daniel Vetter
0 siblings, 0 replies; 11+ messages in thread
From: Daniel Vetter @ 2015-08-14 9:12 UTC (permalink / raw)
To: Jindal, Sonika; +Cc: intel-gfx@lists.freedesktop.org
On Fri, Aug 14, 2015 at 08:27:45AM +0000, Jindal, Sonika wrote:
> Looks good to me.
> Reviewed-by: Sonika Jindal <sonika.jindal@intel.com>
Queued for -next, thanks for the patch.
-Daniel
>
> -----Original Message-----
> From: Intel-gfx [mailto:intel-gfx-bounces@lists.freedesktop.org] On Behalf Of Sivakumar Thulasimani
> Sent: Friday, August 7, 2015 3:15 PM
> To: daniel@ffwll.ch; intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH] drm/i915: fix checksum write for automated test reply
>
> From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
>
> DP spec requires the checksum of the last block read to be written when replying to TEST_EDID_READ. This patch fixes the current code to do the same.
>
> v2: removed loop for jumping blocks and performed direct addition as recommended by Daniel
>
> Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index f1b9f93..fa6e202 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -4090,9 +4090,16 @@ static uint8_t intel_dp_autotest_edid(struct intel_dp *intel_dp)
> intel_dp->aux.i2c_defer_count);
> intel_dp->compliance_test_data = INTEL_DP_RESOLUTION_FAILSAFE;
> } else {
> + struct edid *block = intel_connector->detect_edid;
> +
> + /* We have to write the checksum
> + * of the last block read
> + */
> + block += intel_connector->detect_edid->extensions;
> +
> if (!drm_dp_dpcd_write(&intel_dp->aux,
> DP_TEST_EDID_CHECKSUM,
> - &intel_connector->detect_edid->checksum,
> + &block->checksum,
> 1))
> DRM_DEBUG_KMS("Failed to write EDID checksum\n");
>
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-08-14 9:12 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-22 10:06 [PATCH] drm/i915: fix checksum write for automated test reply Sivakumar Thulasimani
2015-07-22 12:00 ` Daniel Vetter
2015-07-22 12:59 ` Sivakumar Thulasimani
-- strict thread matches above, loose matches on Subject: below --
2015-07-22 13:01 Sivakumar Thulasimani
2015-07-23 21:47 ` shuang.he
2015-07-27 4:41 ` Sivakumar Thulasimani
2015-08-07 9:44 Sivakumar Thulasimani
2015-08-12 6:06 ` Sivakumar Thulasimani
2015-08-12 12:43 ` Daniel Vetter
2015-08-14 8:27 ` Jindal, Sonika
2015-08-14 9:12 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox