From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH v3 1/5] drm: Add config for detecting libdrm
Date: Thu, 23 Jul 2015 13:44:17 +0300
Message-ID: <20150723104417.GA21575@altlinux.org>
References: <1435755168-16207-1-git-send-email-patrik.jakobsson@linux.intel.com>
 <1435755168-16207-2-git-send-email-patrik.jakobsson@linux.intel.com>
 <20150723094821.GC1209@vapier>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2043318418=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from pegasus3.altlinux.org (pegasus3.altlinux.org [194.107.17.103])
 by gabe.freedesktop.org (Postfix) with ESMTP id D1F596E501
 for <intel-gfx@lists.freedesktop.org>; Thu, 23 Jul 2015 03:44:19 -0700 (PDT)
In-Reply-To: <20150723094821.GC1209@vapier>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: strace development list <strace-devel@lists.sourceforge.net>, gabriel@lse.epita.fr, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org


--===============2043318418==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI"
Content-Disposition: inline


--oyUTqETQ0mS9luUI
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 23, 2015 at 05:48:21AM -0400, Mike Frysinger wrote:
> On 01 Jul 2015 14:52, Patrik Jakobsson wrote:
> > Use pkg-config to try to find libdrm. If that fails use the standard
> > include directory for kernel drm headers in /usr/include/drm.
> >=20
> > * configure.ac: Use pkg-config to find libdrm
> >=20
> > Signed-off-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
> > ---
> >  configure.ac | 4 ++++
> >  1 file changed, 4 insertions(+)
> >=20
> > diff --git a/configure.ac b/configure.ac
> > index bb8bf46..aa63af7 100644
> > --- a/configure.ac
> > +++ b/configure.ac
> > @@ -844,6 +844,10 @@ fi
> >  AM_CONDITIONAL([USE_LIBUNWIND], [test "x$use_libunwind" =3D xyes])
> >  AC_MSG_RESULT([$use_libunwind])
> > =20
> > +PKG_CHECK_MODULES([libdrm], [libdrm],
> > +	[CPPFLAGS=3D"$CPPFLAGS $libdrm_CFLAGS"],
> > +	[CPPFLAGS=3D"$CPPFLAGS -I/usr/include/drm"])
>=20
> yikes, no, this is a really really bad idea.  it should read:
> PKG_CHECK_MODULES([LIBDRM], [libdrm],
> 	[CPPFLAGS=3D"$CPPFLAGS $LIBDRM_CFLAGS"], [:])

Why [:] ?  Wouldn't [] suffice?


--=20
ldv

--oyUTqETQ0mS9luUI
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlWwxYEACgkQfKvmrJ41Nh5E/QCguHEPpu/eKKOhllR5Yin9WwwS
tk0An2xXpatPdhVkDnYhaFDblg40GTqR
=6mvh
-----END PGP SIGNATURE-----

--oyUTqETQ0mS9luUI--

--===============2043318418==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK

--===============2043318418==--