From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v1.1 02/13] drm/atomic: Update legacy DPMS state during modesets, v2. Date: Mon, 27 Jul 2015 13:16:25 +0200 Message-ID: <20150727111625.GT16722@phenom.ffwll.local> References: <1437037166-9339-1-git-send-email-maarten.lankhorst@linux.intel.com> <1437037166-9339-3-git-send-email-maarten.lankhorst@linux.intel.com> <20150716091956.GE6223@phenom.ffwll.local> <55A77832.3050908@linux.intel.com> <20150716093123.GH6223@phenom.ffwll.local> <55B61034.8000909@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <55B61034.8000909@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBKdWwgMjcsIDIwMTUgYXQgMDE6MDQ6MjBQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhpcyBpcyByZXF1aXJlZCBmb3IgRFBNUyB0byB3b3JrIGNvcnJlY3RseSwg ZHVyaW5nIGEgbW9kZXNldAo+IHRoZSBEUE1TIHByb3BlcnR5IHNob3VsZCBiZSB0dXJuZWQgb2Zm LCB1bmxlc3MgdGhlIHN0YXRlIGlzCj4gY3J0YyBpcyBtYWRlIGFjdGl2ZSBpbiB3aGljaCBjYXNl IGl0IHNob3VsZCBiZSBzZXQgdG8gRFBNUyBvbi4KPiAKPiBUaGUgbGVnYWN5IGRwbXMgaGFuZGxp bmcgcGVyZm9ybXMgaXRzIG93biBkcG1zIHVwZGF0ZXMsIHNvIGFkZCBhCj4gcHJvcGVydHkgdG8g cHJldmVudCB1cGRhdGluZyB0aGUgbGVnYWN5IGRwbXMgc3RhdGUgYW5kIHVzZSBpdAo+IGluIHRo ZSBhdG9taWMgZHBtcyBoZWxwZXJzIGFuZCBpOTE1IHN1c3BlbmQvcmVzdW1lLgo+IAo+IENoYW5n ZXMgc2luY2UgdjE6Cj4gLSBTZXQgRFBNUyB0byBvZmYgd2hlbiBhIGNvbm5lY3RvciBpcyByZW1v dmVkIGZyb20gYSBjcnRjIHRvby4KPiAtIFVwZGF0ZSB0aGUgbGVnYWN5IGRwbXMgcHJvcGVydHkg dG9vLgo+IC0gQWRkIGFuIGV4Y2VwdGlvbiBmb3IgdGhlIGxlZ2FjeSBkcG1zIHBhdGhzLCBpdCB1 cGRhdGVzIGl0cyBvd24gc3RhdGUuCj4gLSBBZGQgYW4gZXhjZXB0aW9uIGZvciBpOTE1IHN1c3Bl bmQvcmVzdW1lLCBpdCBzaG91bGQgcHJlc2VydmUgZHBtcyBzdGF0ZS4KCk15IGlkZWEgYmVoaW5k IHVwZGF0aW5nIHRoZSBkcG1zIHByb3Agd2FzIHRvIG5vdCBjb25mdXNlIGxlZ2FjeSB1c2Vyc3Bh Y2UuCkFuZCBsZWdhY3kgdXNlcnNwYWNlIGFsd2F5cyBkb2VzIGFuIGFsbC1vci1ub3RoaW5nIGRw bXMgb3ZlciBhbGwKY29ubmVjdG9ycyBhbnl3YXksIHNvIEkgZG9uJ3QgdGhpbmsgd2UgbmVlZCB0 byBnbyB0byBhbnkgbGVuZ3RoIHRvCnByZXNlcnZlIHRoYXQuIElmIHdlJ2QgbmVlZCB0byB3ZSB3 b24ndCBiZSBhYmxlIHRvIG1vdmUgZHBtcyBmcm9tCmNvbm5lY3RvciB0byB0aGUgY3J0YyBhbnl3 YXkuIFRoZXJlZm9yZSBJIHRoaW5rIHByZXNlcnZlX2RwbXMgaXNuJ3QgbmVlZGVkCmFuZCB3ZSBj YW4gZHJvcCB0aGF0IG9uZS4KLURhbmllbAoKPiAKPiBDYzogZHJpLWRldmVsQGxpc3RzLmZyZWVk ZXNrdG9wLm9yZwo+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxh bmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gLS0tCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9kcm1fYXRvbWljX2hlbHBlci5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVs cGVyLmMKPiBpbmRleCA1ZWMxM2M3Y2M4MzIuLmY0NjNmOGNlOGY0ZCAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fYXRvbWljX2hlbHBlci5jCj4gQEAgLTY2MCwxNSArNjYwLDMzIEBAIGRybV9hdG9taWNf aGVscGVyX3VwZGF0ZV9sZWdhY3lfbW9kZXNldF9zdGF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 LAo+ICAJc3RydWN0IGRybV9jcnRjX3N0YXRlICpvbGRfY3J0Y19zdGF0ZTsKPiAgCWludCBpOwo+ ICAKPiAtCS8qIGNsZWFyIG91dCBleGlzdGluZyBsaW5rcyAqLwo+ICsJLyogY2xlYXIgb3V0IGV4 aXN0aW5nIGxpbmtzIGFuZCB1cGRhdGUgZHBtcyAqLwo+ICAJZm9yX2VhY2hfY29ubmVjdG9yX2lu X3N0YXRlKG9sZF9zdGF0ZSwgY29ubmVjdG9yLCBvbGRfY29ubl9zdGF0ZSwgaSkgewo+IC0JCWlm ICghY29ubmVjdG9yLT5lbmNvZGVyKQo+ICsJCWlmIChjb25uZWN0b3ItPmVuY29kZXIpIHsKPiAr CQkJV0FSTl9PTighY29ubmVjdG9yLT5lbmNvZGVyLT5jcnRjKTsKPiArCj4gKwkJCWNvbm5lY3Rv ci0+ZW5jb2Rlci0+Y3J0YyA9IE5VTEw7Cj4gKwkJCWNvbm5lY3Rvci0+ZW5jb2RlciA9IE5VTEw7 Cj4gKwkJfQo+ICsKPiArCQlpZiAob2xkX3N0YXRlLT5wcmVzZXJ2ZV9kcG1zKQo+ICAJCQljb250 aW51ZTsKPiAgCj4gLQkJV0FSTl9PTighY29ubmVjdG9yLT5lbmNvZGVyLT5jcnRjKTsKPiArCQlj cnRjID0gY29ubmVjdG9yLT5zdGF0ZS0+Y3J0YzsKPiAgCj4gLQkJY29ubmVjdG9yLT5lbmNvZGVy LT5jcnRjID0gTlVMTDsKPiAtCQljb25uZWN0b3ItPmVuY29kZXIgPSBOVUxMOwo+ICsJCWlmICgo IWNydGMgJiYgb2xkX2Nvbm5fc3RhdGUtPmNydGMpIHx8Cj4gKwkJICAgIChjcnRjICYmIGRybV9h dG9taWNfY3J0Y19uZWVkc19tb2Rlc2V0KGNydGMtPnN0YXRlKSkpIHsKPiArCQkJc3RydWN0IGRy bV9wcm9wZXJ0eSAqZHBtc19wcm9wID0KPiArCQkJCWRldi0+bW9kZV9jb25maWcuZHBtc19wcm9w ZXJ0eTsKPiArCQkJaW50IG1vZGUgPSBEUk1fTU9ERV9EUE1TX09GRjsKPiArCj4gKwkJCWlmIChj cnRjICYmIGNydGMtPnN0YXRlLT5hY3RpdmUpCj4gKwkJCQltb2RlID0gRFJNX01PREVfRFBNU19P TjsKPiArCj4gKwkJCWNvbm5lY3Rvci0+ZHBtcyA9IG1vZGU7Cj4gKwkJCWRybV9vYmplY3RfcHJv cGVydHlfc2V0X3ZhbHVlKCZjb25uZWN0b3ItPmJhc2UsCj4gKwkJCQkJCSAgICAgIGRwbXNfcHJv cCwgbW9kZSk7Cj4gKwkJfQo+ICAJfQo+ICAKPiAgCS8qIHNldCBuZXcgbGlua3MgKi8KPiBAQCAt MjAwMSw2ICsyMDE5LDcgQEAgdm9pZCBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfZHBtcyhz dHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yLAo+ICAJCXJldHVybjsKPiAgCj4gIAlzdGF0 ZS0+YWNxdWlyZV9jdHggPSBkcm1fbW9kZXNldF9sZWdhY3lfYWNxdWlyZV9jdHgoY3J0Yyk7Cj4g KwlzdGF0ZS0+cHJlc2VydmVfZHBtcyA9IHRydWU7Cj4gIHJldHJ5Ogo+ICAJY3J0Y19zdGF0ZSA9 IGRybV9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+ICAJaWYgKElTX0VSUihj cnRjX3N0YXRlKSkKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5kZXggMjhm Zjc1YmM5ZTA0Li40ZTQ5YjY2NjdmZmEgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gQEAgLTYyNDYsNyArNjI0Niw3IEBAIGludCBpbnRlbF9kaXNwbGF5X3N1c3BlbmQo c3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgCQlyZXR1cm4gLUVOT01FTTsKPiAgCj4gIAlzdGF0 ZS0+YWNxdWlyZV9jdHggPSBjdHg7Cj4gLQlzdGF0ZS0+YWxsb3dfbW9kZXNldCA9IHRydWU7Cj4g KwlzdGF0ZS0+cHJlc2VydmVfZHBtcyA9IHRydWU7Cj4gIAo+ICAJZm9yX2VhY2hfY3J0YyhkZXYs IGNydGMpIHsKPiAgCQlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUgPQo+IEBAIC02 MzA5LDcgKzYzMDksNyBAQCBpbnQgaW50ZWxfY3J0Y19jb250cm9sKHN0cnVjdCBkcm1fY3J0YyAq Y3J0YywgYm9vbCBlbmFibGUpCj4gIAkJcmV0dXJuIC1FTk9NRU07Cj4gIAo+ICAJc3RhdGUtPmFj cXVpcmVfY3R4ID0gY3R4Owo+IC0Jc3RhdGUtPmFsbG93X21vZGVzZXQgPSB0cnVlOwo+ICsJc3Rh dGUtPnByZXNlcnZlX2RwbXMgPSB0cnVlOwo+ICAKPiAgCXBpcGVfY29uZmlnID0gaW50ZWxfYXRv bWljX2dldF9jcnRjX3N0YXRlKHN0YXRlLCBpbnRlbF9jcnRjKTsKPiAgCWlmIChJU19FUlIocGlw ZV9jb25maWcpKSB7Cj4gQEAgLTEyMzU4LDE2ICsxMjM1OCw5IEBAIGludGVsX21vZGVzZXRfdXBk YXRlX3N0YXRlKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSkKPiAgCQkJY29udGludWU7 Cj4gIAo+ICAJCWlmIChjcnRjLT5zdGF0ZS0+YWN0aXZlKSB7Cj4gLQkJCXN0cnVjdCBkcm1fcHJv cGVydHkgKmRwbXNfcHJvcGVydHkgPQo+IC0JCQkJZGV2LT5tb2RlX2NvbmZpZy5kcG1zX3Byb3Bl cnR5Owo+IC0KPiAtCQkJY29ubmVjdG9yLT5kcG1zID0gRFJNX01PREVfRFBNU19PTjsKPiAtCQkJ ZHJtX29iamVjdF9wcm9wZXJ0eV9zZXRfdmFsdWUoJmNvbm5lY3Rvci0+YmFzZSwgZHBtc19wcm9w ZXJ0eSwgRFJNX01PREVfRFBNU19PTik7Cj4gLQo+ICAJCQlpbnRlbF9lbmNvZGVyID0gdG9faW50 ZWxfZW5jb2Rlcihjb25uZWN0b3ItPmVuY29kZXIpOwo+ICAJCQlpbnRlbF9lbmNvZGVyLT5jb25u ZWN0b3JzX2FjdGl2ZSA9IHRydWU7Cj4gLQkJfSBlbHNlCj4gLQkJCWNvbm5lY3Rvci0+ZHBtcyA9 IERSTV9NT0RFX0RQTVNfT0ZGOwo+ICsJCX0KPiAgCX0KPiAgfQo+ICAKPiBAQCAtMTU0MTcsNiAr MTU0MTAsNyBAQCB2b2lkIGludGVsX2Rpc3BsYXlfcmVzdW1lKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpCj4gIAkJcmV0dXJuOwo+ICAKPiAgCXN0YXRlLT5hY3F1aXJlX2N0eCA9IGRldi0+bW9kZV9j b25maWcuYWNxdWlyZV9jdHg7Cj4gKwlzdGF0ZS0+cHJlc2VydmVfZHBtcyA9IHRydWU7Cj4gIAo+ ICAJLyogcHJlc2VydmUgY29tcGxldGUgb2xkIHN0YXRlLCBpbmNsdWRpbmcgZHBsbCAqLwo+ICAJ aW50ZWxfYXRvbWljX2dldF9zaGFyZWRfZHBsbF9zdGF0ZShzdGF0ZSk7Cj4gZGlmZiAtLWdpdCBh L2luY2x1ZGUvZHJtL2RybV9jcnRjLmggYi9pbmNsdWRlL2RybS9kcm1fY3J0Yy5oCj4gaW5kZXgg OTBhMGZmNzAzODRhLi42NGQ0OTMwN2M3NmQgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVkZS9kcm0vZHJt X2NydGMuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jcnRjLmgKPiBAQCAtOTM3LDYgKzkzNyw3 IEBAIHN0cnVjdCBkcm1fYnJpZGdlIHsKPiAgICogQGRldjogcGFyZW50IERSTSBkZXZpY2UKPiAg ICogQGFsbG93X21vZGVzZXQ6IGFsbG93IGZ1bGwgbW9kZXNldAo+ICAgKiBAbGVnYWN5X2N1cnNv cl91cGRhdGU6IGhpbnQgdG8gZW5mb3JjZSBsZWdhY3kgY3Vyc29yIGlvY3RsIHNlbWFudGljcwo+ ICsgKiBAcHJlc2VydmVfZHBtczogdGhlIGNhbGxlciB3YW50cyB0byBwcmVzZXJ2ZSBjb25uZWN0 b3ItPmRwbXMgc3RhdGUuCj4gICAqIEBwbGFuZXM6IHBvaW50ZXIgdG8gYXJyYXkgb2YgcGxhbmUg cG9pbnRlcnMKPiAgICogQHBsYW5lX3N0YXRlczogcG9pbnRlciB0byBhcnJheSBvZiBwbGFuZSBz dGF0ZXMgcG9pbnRlcnMKPiAgICogQGNydGNzOiBwb2ludGVyIHRvIGFycmF5IG9mIENSVEMgcG9p bnRlcnMKPiBAQCAtOTUwLDYgKzk1MSw3IEBAIHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlIHsKPiAg CXN0cnVjdCBkcm1fZGV2aWNlICpkZXY7Cj4gIAlib29sIGFsbG93X21vZGVzZXQgOiAxOwo+ICAJ Ym9vbCBsZWdhY3lfY3Vyc29yX3VwZGF0ZSA6IDE7Cj4gKwlib29sIHByZXNlcnZlX2RwbXMgOiAx Owo+ICAJc3RydWN0IGRybV9wbGFuZSAqKnBsYW5lczsKPiAgCXN0cnVjdCBkcm1fcGxhbmVfc3Rh dGUgKipwbGFuZV9zdGF0ZXM7Cj4gIAlzdHJ1Y3QgZHJtX2NydGMgKipjcnRjczsKPiAKCi0tIApE YW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8v YmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=