From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 1/7] drm: Fix DP_TEST_COUNT_MASK Date: Mon, 27 Jul 2015 13:23:44 +0200 Message-ID: <20150727112344.GB24957@ulmo> References: <1437694498-5517-1-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0768269102==" Return-path: In-Reply-To: <1437694498-5517-1-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============0768269102== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="61jdw2sOBCFtR2d/" Content-Disposition: inline --61jdw2sOBCFtR2d/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 23, 2015 at 04:34:58PM -0700, Rodrigo Vivi wrote: > By Vesa's DP 1.2 Spec this counter has 4 bits [3:0]. >=20 > This mask is wrong since when the counter was introduced by myself > on commit ad9dc91b6e21266bfc6f466db4b95e10211f31ee > Author: Rodrigo Vivi > Date: Tue Sep 16 19:18:12 2014 -0400 >=20 > drm/i915: Fix Sink CRC >=20 > Signed-off-by: Rodrigo Vivi > --- > include/drm/drm_dp_helper.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h > index 2e86f64..94898f6 100644 > --- a/include/drm/drm_dp_helper.h > +++ b/include/drm/drm_dp_helper.h > @@ -420,7 +420,7 @@ > =20 > #define DP_TEST_SINK_MISC 0x246 > # define DP_TEST_CRC_SUPPORTED (1 << 5) > -# define DP_TEST_COUNT_MASK 0x7 > +# define DP_TEST_COUNT_MASK 0xf According to the specification this field should really be called DP_TEST_CRC_COUNT_MASK, because it counts the number of times that the TEST_CRC_* registers are updated. That could be a separate patch, though. Thierry --61jdw2sOBCFtR2d/ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVthS/AAoJEN0jrNd/PrOhP1wP/RslW9PXvIe24sWoNhREsAq8 8f3mmXVWDKAqwTe2r8NO5bR+0qZ2fTtYJxhNcFJ3qfpBok/G2V3nxQsrosggZtWm elUHioqt0mVYbSWpLeFLd1U3TWTg+MlMCqTPZ/wivMW3A9hyH05+YoxmQHIMIw1E TEKTYxD1DviB7GerLFteIvAKoSLNdeaZbT13f2rTA8psXOlQFOEeLwe2IEbXNtgE ktGJtT4YN9vJx8stjIeYCFe9xR4FIkMal3RBJS2ATqvkWDze1SPpzzwAa9eL4v/6 41ZerfV1Ysc8RGSwnk0bGPuiFMLo1hyP105WSYtC1FFlmTPA1Pc1pXAntv+ODLYh q6d2UEbfxTmMZTzpFEdpkIeyNLfba3lmxYIJp3MomJLHZma5LEDaLInETCk2XU8n ZL38q3Dzh4MySAYkzfP0qremh5UIBfqiJES3ir4CWsp2mWXtlz+gfTDPgj9dbnLd MIqt9uKh2iKM7xnToMHlkOFJKIPEKuoKx3JD1bG7gW1qsXGg+aIhBzRx7syzoGia BJmdhfQOjF9+nPK0AkHyX9/HUAgtyRxmZbQFvTb7Zk2nw7wlmMoWVqWFWpbvNsLK Tg04DhWfU557u1LxFyV/HQSV7nWU57n4b1mEETTmLebga/DcUJm/1Iw6pmQ/DOeZ Pxr0zMFvr7AmSnZpNMco =W4cy -----END PGP SIGNATURE----- --61jdw2sOBCFtR2d/-- --===============0768269102== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============0768269102==--