From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rafael Antognolli Subject: Re: [PATCH 4/7] drm/i915: Split sink_crc function in start, stop and read. Date: Tue, 28 Jul 2015 13:10:38 -0700 Message-ID: <20150728201038.GA5902@intel.com> References: <1437694550-5667-1-git-send-email-rodrigo.vivi@intel.com> <1437694550-5667-3-git-send-email-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id B42CD88784 for ; Tue, 28 Jul 2015 13:13:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1437694550-5667-3-git-send-email-rodrigo.vivi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rodrigo Vivi Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdWwgMjMsIDIwMTUgYXQgMDQ6MzU6NDdQTSAtMDcwMCwgUm9kcmlnbyBWaXZpIHdy b3RlOgo+IE5vIGZ1bmN0aW9uYWwgY2hhbmdlLiBKdXN0IGEgcHJlcGFyYXRpb24gcGF0Y2ggdG8g bWFrZSBjbGVhcgo+IHdoYXQgb3BlcmF0aW9uIHdlIGFyZSBwZXJmb3JtaW5nLgo+IAo+IFNpZ25l ZC1vZmYtYnk6IFJvZHJpZ28gVml2aSA8cm9kcmlnby52aXZpQGludGVsLmNvbT4KCkdvb2QuIFRo ZSBwbGFjZSB3aGVyZSB5b3UgY2FsbCBoc3dfZGlzYWJsZV9pcHMoKSBjaGFuZ2VzLCBidXQgYXMg eW91CmV4cGxhaW5lZCBlYXJsaWVyLCB0aGlzIGlzIHJlcXVpcmVkLgoKUmV2aWV3ZWQtYnk6IFJh ZmFlbCBBbnRvZ25vbGxpIDxyYWZhZWwuYW50b2dub2xsaUBpbnRlbC5jb20+Cgo+IC0tLQo+ICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIHwgODkgKysrKysrKysrKysrKysrKysrKysr KystLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUwIGluc2VydGlvbnMoKyks IDM5IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+IGluZGV4IDQ0Zjhh MzIuLjEwY2JjOTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAu Ywo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtMzk1OCw0MCAr Mzk1OCw2NCBAQCBpbnRlbF9kcF9wcm9iZV9tc3Qoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCkK PiAgCXJldHVybiBpbnRlbF9kcC0+aXNfbXN0Owo+ICB9Cj4gIAo+IC1pbnQgaW50ZWxfZHBfc2lu a19jcmMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgdTggKmNyYykKPiArc3RhdGljIHZvaWQg aW50ZWxfZHBfc2lua19jcmNfc3RvcChzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwKQo+ICB7Cj4g LQlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9IGRwX3RvX2RpZ19w b3J0KGludGVsX2RwKTsKPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9kaWdfcG9y dC0+YmFzZS5iYXNlLmRldjsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0KPiAt CQl0b19pbnRlbF9jcnRjKGludGVsX2RpZ19wb3J0LT5iYXNlLmJhc2UuY3J0Yyk7Cj4gKwlzdHJ1 Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2Rw KTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhkaWdf cG9ydC0+YmFzZS5iYXNlLmNydGMpOwo+ICAJdTggYnVmOwo+IC0JaW50IHRlc3RfY3JjX2NvdW50 Owo+IC0JaW50IGF0dGVtcHRzID0gNjsKPiAtCWludCByZXQgPSAwOwo+IC0KPiAtCWhzd19kaXNh YmxlX2lwcyhpbnRlbF9jcnRjKTsKPiAgCj4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVs X2RwLT5hdXgsIERQX1RFU1RfU0lOS19NSVNDLCAmYnVmKSA8IDApIHsKPiAtCQlyZXQgPSAtRUlP Owo+IC0JCWdvdG8gb3V0Owo+ICsJaWYgKGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4 LCBEUF9URVNUX1NJTkssICZidWYpIDwgMCkgewo+ICsJCURSTV9ERUJVR19LTVMoIlNpbmsgQ1JD IGNvdWxkbid0IGJlIHN0b3BwZWQgcHJvcGVybHlcbiIpOwo+ICsJCXJldHVybjsKPiAgCX0KPiAg Cj4gLQlpZiAoIShidWYgJiBEUF9URVNUX0NSQ19TVVBQT1JURUQpKSB7Cj4gLQkJcmV0ID0gLUVO T1RUWTsKPiAtCQlnb3RvIG91dDsKPiAtCX0KPiArCWlmIChkcm1fZHBfZHBjZF93cml0ZWIoJmlu dGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOSywKPiArCQkJICAgICAgIGJ1ZiAmIH5EUF9URVNUX1NJ TktfU1RBUlQpIDwgMCkKPiArCQlEUk1fREVCVUdfS01TKCJTaW5rIENSQyBjb3VsZG4ndCBiZSBz dG9wcGVkIHByb3Blcmx5XG4iKTsKPiAgCj4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVs X2RwLT5hdXgsIERQX1RFU1RfU0lOSywgJmJ1ZikgPCAwKSB7Cj4gLQkJcmV0ID0gLUVJTzsKPiAt CQlnb3RvIG91dDsKPiAtCX0KPiArCWhzd19lbmFibGVfaXBzKGludGVsX2NydGMpOwo+ICt9Cj4g Kwo+ICtzdGF0aWMgaW50IGludGVsX2RwX3NpbmtfY3JjX3N0YXJ0KHN0cnVjdCBpbnRlbF9kcCAq aW50ZWxfZHApCj4gK3sKPiArCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0g ZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+ICsJc3RydWN0IGludGVsX2NydGMgKmludGVsX2Ny dGMgPSB0b19pbnRlbF9jcnRjKGRpZ19wb3J0LT5iYXNlLmJhc2UuY3J0Yyk7Cj4gKwl1OCBidWY7 Cj4gKwo+ICsJaWYgKGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJ TktfTUlTQywgJmJ1ZikgPCAwKQo+ICsJCXJldHVybiAtRUlPOwo+ICsKPiArCWlmICghKGJ1ZiAm IERQX1RFU1RfQ1JDX1NVUFBPUlRFRCkpCj4gKwkJcmV0dXJuIC1FTk9UVFk7Cj4gKwo+ICsJaWYg KGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTkssICZidWYpIDwg MCkKPiArCQlyZXR1cm4gLUVJTzsKPiArCj4gKwloc3dfZGlzYWJsZV9pcHMoaW50ZWxfY3J0Yyk7 Cj4gIAo+ICAJaWYgKGRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9T SU5LLAo+IC0JCQkJYnVmIHwgRFBfVEVTVF9TSU5LX1NUQVJUKSA8IDApIHsKPiAtCQlyZXQgPSAt RUlPOwo+IC0JCWdvdG8gb3V0Owo+ICsJCQkgICAgICAgYnVmIHwgRFBfVEVTVF9TSU5LX1NUQVJU KSA8IDApIHsKPiArCQloc3dfZW5hYmxlX2lwcyhpbnRlbF9jcnRjKTsKPiArCQlyZXR1cm4gLUVJ TzsKPiAgCX0KPiAgCj4gKwlyZXR1cm4gMDsKPiArfQo+ICsKPiAraW50IGludGVsX2RwX3Npbmtf Y3JjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHU4ICpjcmMpCj4gK3sKPiArCXN0cnVjdCBp bnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+ ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2Owo+ICsJ c3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGRpZ19wb3J0LT5i YXNlLmJhc2UuY3J0Yyk7Cj4gKwl1OCBidWY7Cj4gKwlpbnQgdGVzdF9jcmNfY291bnQ7Cj4gKwlp bnQgYXR0ZW1wdHMgPSA2Owo+ICsJaW50IHJldDsKPiArCj4gKwlyZXQgPSBpbnRlbF9kcF9zaW5r X2NyY19zdGFydChpbnRlbF9kcCk7Cj4gKwlpZiAocmV0KQo+ICsJCXJldHVybiByZXQ7Cj4gKwo+ ICAJaWYgKGRybV9kcF9kcGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTktfTUlT QywgJmJ1ZikgPCAwKSB7Cj4gIAkJcmV0ID0gLUVJTzsKPiAgCQlnb3RvIHN0b3A7Cj4gQEAgLTQw MTQsMjMgKzQwMzgsMTAgQEAgaW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRlbF9kcCAq aW50ZWxfZHAsIHU4ICpjcmMpCj4gIAkJZ290byBzdG9wOwo+ICAJfQo+ICAKPiAtCWlmIChkcm1f ZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX0NSQ19SX0NSLCBjcmMsIDYpIDwg MCkgewo+ICsJaWYgKGRybV9kcF9kcGNkX3JlYWQoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfQ1JD X1JfQ1IsIGNyYywgNikgPCAwKQo+ICAJCXJldCA9IC1FSU87Cj4gLQkJZ290byBzdG9wOwo+IC0J fQo+IC0KPiAgc3RvcDoKPiAtCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwg RFBfVEVTVF9TSU5LLCAmYnVmKSA8IDApIHsKPiAtCQlEUk1fREVCVUdfS01TKCJTaW5rIENSQyBj b3VsZG4ndCBiZSBzdG9wcGVkIHByb3Blcmx5XG4iKTsKPiAtCQlnb3RvIG91dDsKPiAtCX0KPiAt CWlmIChkcm1fZHBfZHBjZF93cml0ZWIoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOSywKPiAt CQkJICAgICAgIGJ1ZiAmIH5EUF9URVNUX1NJTktfU1RBUlQpIDwgMCkgewo+IC0JCURSTV9ERUJV R19LTVMoIlNpbmsgQ1JDIGNvdWxkbid0IGJlIHN0b3BwZWQgcHJvcGVybHlcbiIpOwo+IC0JCWdv dG8gb3V0Owo+IC0JfQo+IC1vdXQ6Cj4gLQloc3dfZW5hYmxlX2lwcyhpbnRlbF9jcnRjKTsKPiAr CWludGVsX2RwX3NpbmtfY3JjX3N0b3AoaW50ZWxfZHApOwo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ ICAKPiAtLSAKPiAyLjEuMAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwt Z2Z4Cg==