From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/7] drm/i915: Split sink_crc function in start, stop and read. Date: Wed, 29 Jul 2015 10:24:52 +0200 Message-ID: <20150729082452.GR16722@phenom.ffwll.local> References: <1437694550-5667-1-git-send-email-rodrigo.vivi@intel.com> <1437694550-5667-3-git-send-email-rodrigo.vivi@intel.com> <20150728201038.GA5902@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F2956E0FB for ; Wed, 29 Jul 2015 01:22:14 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so189700406wib.0 for ; Wed, 29 Jul 2015 01:22:13 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150728201038.GA5902@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rafael Antognolli Cc: intel-gfx@lists.freedesktop.org, Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdWwgMjgsIDIwMTUgYXQgMDE6MTA6MzhQTSAtMDcwMCwgUmFmYWVsIEFudG9nbm9s bGkgd3JvdGU6Cj4gT24gVGh1LCBKdWwgMjMsIDIwMTUgYXQgMDQ6MzU6NDdQTSAtMDcwMCwgUm9k cmlnbyBWaXZpIHdyb3RlOgo+ID4gTm8gZnVuY3Rpb25hbCBjaGFuZ2UuIEp1c3QgYSBwcmVwYXJh dGlvbiBwYXRjaCB0byBtYWtlIGNsZWFyCj4gPiB3aGF0IG9wZXJhdGlvbiB3ZSBhcmUgcGVyZm9y bWluZy4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlA aW50ZWwuY29tPgo+IAo+IEdvb2QuIFRoZSBwbGFjZSB3aGVyZSB5b3UgY2FsbCBoc3dfZGlzYWJs ZV9pcHMoKSBjaGFuZ2VzLCBidXQgYXMgeW91Cj4gZXhwbGFpbmVkIGVhcmxpZXIsIHRoaXMgaXMg cmVxdWlyZWQuCgpUaGF0IGV4cGxhbmF0aW9uIHNob3VsZCBiZSBpbiB0aGUgY29tbWl0IG1lc3Nh Z2UuIE1lcmdlZCB0aGUgdHdvIGVhcmxpZXIKcGF0Y2hlcyBpbiB0aGUgc2VyaWVzIG1lYW53aGls ZS4KLURhbmllbAoKPiAKPiBSZXZpZXdlZC1ieTogUmFmYWVsIEFudG9nbm9sbGkgPHJhZmFlbC5h bnRvZ25vbGxpQGludGVsLmNvbT4KPiAKPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2RwLmMgfCA4OSArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0t LQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCA1MCBpbnNlcnRpb25zKCspLCAzOSBkZWxldGlvbnMoLSkK PiA+IAo+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiBpbmRleCA0NGY4YTMyLi4xMGNiYzk4 IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gQEAgLTM5NTgsNDAgKzM5NTgs NjQgQEAgaW50ZWxfZHBfcHJvYmVfbXN0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gPiAg CXJldHVybiBpbnRlbF9kcC0+aXNfbXN0Owo+ID4gIH0KPiA+ICAKPiA+IC1pbnQgaW50ZWxfZHBf c2lua19jcmMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgdTggKmNyYykKPiA+ICtzdGF0aWMg dm9pZCBpbnRlbF9kcF9zaW5rX2NyY19zdG9wKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4g PiAgewo+ID4gLQlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICppbnRlbF9kaWdfcG9ydCA9IGRw X3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiA+IC0Jc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGlu dGVsX2RpZ19wb3J0LT5iYXNlLmJhc2UuZGV2Owo+ID4gLQlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50 ZWxfY3J0YyA9Cj4gPiAtCQl0b19pbnRlbF9jcnRjKGludGVsX2RpZ19wb3J0LT5iYXNlLmJhc2Uu Y3J0Yyk7Cj4gPiArCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gZHBfdG9f ZGlnX3BvcnQoaW50ZWxfZHApOwo+ID4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9 IHRvX2ludGVsX2NydGMoZGlnX3BvcnQtPmJhc2UuYmFzZS5jcnRjKTsKPiA+ICAJdTggYnVmOwo+ ID4gLQlpbnQgdGVzdF9jcmNfY291bnQ7Cj4gPiAtCWludCBhdHRlbXB0cyA9IDY7Cj4gPiAtCWlu dCByZXQgPSAwOwo+ID4gLQo+ID4gLQloc3dfZGlzYWJsZV9pcHMoaW50ZWxfY3J0Yyk7Cj4gPiAg Cj4gPiAtCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5L X01JU0MsICZidWYpIDwgMCkgewo+ID4gLQkJcmV0ID0gLUVJTzsKPiA+IC0JCWdvdG8gb3V0Owo+ ID4gKwlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOSywg JmJ1ZikgPCAwKSB7Cj4gPiArCQlEUk1fREVCVUdfS01TKCJTaW5rIENSQyBjb3VsZG4ndCBiZSBz dG9wcGVkIHByb3Blcmx5XG4iKTsKPiA+ICsJCXJldHVybjsKPiA+ICAJfQo+ID4gIAo+ID4gLQlp ZiAoIShidWYgJiBEUF9URVNUX0NSQ19TVVBQT1JURUQpKSB7Cj4gPiAtCQlyZXQgPSAtRU5PVFRZ Owo+ID4gLQkJZ290byBvdXQ7Cj4gPiAtCX0KPiA+ICsJaWYgKGRybV9kcF9kcGNkX3dyaXRlYigm aW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LLAo+ID4gKwkJCSAgICAgICBidWYgJiB+RFBfVEVT VF9TSU5LX1NUQVJUKSA8IDApCj4gPiArCQlEUk1fREVCVUdfS01TKCJTaW5rIENSQyBjb3VsZG4n dCBiZSBzdG9wcGVkIHByb3Blcmx5XG4iKTsKPiA+ICAKPiA+IC0JaWYgKGRybV9kcF9kcGNkX3Jl YWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTkssICZidWYpIDwgMCkgewo+ID4gLQkJcmV0 ID0gLUVJTzsKPiA+IC0JCWdvdG8gb3V0Owo+ID4gLQl9Cj4gPiArCWhzd19lbmFibGVfaXBzKGlu dGVsX2NydGMpOwo+ID4gK30KPiA+ICsKPiA+ICtzdGF0aWMgaW50IGludGVsX2RwX3NpbmtfY3Jj X3N0YXJ0KHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gPiArewo+ID4gKwlzdHJ1Y3QgaW50 ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9IGRwX3RvX2RpZ19wb3J0KGludGVsX2RwKTsKPiA+ ICsJc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGRpZ19wb3J0 LT5iYXNlLmJhc2UuY3J0Yyk7Cj4gPiArCXU4IGJ1ZjsKPiA+ICsKPiA+ICsJaWYgKGRybV9kcF9k cGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTktfTUlTQywgJmJ1ZikgPCAwKQo+ ID4gKwkJcmV0dXJuIC1FSU87Cj4gPiArCj4gPiArCWlmICghKGJ1ZiAmIERQX1RFU1RfQ1JDX1NV UFBPUlRFRCkpCj4gPiArCQlyZXR1cm4gLUVOT1RUWTsKPiA+ICsKPiA+ICsJaWYgKGRybV9kcF9k cGNkX3JlYWRiKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTkssICZidWYpIDwgMCkKPiA+ICsJ CXJldHVybiAtRUlPOwo+ID4gKwo+ID4gKwloc3dfZGlzYWJsZV9pcHMoaW50ZWxfY3J0Yyk7Cj4g PiAgCj4gPiAgCWlmIChkcm1fZHBfZHBjZF93cml0ZWIoJmludGVsX2RwLT5hdXgsIERQX1RFU1Rf U0lOSywKPiA+IC0JCQkJYnVmIHwgRFBfVEVTVF9TSU5LX1NUQVJUKSA8IDApIHsKPiA+IC0JCXJl dCA9IC1FSU87Cj4gPiAtCQlnb3RvIG91dDsKPiA+ICsJCQkgICAgICAgYnVmIHwgRFBfVEVTVF9T SU5LX1NUQVJUKSA8IDApIHsKPiA+ICsJCWhzd19lbmFibGVfaXBzKGludGVsX2NydGMpOwo+ID4g KwkJcmV0dXJuIC1FSU87Cj4gPiAgCX0KPiA+ICAKPiA+ICsJcmV0dXJuIDA7Cj4gPiArfQo+ID4g Kwo+ID4gK2ludCBpbnRlbF9kcF9zaW5rX2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCB1 OCAqY3JjKQo+ID4gK3sKPiA+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQg PSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYg PSBkaWdfcG9ydC0+YmFzZS5iYXNlLmRldjsKPiA+ICsJc3RydWN0IGludGVsX2NydGMgKmludGVs X2NydGMgPSB0b19pbnRlbF9jcnRjKGRpZ19wb3J0LT5iYXNlLmJhc2UuY3J0Yyk7Cj4gPiArCXU4 IGJ1ZjsKPiA+ICsJaW50IHRlc3RfY3JjX2NvdW50Owo+ID4gKwlpbnQgYXR0ZW1wdHMgPSA2Owo+ ID4gKwlpbnQgcmV0Owo+ID4gKwo+ID4gKwlyZXQgPSBpbnRlbF9kcF9zaW5rX2NyY19zdGFydChp bnRlbF9kcCk7Cj4gPiArCWlmIChyZXQpCj4gPiArCQlyZXR1cm4gcmV0Owo+ID4gKwo+ID4gIAlp ZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOS19NSVNDLCAm YnVmKSA8IDApIHsKPiA+ICAJCXJldCA9IC1FSU87Cj4gPiAgCQlnb3RvIHN0b3A7Cj4gPiBAQCAt NDAxNCwyMyArNDAzOCwxMCBAQCBpbnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCwgdTggKmNyYykKPiA+ICAJCWdvdG8gc3RvcDsKPiA+ICAJfQo+ID4gIAo+ID4g LQlpZiAoZHJtX2RwX2RwY2RfcmVhZCgmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9DUkNfUl9DUiwg Y3JjLCA2KSA8IDApIHsKPiA+ICsJaWYgKGRybV9kcF9kcGNkX3JlYWQoJmludGVsX2RwLT5hdXgs IERQX1RFU1RfQ1JDX1JfQ1IsIGNyYywgNikgPCAwKQo+ID4gIAkJcmV0ID0gLUVJTzsKPiA+IC0J CWdvdG8gc3RvcDsKPiA+IC0JfQo+ID4gLQo+ID4gIHN0b3A6Cj4gPiAtCWlmIChkcm1fZHBfZHBj ZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LLCAmYnVmKSA8IDApIHsKPiA+IC0J CURSTV9ERUJVR19LTVMoIlNpbmsgQ1JDIGNvdWxkbid0IGJlIHN0b3BwZWQgcHJvcGVybHlcbiIp Owo+ID4gLQkJZ290byBvdXQ7Cj4gPiAtCX0KPiA+IC0JaWYgKGRybV9kcF9kcGNkX3dyaXRlYigm aW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LLAo+ID4gLQkJCSAgICAgICBidWYgJiB+RFBfVEVT VF9TSU5LX1NUQVJUKSA8IDApIHsKPiA+IC0JCURSTV9ERUJVR19LTVMoIlNpbmsgQ1JDIGNvdWxk bid0IGJlIHN0b3BwZWQgcHJvcGVybHlcbiIpOwo+ID4gLQkJZ290byBvdXQ7Cj4gPiAtCX0KPiA+ IC1vdXQ6Cj4gPiAtCWhzd19lbmFibGVfaXBzKGludGVsX2NydGMpOwo+ID4gKwlpbnRlbF9kcF9z aW5rX2NyY19zdG9wKGludGVsX2RwKTsKPiA+ICAJcmV0dXJuIHJldDsKPiA+ICB9Cj4gPiAgCj4g PiAtLSAKPiA+IDIuMS4wCj4gPiAKPiA+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0Cklu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=