From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 06/12] drm/i915: Make crtc checking use the atomic state. Date: Wed, 29 Jul 2015 14:04:13 +0200 Message-ID: <20150729120413.GV16722@phenom.ffwll.local> References: <1438000541-3219-1-git-send-email-maarten.lankhorst@linux.intel.com> <1438000541-3219-7-git-send-email-maarten.lankhorst@linux.intel.com> <1438170585.3839.8.camel@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id C17F06EBC9 for ; Wed, 29 Jul 2015 05:04:17 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so23070721wib.1 for ; Wed, 29 Jul 2015 05:04:16 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1438170585.3839.8.camel@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ander Conselvan De Oliveira Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMjksIDIwMTUgYXQgMDI6NDk6NDVQTSArMDMwMCwgQW5kZXIgQ29uc2VsdmFu IERlIE9saXZlaXJhIHdyb3RlOgo+IE9uIE1vbiwgMjAxNS0wNy0yNyBhdCAxNDozNSArMDIwMCwg TWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPiBJbnN0ZWFkIG9mIGFsbG9jYXRpbmcgcGlwZV9j b25maWcgb24gdGhlIHN0YWNrIHVzZSB0aGUgb2xkIGNydGNfc3RhdGUsCj4gPiBpdCdzIG9ubHkg Z29pbmcgdG8gZnJlZWQgZnJvbSB0aGlzIHBvaW50IG9uLgo+ID4gCj4gPiBBbGwgY3J0YydzIGVu Y29kZXJzIGFyZSBub3cgb25seSBjaGVja2VkIG9uY2UgZHVyaW5nIG1vZGVzZXQuCj4gPiAKPiA+ IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51 eC5pbnRlbC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMgfCAxMTggKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiA+ICAxIGZp bGUgY2hhbmdlZCwgNTYgaW5zZXJ0aW9ucygrKSwgNjIgZGVsZXRpb25zKC0pCj4gPiAKPiA+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+IGluZGV4IGZiYjI1N2Q0NzI4Yy4uZTNh ZmU2MTFhNzhjIDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ IEBAIC0xMTgyOSw3ICsxMTgyOSw3IEBAIHN0YXRpYyBpbnQgaW50ZWxfY3J0Y19hdG9taWNfY2hl Y2soc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gIAlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAq cGlwZV9jb25maWcgPQo+ID4gIAkJdG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjX3N0YXRlKTsKPiA+ ICAJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlID0gY3J0Y19zdGF0ZS0+c3RhdGU7Cj4g PiAtCWludCByZXQsIGlkeCA9IGNydGMtPmJhc2UuaWQ7Cj4gPiArCWludCByZXQ7Cj4gPiAgCWJv b2wgbW9kZV9jaGFuZ2VkID0gbmVlZHNfbW9kZXNldChjcnRjX3N0YXRlKTsKPiA+ICAKPiA+ICAJ aWYgKG1vZGVfY2hhbmdlZCAmJiAhY2hlY2tfZW5jb2Rlcl9jbG9uaW5nKHN0YXRlLCBpbnRlbF9j cnRjKSkgewo+ID4gQEAgLTExODM3LDEwICsxMTgzNyw2IEBAIHN0YXRpYyBpbnQgaW50ZWxfY3J0 Y19hdG9taWNfY2hlY2soc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4gIAkJcmV0dXJuIC1FSU5W QUw7Cj4gPiAgCX0KPiA+ICAKPiA+IC0JSTkxNV9TVEFURV9XQVJOKGNydGMtPnN0YXRlLT5hY3Rp dmUgIT0gaW50ZWxfY3J0Yy0+YWN0aXZlLAo+ID4gLQkJIltDUlRDOiVpXSBtaXNtYXRjaCBiZXR3 ZWVuIHN0YXRlLT5hY3RpdmUoJWkpIGFuZCBjcnRjLT5hY3RpdmUoJWkpXG4iLAo+ID4gLQkJaWR4 LCBjcnRjLT5zdGF0ZS0+YWN0aXZlLCBpbnRlbF9jcnRjLT5hY3RpdmUpOwo+ID4gLQo+ID4gIAlp ZiAobW9kZV9jaGFuZ2VkICYmICFjcnRjX3N0YXRlLT5hY3RpdmUpCj4gPiAgCQlpbnRlbF9jcnRj LT5hdG9taWMudXBkYXRlX3dtX3Bvc3QgPSB0cnVlOwo+ID4gIAo+ID4gQEAgLTEyNzIxLDE5ICsx MjcxNywxNiBAQCBjaGVja19lbmNvZGVyX3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4g PiAgCj4gPiAgCWZvcl9lYWNoX2ludGVsX2VuY29kZXIoZGV2LCBlbmNvZGVyKSB7Cj4gPiAgCQli b29sIGVuYWJsZWQgPSBmYWxzZTsKPiA+IC0JCWJvb2wgYWN0aXZlID0gZmFsc2U7Cj4gPiAtCQll bnVtIHBpcGUgcGlwZSwgdHJhY2tlZF9waXBlOwo+ID4gKwkJZW51bSBwaXBlIHBpcGU7Cj4gPiAg Cj4gPiAgCQlEUk1fREVCVUdfS01TKCJbRU5DT0RFUjolZDolc11cbiIsCj4gPiAgCQkJICAgICAg ZW5jb2Rlci0+YmFzZS5iYXNlLmlkLAo+ID4gIAkJCSAgICAgIGVuY29kZXItPmJhc2UubmFtZSk7 Cj4gPiAgCj4gPiAgCQlmb3JfZWFjaF9pbnRlbF9jb25uZWN0b3IoZGV2LCBjb25uZWN0b3IpIHsK PiA+IC0JCQlpZiAoY29ubmVjdG9yLT5iYXNlLmVuY29kZXIgIT0gJmVuY29kZXItPmJhc2UpCj4g PiArCQkJaWYgKGNvbm5lY3Rvci0+YmFzZS5zdGF0ZS0+YmVzdF9lbmNvZGVyICE9ICZlbmNvZGVy LT5iYXNlKQo+ID4gIAkJCQljb250aW51ZTsKPiA+ICAJCQllbmFibGVkID0gdHJ1ZTsKPiA+IC0J CQlpZiAoY29ubmVjdG9yLT5iYXNlLmRwbXMgIT0gRFJNX01PREVfRFBNU19PRkYpCj4gPiAtCQkJ CWFjdGl2ZSA9IHRydWU7Cj4gPiAgCj4gPiAgCQkJSTkxNV9TVEFURV9XQVJOKGNvbm5lY3Rvci0+ YmFzZS5zdGF0ZS0+Y3J0YyAhPQo+ID4gIAkJCQkJZW5jb2Rlci0+YmFzZS5jcnRjLAo+ID4gQEAg LTEyNzQ0LDg1ICsxMjczNyw4NiBAQCBjaGVja19lbmNvZGVyX3N0YXRlKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCj4gPiAgCQkgICAgICJlbmNvZGVyJ3MgZW5hYmxlZCBzdGF0ZSBtaXNtYXRjaCAi Cj4gPiAgCQkgICAgICIoZXhwZWN0ZWQgJWksIGZvdW5kICVpKVxuIiwKPiA+ICAJCSAgICAgISFl bmNvZGVyLT5iYXNlLmNydGMsIGVuYWJsZWQpOwo+ID4gLQkJSTkxNV9TVEFURV9XQVJOKGFjdGl2 ZSAmJiAhZW5jb2Rlci0+YmFzZS5jcnRjLAo+ID4gLQkJICAgICAiYWN0aXZlIGVuY29kZXIgd2l0 aCBubyBjcnRjXG4iKTsKPiA+IC0KPiA+IC0JCWFjdGl2ZSA9IGVuY29kZXItPmdldF9od19zdGF0 ZShlbmNvZGVyLCAmcGlwZSk7Cj4gPiAgCj4gPiAgCQlpZiAoIWVuY29kZXItPmJhc2UuY3J0Yykg ewo+ID4gLQkJCUk5MTVfU1RBVEVfV0FSTihhY3RpdmUsCj4gPiAtCQkJICAgICAiZW5jb2RlciBk ZXRhY2hlZCBidXQgbm90IHR1cm5lZCBvZmYuXG4iKTsKPiA+ICsJCQlib29sIGFjdGl2ZTsKPiA+ ICAKPiA+IC0JCQljb250aW51ZTsKPiA+ICsJCQlhY3RpdmUgPSBlbmNvZGVyLT5nZXRfaHdfc3Rh dGUoZW5jb2RlciwgJnBpcGUpOwo+ID4gKwkJCUk5MTVfU1RBVEVfV0FSTihhY3RpdmUsCj4gPiAr CQkJICAgICAiZW5jb2RlciBkZXRhY2hlZCBidXQgc3RpbGwgZW5hYmxlZCBvbiBwaXBlICVjLlxu IiwKPiA+ICsJCQkgICAgIHBpcGVfbmFtZShwaXBlKSk7Cj4gPiAgCQl9Cj4gPiAtCj4gPiAtCQlJ OTE1X1NUQVRFX1dBUk4oYWN0aXZlICE9IGVuY29kZXItPmJhc2UuY3J0Yy0+c3RhdGUtPmFjdGl2 ZSwKPiA+IC0JCSAgICAgImVuY29kZXIncyBodyBzdGF0ZSBkb2Vzbid0IG1hdGNoIHN3IHRyYWNr aW5nICIKPiA+IC0JCSAgICAgIihleHBlY3RlZCAlaSwgZm91bmQgJWkpXG4iLAo+ID4gLQkJICAg ICBlbmNvZGVyLT5iYXNlLmNydGMtPnN0YXRlLT5hY3RpdmUsIGFjdGl2ZSk7Cj4gPiAtCj4gPiAt Cj4gPiAtCQl0cmFja2VkX3BpcGUgPSB0b19pbnRlbF9jcnRjKGVuY29kZXItPmJhc2UuY3J0Yykt PnBpcGU7Cj4gPiAtCQlJOTE1X1NUQVRFX1dBUk4oYWN0aXZlICYmIHBpcGUgIT0gdHJhY2tlZF9w aXBlLAo+ID4gLQkJICAgICAiYWN0aXZlIGVuY29kZXIncyBwaXBlIGRvZXNuJ3QgbWF0Y2giCj4g PiAtCQkgICAgICIoZXhwZWN0ZWQgJWksIGZvdW5kICVpKVxuIiwKPiA+IC0JCSAgICAgdHJhY2tl ZF9waXBlLCBwaXBlKTsKPiA+IC0KPiA+ICAJfQo+ID4gIH0KPiA+ICAKPiA+ICBzdGF0aWMgdm9p ZAo+ID4gLWNoZWNrX2NydGNfc3RhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiA+ICtjaGVj a19jcnRjX3N0YXRlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fYXRvbWljX3N0 YXRlICpzdGF0ZSkKPiA+ICB7Cj4gPiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gPiAtCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+ID4g IAlzdHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcjsKPiA+IC0Jc3RydWN0IGludGVsX2NydGNf c3RhdGUgcGlwZV9jb25maWc7Cj4gPiArCXN0cnVjdCBkcm1fY3J0Y19zdGF0ZSAqY3J0Y19zdGF0 ZTsKPiA+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ID4gKwlpbnQgaTsKPiA+ICAKPiA+IC0J Zm9yX2VhY2hfaW50ZWxfY3J0YyhkZXYsIGNydGMpIHsKPiA+ICsJZm9yX2VhY2hfY3J0Y19pbl9z dGF0ZShzdGF0ZSwgY3J0YywgY3J0Y19zdGF0ZSwgaSkgewo+IAo+IFNvIG5vdyB3ZSBvbmx5IGNo ZWNrIHRoZSBzdGF0ZSBvZiBjcnRjcyBhZmZlY3RlZCBieSB0aGUgbW9kZXNldC4gSW4gdGhlCj4g dW5saWtlbHkgY2FzZSBvZiBhIGJ1ZyB0aGF0IGNoYW5nZXMgdGhlIGh3IHN0YXRlIG9mIGFub3Ro ZXIgY3J0YyB0aGF0Cj4gc2hvdWxkIGhhdmUgYmVlbiB1bmNoYW5nZWQsIHRoZSBvbGQgY29kZSBt aWdodCBjYXRjaCB0aGUgaXNzdWUgYnV0IHRoZQo+IG5ldyBvbmUgZG9lc24ndC4gSXNuJ3QgaXQg YmV0dGVyIHRvIGp1c3QgY2hlY2sgZXZlcnl0aGluZz8KCldlIGNhbid0IHNpbmNlIHRoYXQgb3Ro ZXIgY3J0YyBtaWdodCBiZSBkb2luZyBzb21lIG90aGVyIGFzeW5jIGNvbW1pdC4gQnV0CmV2ZW50 dWFsbHkgd2Ugc2hvdWxkIGJlIGRvaW5nIGEgbW9kZXNldCBvbiB0aGF0IG9uZSB0b28gYW5kIHNw b3QgdGhhdApzb21ldGhpbmcgd2VudCB3cm9uZy4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpT b2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK