From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Subject: Re: [PATCH v3 1/5] drm: Add config for detecting libdrm Date: Thu, 30 Jul 2015 10:04:49 -0400 Message-ID: <20150730140449.GP21252@vapier> References: <1435755168-16207-1-git-send-email-patrik.jakobsson@linux.intel.com> <1435755168-16207-2-git-send-email-patrik.jakobsson@linux.intel.com> <20150723094821.GC1209@vapier> <20150730133052.GA1003@patrik-desktop.isw.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1449039225==" Return-path: Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183]) by gabe.freedesktop.org (Postfix) with ESMTPS id C26736E1F2 for ; Thu, 30 Jul 2015 07:04:48 -0700 (PDT) In-Reply-To: <20150730133052.GA1003@patrik-desktop.isw.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: strace development list , ldv@altlinux.org, gabriel@lse.epita.fr, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org --===============1449039225== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="JlJsEFsx9RQyiX4C" Content-Disposition: inline --JlJsEFsx9RQyiX4C Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 30 Jul 2015 15:30, Patrik Jakobsson wrote: > On Thu, Jul 23, 2015 at 05:48:21AM -0400, Mike Frysinger wrote: > > On 01 Jul 2015 14:52, Patrik Jakobsson wrote: > > > Use pkg-config to try to find libdrm. If that fails use the standard > > > include directory for kernel drm headers in /usr/include/drm. > > >=20 > > > * configure.ac: Use pkg-config to find libdrm > > >=20 > > > Signed-off-by: Patrik Jakobsson > > > --- > > > configure.ac | 4 ++++ > > > 1 file changed, 4 insertions(+) > > >=20 > > > diff --git a/configure.ac b/configure.ac > > > index bb8bf46..aa63af7 100644 > > > --- a/configure.ac > > > +++ b/configure.ac > > > @@ -844,6 +844,10 @@ fi > > > AM_CONDITIONAL([USE_LIBUNWIND], [test "x$use_libunwind" =3D xyes]) > > > AC_MSG_RESULT([$use_libunwind]) > > > =20 > > > +PKG_CHECK_MODULES([libdrm], [libdrm], > > > + [CPPFLAGS=3D"$CPPFLAGS $libdrm_CFLAGS"], > > > + [CPPFLAGS=3D"$CPPFLAGS -I/usr/include/drm"]) > >=20 > > yikes, no, this is a really really bad idea. it should read: > > PKG_CHECK_MODULES([LIBDRM], [libdrm], > > [CPPFLAGS=3D"$CPPFLAGS $LIBDRM_CFLAGS"], [:]) >=20 > I take it you don't want me to fallback on kernel headers and skip > compiling with drm support if libdrm is not available? you cannot hardcode any path at all. if the kernel headers provide all of the defines/structs that you need, then just include them directly via #include . -mike --JlJsEFsx9RQyiX4C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJVui8BAAoJEEFjO5/oN/WBn+gQAJCNJ2WQ2IlW68+m0LSANXVx /TdGFXH56U2LeYPKc04ppTs1JgjWFYqFH9Mn69n/BBIzGhbfW9rIG6TWDxFIQ9uT gO24kpuV7oXvy/ne97pjwlj+iVaWE0PddKTDc3BNG0Oyrc71IQJH5jq9VJN9BJvA JQyoieWht41nRJqcX1S9BvJFLEEiZ73y+65TcOeWQrH9U8pDjB/21hBVtNlOLdZe hkeSrrbloly7jEvunWETpz267j9hnvAoePVri5nJtxr89J3c2iRCWdjsom8fOeMF 4M+x6e5YW4ernnFxKAOFZ+5l2oHbMPlcaFrE3gaJ20oCRLP7NdGeI7bgbX0eeuAH L6859Qhn7iLpZ42YVmbvrkCG1+L/sflRtTvxrdaDPKRKaQ2j5LywLjd+vXdLJTwY 6tnLMogluKa4l8uZkG8jS5JjeLtFqMxoP2CjwUeyJgQCy56/RB5dm9CTouOph/nx ITCLn//r7dwgcGBOqUXErSmVtscooV6PmnuhYnjNqGgySHqoqdRnFYLoY3rLoGvG 0Z2x36v+35eF0999FwoUyNiFay2qFrmXGkR/YkkqZqE325zech2eHJ7mQruE+9Tf o7G4aFBMLkcRXlPWWLVhxITl4x6TYJDXAIWi2l2MvtEO9O6vDMT6VgGQ/WkWVpWe DUc2kOIVWOWxDoSAoF/C =U6hv -----END PGP SIGNATURE----- --JlJsEFsx9RQyiX4C-- --===============1449039225== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============1449039225==--