From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 3/4] drm/dp-mst: Remove debug WARN_ON
Date: Tue, 4 Aug 2015 10:53:06 +0200
Message-ID: <20150804085304.GB3886@ulmo>
References: <1438615451-856-1-git-send-email-daniel.vetter@ffwll.ch>
 <1438615451-856-3-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1812131977=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <1438615451-856-3-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, stable@vger.kernel.org, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org


--===============1812131977==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="H1spWtNR+x+ondvy"
Content-Disposition: inline


--H1spWtNR+x+ondvy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Aug 03, 2015 at 05:24:10PM +0200, Daniel Vetter wrote:
> Apparently been in there since forever and fairly easy to hit when
> hotplugging really fast. I can do that since my mst hub has a manual
> button to flick the hpd line for reprobing. The resulting WARNING spam
> isn't pretty.
>=20
> Cc: Dave Airlie <airlied@gmail.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/drm_dp_mst_topology.c | 1 -
>  1 file changed, 1 deletion(-)
>=20
> diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_=
dp_mst_topology.c
> index 778bbb6425b8..b0487c9f018c 100644
> --- a/drivers/gpu/drm/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/drm_dp_mst_topology.c
> @@ -1294,7 +1294,6 @@ retry:
>  				goto retry;
>  			}
>  			DRM_DEBUG_KMS("failed to dpcd write %d %d\n", tosend, ret);
> -			WARN(1, "fail\n");
> =20
>  			return -EIO;
>  		}

Reviewed-by: Thierry Reding <treding@nvidia.com>

--H1spWtNR+x+ondvy
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJVwH1wAAoJEN0jrNd/PrOhZLcP/39Yj1F8urYWjDxF34PT+84c
yRXqsA377Y9sGEnSOWkY1YErYfVosMtXnRSC0HsV27QqeYGr0QeFc1w/Z1dPPT/J
+UtBYBsK4av3hSKkJnpLV7YxQALno3dE9GO9+FReLpCjI0+cnVQHXX8fGlI6aXMc
UBJe1SsxsiXjyIuOqAF9oQxZLRXFaMu2S9Usj22N1o4nChpCwm/qz+f5Nw6I/bql
rFY2aheDsNpWJdnHfAe7CBJqeI9/u7BdKXC2i8Hz/00OTe4uzlTgrqCbAT+dw65b
JV7j7DGKOO9yTxIB180Upk1SGg/WMjWURmTDr+Q/air7gu2UO2H5eIWmH9kdTSry
BS1NB055Auz/LEuQWDKPhyEG6wQ1ZgvfsoUgOPu8ME7HGtmGcVdpS+FEJGma7vnJ
B26otbSFiTzfaQ1ODASHwMimzEfqnUXnHoXGR94Dbee59sWO+KBS67msXrqtOdgd
71kcu9JwNVxSuYyYAH6fIE2uMcXSlO59rac/mtlGqPQKnCfbijDH6pXP+jMzUbCE
hRnwI/5ohSJUlIUFMNQxRG0z55xMUguFBw4onD3SVGFlGAyq0PxAJq4H7eKuVKjE
nbRKNkYLF3RAiCeh6kpDhP2DXuH9vE0jk4PVEshe8yb7Ait3hSvnfmUWL1G/D6yW
c906ThS+1fsFwLRQVUkZ
=VEwD
-----END PGP SIGNATURE-----

--H1spWtNR+x+ondvy--

--===============1812131977==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK

--===============1812131977==--