From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Weinehall Subject: Re: [PATCH 1/2 v2] drm/i915: Allow parsing of variable size child device entries from VBT Date: Tue, 4 Aug 2015 16:55:52 +0300 Message-ID: <20150804135552.GC6150@boom> References: <1436526655-2965-1-git-send-email-antti.koskipaa@linux.intel.com> <1436526655-2965-2-git-send-email-antti.koskipaa@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 963436E666 for ; Tue, 4 Aug 2015 06:55:54 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1436526655-2965-2-git-send-email-antti.koskipaa@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Antti Koskipaa Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org VkJUIHZlcnNpb24gMTk2IGluY3JlYXNlZCB0aGUgc2l6ZSBvZiBjb21tb25fY2hpbGRfZGV2X2Nv bmZpZy4gVGhlIHBhcnNlcgpjb2RlIGFzc3VtZWQgdGhhdCB0aGUgc2l6ZSBvZiB0aGlzIHN0cnVj dHVyZSB3b3VsZCBub3QgY2hhbmdlLgoKVGhlIG1vZGlmaWVkIGNvZGUgbm93IGNvcGllcyB0aGUg YW1vdW50IG5lZWRlZCBiYXNlZCBvbiB0aGUgVkJUIHZlcnNpb24sCmFuZCBlbWl0cyBhIGRlYnVn IG1lc3NhZ2UgaWYgdGhlIFZCVCB2ZXJzaW9uIGlzIHVua25vd24gKHRvbyBuZXcpOwpzaW5jZSB0 aGUgc3RydWN0IGNvbmZpZyBibG9jayB3b24ndCBzaHJpbmsgaW4gbmV3ZXIgdmVyc2lvbnMgaXQg c2hvdWxkCmJlIGhhcm1sZXNzIHRvIGNvcHkgdGhlIG1heGltdW0ga25vd24gc2l6ZSBpbiBzdWNo IGNhc2VzLCBzbyB0aGF0J3MKd2hhdCB3ZSBkbywgYnV0IGVtaXR0aW5nIHRoZSB3YXJuaW5nIGlz IHByb2JhYmx5IHNlbnNpYmxlIGFueXdheS4KCkluIHRoZSBsb25nZXIgcnVuIGl0IG1pZ2h0IG1h a2Ugc2Vuc2UgdG8gbW9kaWZ5IHRoZSBwYXJzZXIgY29kZSB0bwp1c2UgYSB2ZXJzaW9uL2ZlYXR1 cmUgbWFwcGluZywgcmF0aGVyIHRoYW4gaGFyZGNvZGluZyB0aGluZ3MgbGlrZSB0aGlzLApidXQg Zm9yIG5vdyB0aGUgdmFyaWFudHMgYXJlIGZhaXJseSBtYW5hZ2FibGUuCgp2MjogU3RyaWN0ZXIg c2l6ZSBjaGVja3MKClNpZ25lZC1vZmYtYnk6IERhdmlkIFdlaW5laGFsbCA8ZGF2aWQud2VpbmVo YWxsQGxpbnV4LmludGVsLmNvbT4KLS0tCiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9z LmMgfCAgIDI2ICsrKysrKysrKysrKysrKysrKysrKystLS0tCiAxIGZpbGUgY2hhbmdlZCwgMjIg aW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9iaW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMK aW5kZXggMmZmOWViMDBmZGVjLi44YTFmM2UxZmM1OTggMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Jpb3MuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9i aW9zLmMKQEAgLTEwMTUsMTUgKzEwMTUsMzMgQEAgcGFyc2VfZGV2aWNlX21hcHBpbmcoc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAogCWNvbnN0IHVuaW9uIGNoaWxkX2RldmljZV9j b25maWcgKnBfY2hpbGQ7CiAJdW5pb24gY2hpbGRfZGV2aWNlX2NvbmZpZyAqY2hpbGRfZGV2X3B0 cjsKIAlpbnQgaSwgY2hpbGRfZGV2aWNlX251bSwgY291bnQ7Ci0JdTE2CWJsb2NrX3NpemU7CisJ dTggZXhwZWN0ZWRfc2l6ZTsKKwl1MTYgYmxvY2tfc2l6ZTsKIAogCXBfZGVmcyA9IGZpbmRfc2Vj dGlvbihiZGIsIEJEQl9HRU5FUkFMX0RFRklOSVRJT05TKTsKIAlpZiAoIXBfZGVmcykgewogCQlE Uk1fREVCVUdfS01TKCJObyBnZW5lcmFsIGRlZmluaXRpb24gYmxvY2sgaXMgZm91bmQsIG5vIGRl dmljZXMgZGVmaW5lZC5cbiIpOwogCQlyZXR1cm47CiAJfQotCWlmIChwX2RlZnMtPmNoaWxkX2Rl dl9zaXplIDwgc2l6ZW9mKCpwX2NoaWxkKSkgewotCQlEUk1fRVJST1IoIkdlbmVyYWwgZGVmaW5p dG9uIGJsb2NrIGNoaWxkIGRldmljZSBzaXplIGlzIHRvbyBzbWFsbC5cbiIpOworCWlmIChiZGIt PnZlcnNpb24gPCAxOTUpIHsKKwkJZXhwZWN0ZWRfc2l6ZSA9IDMzOworCX0gZWxzZSBpZiAoYmRi LT52ZXJzaW9uID09IDE5NSkgeworCQlleHBlY3RlZF9zaXplID0gMzc7CisJfSBlbHNlIGlmIChi ZGItPnZlcnNpb24gPD0gMTk3KSB7CisJCWV4cGVjdGVkX3NpemUgPSAzODsKKwl9IGVsc2Ugewor CQlleHBlY3RlZF9zaXplID0gMzg7CisJCURSTV9ERUJVR19EUklWRVIoIkV4cGVjdGVkIGNoaWxk X2RldmljZV9jb25maWcgc2l6ZSBmb3IgQkRCIHZlcnNpb24gJXUgbm90IGtub3duOyBhc3N1bWlu ZyAldVxuIiwgZXhwZWN0ZWRfc2l6ZSk7CisJfQorCisJaWYgKGV4cGVjdGVkX3NpemUgPiBzaXpl b2YoKnBfY2hpbGQpKSB7CisJCURSTV9FUlJPUigiY2hpbGRfZGV2aWNlX2NvbmZpZyBjYW5ub3Qg Zml0IGluIHBfY2hpbGRcbiIpOworCQlyZXR1cm47CisJfQorCisJaWYgKHBfZGVmcy0+Y2hpbGRf ZGV2X3NpemUgIT0gZXhwZWN0ZWRfc2l6ZSkgeworCQlEUk1fRVJST1IoIlNpemUgbWlzbWF0Y2g7 IGNoaWxkX2RldmljZV9jb25maWcgc2l6ZT0ldSAoZXhwZWN0ZWQgJXUpOyBiZGItPnZlcnNpb246 ICV1XG4iLAorCQkJICBwX2RlZnMtPmNoaWxkX2Rldl9zaXplLCBleHBlY3RlZF9zaXplLCBiZGIt PnZlcnNpb24pOwogCQlyZXR1cm47CiAJfQogCS8qIGdldCB0aGUgYmxvY2sgc2l6ZSBvZiBnZW5l cmFsIGRlZmluaXRpb25zICovCkBAIC0xMDcwLDcgKzEwODgsNyBAQCBwYXJzZV9kZXZpY2VfbWFw cGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCiAKIAkJY2hpbGRfZGV2X3B0 ciA9IGRldl9wcml2LT52YnQuY2hpbGRfZGV2ICsgY291bnQ7CiAJCWNvdW50Kys7Ci0JCW1lbWNw eShjaGlsZF9kZXZfcHRyLCBwX2NoaWxkLCBzaXplb2YoKnBfY2hpbGQpKTsKKwkJbWVtY3B5KGNo aWxkX2Rldl9wdHIsIHBfY2hpbGQsIHBfZGVmcy0+Y2hpbGRfZGV2X3NpemUpOwogCX0KIAlyZXR1 cm47CiB9Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==