From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2 v2] drm/i915: Allow parsing of variable size child device entries from VBT Date: Wed, 5 Aug 2015 10:59:00 +0200 Message-ID: <20150805085900.GM17734@phenom.ffwll.local> References: <1436526655-2965-1-git-send-email-antti.koskipaa@linux.intel.com> <1436526655-2965-2-git-send-email-antti.koskipaa@linux.intel.com> <20150804135552.GC6150@boom> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTPS id 834336E310 for ; Wed, 5 Aug 2015 01:59:05 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so56782042wib.1 for ; Wed, 05 Aug 2015 01:59:03 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150804135552.GC6150@boom> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Antti Koskipaa , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMDQsIDIwMTUgYXQgMDQ6NTU6NTJQTSArMDMwMCwgRGF2aWQgV2VpbmVoYWxs IHdyb3RlOgo+IFZCVCB2ZXJzaW9uIDE5NiBpbmNyZWFzZWQgdGhlIHNpemUgb2YgY29tbW9uX2No aWxkX2Rldl9jb25maWcuIFRoZSBwYXJzZXIKPiBjb2RlIGFzc3VtZWQgdGhhdCB0aGUgc2l6ZSBv ZiB0aGlzIHN0cnVjdHVyZSB3b3VsZCBub3QgY2hhbmdlLgo+IAo+IFRoZSBtb2RpZmllZCBjb2Rl IG5vdyBjb3BpZXMgdGhlIGFtb3VudCBuZWVkZWQgYmFzZWQgb24gdGhlIFZCVCB2ZXJzaW9uLAo+ IGFuZCBlbWl0cyBhIGRlYnVnIG1lc3NhZ2UgaWYgdGhlIFZCVCB2ZXJzaW9uIGlzIHVua25vd24g KHRvbyBuZXcpOwo+IHNpbmNlIHRoZSBzdHJ1Y3QgY29uZmlnIGJsb2NrIHdvbid0IHNocmluayBp biBuZXdlciB2ZXJzaW9ucyBpdCBzaG91bGQKPiBiZSBoYXJtbGVzcyB0byBjb3B5IHRoZSBtYXhp bXVtIGtub3duIHNpemUgaW4gc3VjaCBjYXNlcywgc28gdGhhdCdzCj4gd2hhdCB3ZSBkbywgYnV0 IGVtaXR0aW5nIHRoZSB3YXJuaW5nIGlzIHByb2JhYmx5IHNlbnNpYmxlIGFueXdheS4KPiAKPiBJ biB0aGUgbG9uZ2VyIHJ1biBpdCBtaWdodCBtYWtlIHNlbnNlIHRvIG1vZGlmeSB0aGUgcGFyc2Vy IGNvZGUgdG8KPiB1c2UgYSB2ZXJzaW9uL2ZlYXR1cmUgbWFwcGluZywgcmF0aGVyIHRoYW4gaGFy ZGNvZGluZyB0aGluZ3MgbGlrZSB0aGlzLAo+IGJ1dCBmb3Igbm93IHRoZSB2YXJpYW50cyBhcmUg ZmFpcmx5IG1hbmFnYWJsZS4KPiAKPiB2MjogU3RyaWN0ZXIgc2l6ZSBjaGVja3MKPiAKPiBTaWdu ZWQtb2ZmLWJ5OiBEYXZpZCBXZWluZWhhbGwgPGRhdmlkLndlaW5laGFsbEBsaW51eC5pbnRlbC5j b20+CgpTaW5jZSBDaHJpcyBtZW50aW9uZWQgdGhhdCB0aGlzIHNob3VsZCBmaXggYSByZWdyZXNz aW9uIEkgYXBwbGllZCBpdCB0bwpkcm0taW50ZWwtZml4ZXMuCi1EYW5pZWwKCj4gLS0tCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyB8ICAgMjYgKysrKysrKysrKysrKysrKysr KysrKy0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25z KC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYyBi L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IGluZGV4IDJmZjllYjAwZmRlYy4u OGExZjNlMWZjNTk4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jp b3MuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYwo+IEBAIC0xMDE1 LDE1ICsxMDE1LDMzIEBAIHBhcnNlX2RldmljZV9tYXBwaW5nKHN0cnVjdCBkcm1faTkxNV9wcml2 YXRlICpkZXZfcHJpdiwKPiAgCWNvbnN0IHVuaW9uIGNoaWxkX2RldmljZV9jb25maWcgKnBfY2hp bGQ7Cj4gIAl1bmlvbiBjaGlsZF9kZXZpY2VfY29uZmlnICpjaGlsZF9kZXZfcHRyOwo+ICAJaW50 IGksIGNoaWxkX2RldmljZV9udW0sIGNvdW50Owo+IC0JdTE2CWJsb2NrX3NpemU7Cj4gKwl1OCBl eHBlY3RlZF9zaXplOwo+ICsJdTE2IGJsb2NrX3NpemU7Cj4gIAo+ICAJcF9kZWZzID0gZmluZF9z ZWN0aW9uKGJkYiwgQkRCX0dFTkVSQUxfREVGSU5JVElPTlMpOwo+ICAJaWYgKCFwX2RlZnMpIHsK PiAgCQlEUk1fREVCVUdfS01TKCJObyBnZW5lcmFsIGRlZmluaXRpb24gYmxvY2sgaXMgZm91bmQs IG5vIGRldmljZXMgZGVmaW5lZC5cbiIpOwo+ICAJCXJldHVybjsKPiAgCX0KPiAtCWlmIChwX2Rl ZnMtPmNoaWxkX2Rldl9zaXplIDwgc2l6ZW9mKCpwX2NoaWxkKSkgewo+IC0JCURSTV9FUlJPUigi R2VuZXJhbCBkZWZpbml0b24gYmxvY2sgY2hpbGQgZGV2aWNlIHNpemUgaXMgdG9vIHNtYWxsLlxu Iik7Cj4gKwlpZiAoYmRiLT52ZXJzaW9uIDwgMTk1KSB7Cj4gKwkJZXhwZWN0ZWRfc2l6ZSA9IDMz Owo+ICsJfSBlbHNlIGlmIChiZGItPnZlcnNpb24gPT0gMTk1KSB7Cj4gKwkJZXhwZWN0ZWRfc2l6 ZSA9IDM3Owo+ICsJfSBlbHNlIGlmIChiZGItPnZlcnNpb24gPD0gMTk3KSB7Cj4gKwkJZXhwZWN0 ZWRfc2l6ZSA9IDM4Owo+ICsJfSBlbHNlIHsKPiArCQlleHBlY3RlZF9zaXplID0gMzg7Cj4gKwkJ RFJNX0RFQlVHX0RSSVZFUigiRXhwZWN0ZWQgY2hpbGRfZGV2aWNlX2NvbmZpZyBzaXplIGZvciBC REIgdmVyc2lvbiAldSBub3Qga25vd247IGFzc3VtaW5nICV1XG4iLCBleHBlY3RlZF9zaXplKTsK PiArCX0KPiArCj4gKwlpZiAoZXhwZWN0ZWRfc2l6ZSA+IHNpemVvZigqcF9jaGlsZCkpIHsKPiAr CQlEUk1fRVJST1IoImNoaWxkX2RldmljZV9jb25maWcgY2Fubm90IGZpdCBpbiBwX2NoaWxkXG4i KTsKPiArCQlyZXR1cm47Cj4gKwl9Cj4gKwo+ICsJaWYgKHBfZGVmcy0+Y2hpbGRfZGV2X3NpemUg IT0gZXhwZWN0ZWRfc2l6ZSkgewo+ICsJCURSTV9FUlJPUigiU2l6ZSBtaXNtYXRjaDsgY2hpbGRf ZGV2aWNlX2NvbmZpZyBzaXplPSV1IChleHBlY3RlZCAldSk7IGJkYi0+dmVyc2lvbjogJXVcbiIs Cj4gKwkJCSAgcF9kZWZzLT5jaGlsZF9kZXZfc2l6ZSwgZXhwZWN0ZWRfc2l6ZSwgYmRiLT52ZXJz aW9uKTsKPiAgCQlyZXR1cm47Cj4gIAl9Cj4gIAkvKiBnZXQgdGhlIGJsb2NrIHNpemUgb2YgZ2Vu ZXJhbCBkZWZpbml0aW9ucyAqLwo+IEBAIC0xMDcwLDcgKzEwODgsNyBAQCBwYXJzZV9kZXZpY2Vf bWFwcGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4gIAo+ICAJCWNoaWxk X2Rldl9wdHIgPSBkZXZfcHJpdi0+dmJ0LmNoaWxkX2RldiArIGNvdW50Owo+ICAJCWNvdW50Kys7 Cj4gLQkJbWVtY3B5KGNoaWxkX2Rldl9wdHIsIHBfY2hpbGQsIHNpemVvZigqcF9jaGlsZCkpOwo+ ICsJCW1lbWNweShjaGlsZF9kZXZfcHRyLCBwX2NoaWxkLCBwX2RlZnMtPmNoaWxkX2Rldl9zaXpl KTsKPiAgCX0KPiAgCXJldHVybjsKPiAgfQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxt YW4vbGlzdGluZm8vaW50ZWwtZ2Z4CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVl ciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK