From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v3 01/13] drm/i915: Make the force_thru workaround atomic, v2. Date: Wed, 5 Aug 2015 16:03:32 +0200 Message-ID: <20150805140332.GX17734@phenom.ffwll.local> References: <1438771031-23227-1-git-send-email-maarten.lankhorst@linux.intel.com> <1438771031-23227-2-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTPS id F09B16E1B1 for ; Wed, 5 Aug 2015 07:03:36 -0700 (PDT) Received: by wicgj17 with SMTP id gj17so194043950wic.1 for ; Wed, 05 Aug 2015 07:03:35 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1438771031-23227-2-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMDUsIDIwMTUgYXQgMTI6MzY6NTlQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gU2V0IGNvbm5lY3RvcnNfY2hhbmdlZCB0byBmb3JjZSBhIG1vZGVzZXQgaWYg dGhlIHBhbmVsIGZpdHRlcidzIGZvcmNlCj4gZW5hYmxlZCBvbiBlRFAuCj4gCj4gQ2hhbmdlcyBz aW5jZSB2MToKPiAtIFVzZSBjb25uZWN0b3JzX2NoYW5nZWQgaW5zdGVhZCBvZiBhY3RpdmVfY2hh bmdlZCBiZWNhdXNlIGl0J3MgYQo+ICAgcm91dGluZyB1cGRhdGUuCj4gCj4gU2lnbmVkLW9mZi1i eTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4K ClF1ZXVlZCBmb3IgLW5leHQsIHRoYW5rcyBmb3IgdGhlIHBhdGNoLiBJIGNhbid0IG1lcmdlIG1v cmUgc2luY2UgSSBuZWVkIHRvCmJhY2ttZXJnZSB0b3BpYy9kcm0tbWlzYyBmaXJzdCBhbmQgdGhh dCBzdGlsbCBzdWZmZXJzIGZyb20gYXJtIGRyaXZlcgpicmVha2FnZS4KLURhbmllbAo+IC0tLQo+ ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyAgfCA4MiArKysrKysrKysrKy0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlz cGxheS5jIHwgIDMgKysKPiAgMiBmaWxlcyBjaGFuZ2VkLCAyNyBpbnNlcnRpb25zKCspLCA1OCBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9k ZWJ1Z2ZzLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYwo+IGluZGV4IDIz YTY5MzA3ZTEyZS4uZDFjNjQzYTgyMjY3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kZWJ1 Z2ZzLmMKPiBAQCAtMzY0NSw3NCArMzY0NSw0MCBAQCBzdGF0aWMgaW50IGlsa19waXBlX2NyY19j dGxfcmVnKGVudW0gaW50ZWxfcGlwZV9jcmNfc291cmNlICpzb3VyY2UsCj4gIAlyZXR1cm4gMDsK PiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgaHN3X3RyYW5zX2VkcF9waXBlX0FfY3JjX3dhKHN0cnVj dCBkcm1fZGV2aWNlICpkZXYpCj4gK3N0YXRpYyB2b2lkIGhzd190cmFuc19lZHBfcGlwZV9BX2Ny Y193YShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBib29sIGVuYWJsZSkKPiAgewo+ICAJc3RydWN0 IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAgCXN0cnVj dCBpbnRlbF9jcnRjICpjcnRjID0KPiAgCQl0b19pbnRlbF9jcnRjKGRldl9wcml2LT5waXBlX3Rv X2NydGNfbWFwcGluZ1tQSVBFX0FdKTsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBl X2NvbmZpZzsKPiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiArCWludCByZXQg PSAwOwo+ICAKPiAgCWRybV9tb2Rlc2V0X2xvY2tfYWxsKGRldik7Cj4gLQlwaXBlX2NvbmZpZyA9 IHRvX2ludGVsX2NydGNfc3RhdGUoY3J0Yy0+YmFzZS5zdGF0ZSk7Cj4gLQo+IC0JLyoKPiAtCSAq IElmIHdlIHVzZSB0aGUgZURQIHRyYW5zY29kZXIgd2UgbmVlZCB0byBtYWtlIHN1cmUgdGhhdCB3 ZSBkb24ndAo+IC0JICogYnlwYXNzIHRoZSBwZml0LCBzaW5jZSBvdGhlcndpc2UgdGhlIHBpcGUg Q1JDIHNvdXJjZSB3b24ndCB3b3JrLiBPbmx5Cj4gLQkgKiByZWxldmFudCBvbiBoc3cgd2l0aCBw aXBlIEEgd2hlbiB1c2luZyB0aGUgYWx3YXlzLW9uIHBvd2VyIHdlbGwKPiAtCSAqIHJvdXRpbmcu Cj4gLQkgKi8KPiAtCWlmIChwaXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29kZXIgPT0gVFJBTlNDT0RF Ul9FRFAgJiYKPiAtCSAgICAhcGlwZV9jb25maWctPnBjaF9wZml0LmVuYWJsZWQpIHsKPiAtCQli b29sIGFjdGl2ZSA9IHBpcGVfY29uZmlnLT5iYXNlLmFjdGl2ZTsKPiAtCj4gLQkJaWYgKGFjdGl2 ZSkgewo+IC0JCQlpbnRlbF9jcnRjX2NvbnRyb2woJmNydGMtPmJhc2UsIGZhbHNlKTsKPiAtCQkJ cGlwZV9jb25maWcgPSB0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPmJhc2Uuc3RhdGUpOwo+IC0J CX0KPiAtCj4gLQkJcGlwZV9jb25maWctPnBjaF9wZml0LmZvcmNlX3RocnUgPSB0cnVlOwo+IC0K PiAtCQlpbnRlbF9kaXNwbGF5X3Bvd2VyX2dldChkZXZfcHJpdiwKPiAtCQkJCQlQT1dFUl9ET01B SU5fUElQRV9QQU5FTF9GSVRURVIoUElQRV9BKSk7Cj4gLQo+IC0JCWlmIChhY3RpdmUpCj4gLQkJ CWludGVsX2NydGNfY29udHJvbCgmY3J0Yy0+YmFzZSwgdHJ1ZSk7Cj4gKwlzdGF0ZSA9IGRybV9h dG9taWNfc3RhdGVfYWxsb2MoZGV2KTsKPiArCWlmICghc3RhdGUpIHsKPiArCQlyZXQgPSAtRU5P TUVNOwo+ICsJCWdvdG8gb3V0Owo+ICAJfQo+IC0JZHJtX21vZGVzZXRfdW5sb2NrX2FsbChkZXYp Owo+IC19Cj4gIAo+IC1zdGF0aWMgdm9pZCBoc3dfdW5kb190cmFuc19lZHBfcGlwZV9BX2NyY193 YShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+IC17Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0 ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2YXRlOwo+IC0Jc3RydWN0IGludGVsX2NydGMgKmNy dGMgPQo+IC0JCXRvX2ludGVsX2NydGMoZGV2X3ByaXYtPnBpcGVfdG9fY3J0Y19tYXBwaW5nW1BJ UEVfQV0pOwo+IC0Jc3RydWN0IGludGVsX2NydGNfc3RhdGUgKnBpcGVfY29uZmlnOwo+IC0KPiAt CWRybV9tb2Rlc2V0X2xvY2tfYWxsKGRldik7Cj4gLQkvKgo+IC0JICogSWYgd2UgdXNlIHRoZSBl RFAgdHJhbnNjb2RlciB3ZSBuZWVkIHRvIG1ha2Ugc3VyZSB0aGF0IHdlIGRvbid0Cj4gLQkgKiBi eXBhc3MgdGhlIHBmaXQsIHNpbmNlIG90aGVyd2lzZSB0aGUgcGlwZSBDUkMgc291cmNlIHdvbid0 IHdvcmsuIE9ubHkKPiAtCSAqIHJlbGV2YW50IG9uIGhzdyB3aXRoIHBpcGUgQSB3aGVuIHVzaW5n IHRoZSBhbHdheXMtb24gcG93ZXIgd2VsbAo+IC0JICogcm91dGluZy4KPiAtCSAqLwo+IC0JcGlw ZV9jb25maWcgPSB0b19pbnRlbF9jcnRjX3N0YXRlKGNydGMtPmJhc2Uuc3RhdGUpOwo+IC0JaWYg KHBpcGVfY29uZmlnLT5wY2hfcGZpdC5mb3JjZV90aHJ1KSB7Cj4gLQkJYm9vbCBhY3RpdmUgPSBw aXBlX2NvbmZpZy0+YmFzZS5hY3RpdmU7Cj4gLQo+IC0JCWlmIChhY3RpdmUpIHsKPiAtCQkJaW50 ZWxfY3J0Y19jb250cm9sKCZjcnRjLT5iYXNlLCBmYWxzZSk7Cj4gLQkJCXBpcGVfY29uZmlnID0g dG9faW50ZWxfY3J0Y19zdGF0ZShjcnRjLT5iYXNlLnN0YXRlKTsKPiAtCQl9Cj4gLQo+IC0JCXBp cGVfY29uZmlnLT5wY2hfcGZpdC5mb3JjZV90aHJ1ID0gZmFsc2U7Cj4gKwlzdGF0ZS0+YWNxdWly ZV9jdHggPSBkcm1fbW9kZXNldF9sZWdhY3lfYWNxdWlyZV9jdHgoJmNydGMtPmJhc2UpOwo+ICsJ cGlwZV9jb25maWcgPSBpbnRlbF9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+ ICsJaWYgKElTX0VSUihwaXBlX2NvbmZpZykpIHsKPiArCQlyZXQgPSBQVFJfRVJSKHBpcGVfY29u ZmlnKTsKPiArCQlnb3RvIG91dDsKPiArCX0KPiAgCj4gLQkJaW50ZWxfZGlzcGxheV9wb3dlcl9w dXQoZGV2X3ByaXYsCj4gLQkJCQkJUE9XRVJfRE9NQUlOX1BJUEVfUEFORUxfRklUVEVSKFBJUEVf QSkpOwo+ICsJcGlwZV9jb25maWctPnBjaF9wZml0LmZvcmNlX3RocnUgPSBlbmFibGU7Cj4gKwlp ZiAocGlwZV9jb25maWctPmNwdV90cmFuc2NvZGVyID09IFRSQU5TQ09ERVJfRURQICYmCj4gKwkg ICAgcGlwZV9jb25maWctPnBjaF9wZml0LmVuYWJsZWQgIT0gZW5hYmxlKQo+ICsJCXBpcGVfY29u ZmlnLT5iYXNlLmNvbm5lY3RvcnNfY2hhbmdlZCA9IHRydWU7Cj4gIAo+IC0JCWlmIChhY3RpdmUp Cj4gLQkJCWludGVsX2NydGNfY29udHJvbCgmY3J0Yy0+YmFzZSwgdHJ1ZSk7Cj4gLQl9Cj4gKwly ZXQgPSBkcm1fYXRvbWljX2NvbW1pdChzdGF0ZSk7Cj4gK291dDoKPiAgCWRybV9tb2Rlc2V0X3Vu bG9ja19hbGwoZGV2KTsKPiArCVdBUk4ocmV0LCAiVG9nZ2xpbmcgd29ya2Fyb3VuZCB0byAlaSBy ZXR1cm5zICVpXG4iLCBlbmFibGUsIHJldCk7Cj4gKwlpZiAocmV0KQo+ICsJCWRybV9hdG9taWNf c3RhdGVfZnJlZShzdGF0ZSk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgaXZiX3BpcGVfY3JjX2N0 bF9yZWcoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiBAQCAtMzczMiw3ICszNjk4LDcgQEAgc3Rh dGljIGludCBpdmJfcGlwZV9jcmNfY3RsX3JlZyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJ CWJyZWFrOwo+ICAJY2FzZSBJTlRFTF9QSVBFX0NSQ19TT1VSQ0VfUEY6Cj4gIAkJaWYgKElTX0hB U1dFTEwoZGV2KSAmJiBwaXBlID09IFBJUEVfQSkKPiAtCQkJaHN3X3RyYW5zX2VkcF9waXBlX0Ff Y3JjX3dhKGRldik7Cj4gKwkJCWhzd190cmFuc19lZHBfcGlwZV9BX2NyY193YShkZXYsIHRydWUp Owo+ICAKPiAgCQkqdmFsID0gUElQRV9DUkNfRU5BQkxFIHwgUElQRV9DUkNfU09VUkNFX1BGX0lW QjsKPiAgCQlicmVhazsKPiBAQCAtMzg0NCw3ICszODEwLDcgQEAgc3RhdGljIGludCBwaXBlX2Ny Y19zZXRfc291cmNlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGVudW0gcGlwZSBwaXBlLAo+ICAJ CWVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2KSkKPiAgCQkJdmx2X3VuZG9fcGlwZV9zY3JhbWJs ZV9yZXNldChkZXYsIHBpcGUpOwo+ICAJCWVsc2UgaWYgKElTX0hBU1dFTEwoZGV2KSAmJiBwaXBl ID09IFBJUEVfQSkKPiAtCQkJaHN3X3VuZG9fdHJhbnNfZWRwX3BpcGVfQV9jcmNfd2EoZGV2KTsK PiArCQkJaHN3X3RyYW5zX2VkcF9waXBlX0FfY3JjX3dhKGRldiwgZmFsc2UpOwo+ICAKPiAgCQlo c3dfZW5hYmxlX2lwcyhjcnRjKTsKPiAgCX0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gaW5kZXggNDNiMGYxN2FkMWZhLi43NzQ3NTIwYmY5ZjYgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEyMTYwLDYgKzEyMTYwLDcgQEAgY2xlYXJfaW50 ZWxfY3J0Y19zdGF0ZShzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSkKPiAgCXN0 cnVjdCBpbnRlbF9kcGxsX2h3X3N0YXRlIGRwbGxfaHdfc3RhdGU7Cj4gIAllbnVtIGludGVsX2Rw bGxfaWQgc2hhcmVkX2RwbGw7Cj4gIAl1aW50MzJfdCBkZGlfcGxsX3NlbDsKPiArCWJvb2wgZm9y Y2VfdGhydTsKPiAgCj4gIAkvKiBGSVhNRTogYmVmb3JlIHRoZSBzd2l0Y2ggdG8gYXRvbWljIHN0 YXJ0ZWQsIGEgbmV3IHBpcGVfY29uZmlnIHdhcwo+ICAJICoga3phbGxvYydkLiBDb2RlIHRoYXQg ZGVwZW5kcyBvbiBhbnkgZmllbGQgYmVpbmcgemVybyBzaG91bGQgYmUKPiBAQCAtMTIxNzEsNiAr MTIxNzIsNyBAQCBjbGVhcl9pbnRlbF9jcnRjX3N0YXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlKQo+ICAJc2hhcmVkX2RwbGwgPSBjcnRjX3N0YXRlLT5zaGFyZWRfZHBsbDsK PiAgCWRwbGxfaHdfc3RhdGUgPSBjcnRjX3N0YXRlLT5kcGxsX2h3X3N0YXRlOwo+ICAJZGRpX3Bs bF9zZWwgPSBjcnRjX3N0YXRlLT5kZGlfcGxsX3NlbDsKPiArCWZvcmNlX3RocnUgPSBjcnRjX3N0 YXRlLT5wY2hfcGZpdC5mb3JjZV90aHJ1Owo+ICAKPiAgCW1lbXNldChjcnRjX3N0YXRlLCAwLCBz aXplb2YgKmNydGNfc3RhdGUpOwo+ICAKPiBAQCAtMTIxNzksNiArMTIxODEsNyBAQCBjbGVhcl9p bnRlbF9jcnRjX3N0YXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJ Y3J0Y19zdGF0ZS0+c2hhcmVkX2RwbGwgPSBzaGFyZWRfZHBsbDsKPiAgCWNydGNfc3RhdGUtPmRw bGxfaHdfc3RhdGUgPSBkcGxsX2h3X3N0YXRlOwo+ICAJY3J0Y19zdGF0ZS0+ZGRpX3BsbF9zZWwg PSBkZGlfcGxsX3NlbDsKPiArCWNydGNfc3RhdGUtPnBjaF9wZml0LmZvcmNlX3RocnUgPSBmb3Jj ZV90aHJ1Owo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50Cj4gLS0gCj4gMi4xLjAKPiAKPiBfX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWls aW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmllbCBW ZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZm d2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==