From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: Split sink_crc function in start, stop and read. Date: Thu, 6 Aug 2015 14:20:23 +0200 Message-ID: <20150806122023.GF17734@phenom.ffwll.local> References: <20150729082452.GR16722@phenom.ffwll.local> <1438298799-4024-1-git-send-email-rodrigo.vivi@intel.com> <20150805080713.GB17734@phenom.ffwll.local> <1438806656.9831.24.camel@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5828C6E4B6 for ; Thu, 6 Aug 2015 05:20:27 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so20145825wib.0 for ; Thu, 06 Aug 2015 05:20:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1438806656.9831.24.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" Cc: "daniel.vetter@ffwll.ch" , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMDUsIDIwMTUgYXQgMDg6MzA6MDFQTSArMDAwMCwgVml2aSwgUm9kcmlnbyB3 cm90ZToKPiBPbiBXZWQsIDIwMTUtMDgtMDUgYXQgMTA6MDcgKzAyMDAsIERhbmllbCBWZXR0ZXIg d3JvdGU6Cj4gPiBPbiBUaHUsIEp1bCAzMCwgMjAxNSBhdCAwNDoyNjozOVBNIC0wNzAwLCBSb2Ry aWdvIFZpdmkgd3JvdGU6Cj4gPiA+IFRoaXMgaXMganVzdCBhIHByZXBhcmF0aW9uIHBhdGNoIHRv IG1ha2UgY2xlYXIgd2hhdCBvcGVyYXRpb24gd2UKPiA+ID4gYXJlIHBlcmZvcm1pbmcuIFRoZXJl IGlzIG5vIGZ1bmN0aW9uYWwgY2hhbmdlIG9uIHRoZSBzaW5rIGNyYwo+ID4gPiBsb2dpYy4KPiA+ ID4gCj4gPiA+IGhzd19kaXNhYmxlX2lwcyBoYXMgYmVlbiBtb3ZlZCBhIGJpdCBmdXJ0aGVyIGlu IHRoZSBzdGFydCBmdW5jdGlvbgo+ID4gPiB0byBhdm9pZCBkaXNhYmxpbmcgaXBzIHdoZW4gc2lu ayBjcmMgaXMgbm90IGdvaW5nIHRvIGJlIHN0YXJ0ZWQuCj4gPiA+IGFuZCB0byBhdm9pZCBnb3Rv IG9uIHRoaXMgZnVuY3Rpb24uCj4gPiA+IAo+ID4gPiB2MjogZXhwbGFpbiB3aHkgaHN3X2Rpc2Fi bGVfaXBzKCkgY2FsbCBwbGFjZSBoYXMgY2hhbmdlZC4KPiA+ID4gCj4gPiA+IENjOiBEYW5pZWwg VmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ID4gPiBSZXZpZXdlZC1ieTogUmFmYWVs IEFudG9nbm9sbGkgPHJhZmFlbC5hbnRvZ25vbGxpQGludGVsLmNvbT4KPiA+ID4gU2lnbmVkLW9m Zi1ieTogUm9kcmlnbyBWaXZpIDxyb2RyaWdvLnZpdmlAaW50ZWwuY29tPgo+ID4gCj4gPiBUaGFu a3MgZm9yIHRoZSB1cGRhdGVkIGNvbW1pdCBtZXNzYWdlLiBRdWV1ZWQgZm9yIC1uZXh0LCB0aGFu a3MgZm9yIHRoZQo+ID4gcGF0Y2guCj4gCj4gVGhhbmtzIQo+IAo+IERvIHlvdSBpbnRlbmQgdG8g bWVyZ2UgdGhlIG90aGVyIDMgcmVtYWluaW5nIHBhdGNoZXM/Cj4gT3IgYW0gSSBtaXNzaW5nIHNv bWV0aGluZyB0aGVyZT8KCk5haCBqdXN0IG92ZXJzaWdodCwgbWVyZ2VkIDMgbW9yZSBwYXRjaGVz LiBEbyBJIGhhdmUgdGhlbSBhbGwgbm93PwotRGFuaWVsCgo+IAo+IFRoYW5rcywKPiBSb2RyaWdv Lgo+IAo+ID4gLURhbmllbAo+ID4gPiAtLS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMgfCA4OSArKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQo+ ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDUwIGluc2VydGlvbnMoKyksIDM5IGRlbGV0aW9ucygtKQo+ ID4gPiAKPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMg Yi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+IGluZGV4IDQ0ZjhhMzIuLjEw Y2JjOTggMTAwNjQ0Cj4gPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMK PiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ID4gPiBAQCAtMzk1 OCw0MCArMzk1OCw2NCBAQCBpbnRlbF9kcF9wcm9iZV9tc3Qoc3RydWN0IGludGVsX2RwICppbnRl bF9kcCkKPiA+ID4gIAlyZXR1cm4gaW50ZWxfZHAtPmlzX21zdDsKPiA+ID4gIH0KPiA+ID4gIAo+ ID4gPiAtaW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHU4 ICpjcmMpCj4gPiA+ICtzdGF0aWMgdm9pZCBpbnRlbF9kcF9zaW5rX2NyY19zdG9wKHN0cnVjdCBp bnRlbF9kcCAqaW50ZWxfZHApCj4gPiA+ICB7Cj4gPiA+IC0Jc3RydWN0IGludGVsX2RpZ2l0YWxf cG9ydCAqaW50ZWxfZGlnX3BvcnQgPSBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gPiA+IC0J c3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RpZ19wb3J0LT5iYXNlLmJhc2UuZGV2Owo+ ID4gPiAtCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0KPiA+ID4gLQkJdG9faW50ZWxf Y3J0YyhpbnRlbF9kaWdfcG9ydC0+YmFzZS5iYXNlLmNydGMpOwo+ID4gPiArCXN0cnVjdCBpbnRl bF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+ID4g PiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhkaWdfcG9y dC0+YmFzZS5iYXNlLmNydGMpOwo+ID4gPiAgCXU4IGJ1ZjsKPiA+ID4gLQlpbnQgdGVzdF9jcmNf Y291bnQ7Cj4gPiA+IC0JaW50IGF0dGVtcHRzID0gNjsKPiA+ID4gLQlpbnQgcmV0ID0gMDsKPiA+ ID4gLQo+ID4gPiAtCWhzd19kaXNhYmxlX2lwcyhpbnRlbF9jcnRjKTsKPiA+ID4gIAo+ID4gPiAt CWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LX01JU0Ms ICZidWYpIDwgMCkgewo+ID4gPiAtCQlyZXQgPSAtRUlPOwo+ID4gPiAtCQlnb3RvIG91dDsKPiA+ ID4gKwlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfU0lOSywg JmJ1ZikgPCAwKSB7Cj4gPiA+ICsJCURSTV9ERUJVR19LTVMoIlNpbmsgQ1JDIGNvdWxkbid0IGJl IHN0b3BwZWQgcHJvcGVybHlcbiIpOwo+ID4gPiArCQlyZXR1cm47Cj4gPiA+ICAJfQo+ID4gPiAg Cj4gPiA+IC0JaWYgKCEoYnVmICYgRFBfVEVTVF9DUkNfU1VQUE9SVEVEKSkgewo+ID4gPiAtCQly ZXQgPSAtRU5PVFRZOwo+ID4gPiAtCQlnb3RvIG91dDsKPiA+ID4gLQl9Cj4gPiA+ICsJaWYgKGRy bV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LLAo+ID4gPiArCQkJ ICAgICAgIGJ1ZiAmIH5EUF9URVNUX1NJTktfU1RBUlQpIDwgMCkKPiA+ID4gKwkJRFJNX0RFQlVH X0tNUygiU2luayBDUkMgY291bGRuJ3QgYmUgc3RvcHBlZCBwcm9wZXJseVxuIik7Cj4gPiA+ICAK PiA+ID4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1RFU1RfU0lO SywgJmJ1ZikgPCAwKSB7Cj4gPiA+IC0JCXJldCA9IC1FSU87Cj4gPiA+IC0JCWdvdG8gb3V0Owo+ ID4gPiAtCX0KPiA+ID4gKwloc3dfZW5hYmxlX2lwcyhpbnRlbF9jcnRjKTsKPiA+ID4gK30KPiA+ ID4gKwo+ID4gPiArc3RhdGljIGludCBpbnRlbF9kcF9zaW5rX2NyY19zdGFydChzdHJ1Y3QgaW50 ZWxfZHAgKmludGVsX2RwKQo+ID4gPiArewo+ID4gPiArCXN0cnVjdCBpbnRlbF9kaWdpdGFsX3Bv cnQgKmRpZ19wb3J0ID0gZHBfdG9fZGlnX3BvcnQoaW50ZWxfZHApOwo+ID4gPiArCXN0cnVjdCBp bnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0YyhkaWdfcG9ydC0+YmFzZS5iYXNl LmNydGMpOwo+ID4gPiArCXU4IGJ1ZjsKPiA+ID4gKwo+ID4gPiArCWlmIChkcm1fZHBfZHBjZF9y ZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LX01JU0MsICZidWYpIDwgMCkKPiA+ID4g KwkJcmV0dXJuIC1FSU87Cj4gPiA+ICsKPiA+ID4gKwlpZiAoIShidWYgJiBEUF9URVNUX0NSQ19T VVBQT1JURUQpKQo+ID4gPiArCQlyZXR1cm4gLUVOT1RUWTsKPiA+ID4gKwo+ID4gPiArCWlmIChk cm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LLCAmYnVmKSA8IDAp Cj4gPiA+ICsJCXJldHVybiAtRUlPOwo+ID4gPiArCj4gPiA+ICsJaHN3X2Rpc2FibGVfaXBzKGlu dGVsX2NydGMpOwo+ID4gPiAgCj4gPiA+ICAJaWYgKGRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxf ZHAtPmF1eCwgRFBfVEVTVF9TSU5LLAo+ID4gPiAtCQkJCWJ1ZiB8IERQX1RFU1RfU0lOS19TVEFS VCkgPCAwKSB7Cj4gPiA+IC0JCXJldCA9IC1FSU87Cj4gPiA+IC0JCWdvdG8gb3V0Owo+ID4gPiAr CQkJICAgICAgIGJ1ZiB8IERQX1RFU1RfU0lOS19TVEFSVCkgPCAwKSB7Cj4gPiA+ICsJCWhzd19l bmFibGVfaXBzKGludGVsX2NydGMpOwo+ID4gPiArCQlyZXR1cm4gLUVJTzsKPiA+ID4gIAl9Cj4g PiA+ICAKPiA+ID4gKwlyZXR1cm4gMDsKPiA+ID4gK30KPiA+ID4gKwo+ID4gPiAraW50IGludGVs X2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIHU4ICpjcmMpCj4gPiA+ICt7 Cj4gPiA+ICsJc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPSBkcF90b19kaWdf cG9ydChpbnRlbF9kcCk7Cj4gPiA+ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGRpZ19wb3J0 LT5iYXNlLmJhc2UuZGV2Owo+ID4gPiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0g dG9faW50ZWxfY3J0YyhkaWdfcG9ydC0+YmFzZS5iYXNlLmNydGMpOwo+ID4gPiArCXU4IGJ1ZjsK PiA+ID4gKwlpbnQgdGVzdF9jcmNfY291bnQ7Cj4gPiA+ICsJaW50IGF0dGVtcHRzID0gNjsKPiA+ ID4gKwlpbnQgcmV0Owo+ID4gPiArCj4gPiA+ICsJcmV0ID0gaW50ZWxfZHBfc2lua19jcmNfc3Rh cnQoaW50ZWxfZHApOwo+ID4gPiArCWlmIChyZXQpCj4gPiA+ICsJCXJldHVybiByZXQ7Cj4gPiA+ ICsKPiA+ID4gIAlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsIERQX1RFU1Rf U0lOS19NSVNDLCAmYnVmKSA8IDApIHsKPiA+ID4gIAkJcmV0ID0gLUVJTzsKPiA+ID4gIAkJZ290 byBzdG9wOwo+ID4gPiBAQCAtNDAxNCwyMyArNDAzOCwxMCBAQCBpbnQgaW50ZWxfZHBfc2lua19j cmMoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgdTggKmNyYykKPiA+ID4gIAkJZ290byBzdG9w Owo+ID4gPiAgCX0KPiA+ID4gIAo+ID4gPiAtCWlmIChkcm1fZHBfZHBjZF9yZWFkKCZpbnRlbF9k cC0+YXV4LCBEUF9URVNUX0NSQ19SX0NSLCBjcmMsIDYpIDwgMCkgewo+ID4gPiArCWlmIChkcm1f ZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LCBEUF9URVNUX0NSQ19SX0NSLCBjcmMsIDYpIDwg MCkKPiA+ID4gIAkJcmV0ID0gLUVJTzsKPiA+ID4gLQkJZ290byBzdG9wOwo+ID4gPiAtCX0KPiA+ ID4gLQo+ID4gPiAgc3RvcDoKPiA+ID4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2Rw LT5hdXgsIERQX1RFU1RfU0lOSywgJmJ1ZikgPCAwKSB7Cj4gPiA+IC0JCURSTV9ERUJVR19LTVMo IlNpbmsgQ1JDIGNvdWxkbid0IGJlIHN0b3BwZWQgcHJvcGVybHlcbiIpOwo+ID4gPiAtCQlnb3Rv IG91dDsKPiA+ID4gLQl9Cj4gPiA+IC0JaWYgKGRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAt PmF1eCwgRFBfVEVTVF9TSU5LLAo+ID4gPiAtCQkJICAgICAgIGJ1ZiAmIH5EUF9URVNUX1NJTktf U1RBUlQpIDwgMCkgewo+ID4gPiAtCQlEUk1fREVCVUdfS01TKCJTaW5rIENSQyBjb3VsZG4ndCBi ZSBzdG9wcGVkIHByb3Blcmx5XG4iKTsKPiA+ID4gLQkJZ290byBvdXQ7Cj4gPiA+IC0JfQo+ID4g PiAtb3V0Ogo+ID4gPiAtCWhzd19lbmFibGVfaXBzKGludGVsX2NydGMpOwo+ID4gPiArCWludGVs X2RwX3NpbmtfY3JjX3N0b3AoaW50ZWxfZHApOwo+ID4gPiAgCXJldHVybiByZXQ7Cj4gPiA+ICB9 Cj4gPiA+ICAKPiA+ID4gLS0gCj4gPiA+IDIuMS4wCj4gPiA+IAo+ID4gCj4gCgotLSAKRGFuaWVs IFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cu ZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK