From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 1/2 v2] drm/i915: Allow parsing of variable size child device entries from VBT Date: Thu, 6 Aug 2015 17:31:02 +0200 Message-ID: <20150806153102.GW17734@phenom.ffwll.local> References: <1436526655-2965-1-git-send-email-antti.koskipaa@linux.intel.com> <1436526655-2965-2-git-send-email-antti.koskipaa@linux.intel.com> <20150804135552.GC6150@boom> <20150805085900.GM17734@phenom.ffwll.local> <55C3682E.6080103@intel.com> <20150806140855.GE6150@boom> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTPS id A626A6E82B for ; Thu, 6 Aug 2015 08:31:07 -0700 (PDT) Received: by wicne3 with SMTP id ne3so27429727wic.1 for ; Thu, 06 Aug 2015 08:31:05 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150806140855.GE6150@boom> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michel Thierry , Daniel Vetter , Antti Koskipaa , "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBdWcgMDYsIDIwMTUgYXQgMDU6MDg6NTVQTSArMDMwMCwgRGF2aWQgV2VpbmVoYWxs IHdyb3RlOgo+IE9uIFRodSwgQXVnIDA2LCAyMDE1IGF0IDAyOjU5OjEwUE0gKzAxMDAsIE1pY2hl bCBUaGllcnJ5IHdyb3RlOgo+ID4gT24gOC81LzIwMTUgOTo1OSBBTSwgRGFuaWVsIFZldHRlciB3 cm90ZToKPiA+ID5PbiBUdWUsIEF1ZyAwNCwgMjAxNSBhdCAwNDo1NTo1MlBNICswMzAwLCBEYXZp ZCBXZWluZWhhbGwgd3JvdGU6Cj4gPiA+PlZCVCB2ZXJzaW9uIDE5NiBpbmNyZWFzZWQgdGhlIHNp emUgb2YgY29tbW9uX2NoaWxkX2Rldl9jb25maWcuIFRoZSBwYXJzZXIKPiA+ID4+Y29kZSBhc3N1 bWVkIHRoYXQgdGhlIHNpemUgb2YgdGhpcyBzdHJ1Y3R1cmUgd291bGQgbm90IGNoYW5nZS4KPiA+ ID4+Cj4gPiA+PlRoZSBtb2RpZmllZCBjb2RlIG5vdyBjb3BpZXMgdGhlIGFtb3VudCBuZWVkZWQg YmFzZWQgb24gdGhlIFZCVCB2ZXJzaW9uLAo+ID4gPj5hbmQgZW1pdHMgYSBkZWJ1ZyBtZXNzYWdl IGlmIHRoZSBWQlQgdmVyc2lvbiBpcyB1bmtub3duICh0b28gbmV3KTsKPiA+ID4+c2luY2UgdGhl IHN0cnVjdCBjb25maWcgYmxvY2sgd29uJ3Qgc2hyaW5rIGluIG5ld2VyIHZlcnNpb25zIGl0IHNo b3VsZAo+ID4gPj5iZSBoYXJtbGVzcyB0byBjb3B5IHRoZSBtYXhpbXVtIGtub3duIHNpemUgaW4g c3VjaCBjYXNlcywgc28gdGhhdCdzCj4gPiA+PndoYXQgd2UgZG8sIGJ1dCBlbWl0dGluZyB0aGUg d2FybmluZyBpcyBwcm9iYWJseSBzZW5zaWJsZSBhbnl3YXkuCj4gPiA+Pgo+ID4gPj5JbiB0aGUg bG9uZ2VyIHJ1biBpdCBtaWdodCBtYWtlIHNlbnNlIHRvIG1vZGlmeSB0aGUgcGFyc2VyIGNvZGUg dG8KPiA+ID4+dXNlIGEgdmVyc2lvbi9mZWF0dXJlIG1hcHBpbmcsIHJhdGhlciB0aGFuIGhhcmRj b2RpbmcgdGhpbmdzIGxpa2UgdGhpcywKPiA+ID4+YnV0IGZvciBub3cgdGhlIHZhcmlhbnRzIGFy ZSBmYWlybHkgbWFuYWdhYmxlLgo+ID4gPj4KPiA+ID4+djI6IFN0cmljdGVyIHNpemUgY2hlY2tz Cj4gPiA+Pgo+ID4gPj5TaWduZWQtb2ZmLWJ5OiBEYXZpZCBXZWluZWhhbGwgPGRhdmlkLndlaW5l aGFsbEBsaW51eC5pbnRlbC5jb20+Cj4gPiA+Cj4gPiA+U2luY2UgQ2hyaXMgbWVudGlvbmVkIHRo YXQgdGhpcyBzaG91bGQgZml4IGEgcmVncmVzc2lvbiBJIGFwcGxpZWQgaXQgdG8KPiA+ID5kcm0t aW50ZWwtZml4ZXMuCj4gPiA+LURhbmllbAo+ID4gPgo+ID4gPj4tLS0KPiA+ID4+ICBkcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgfCAgIDI2ICsrKysrKysrKysrKysrKysrKysrKyst LS0tCj4gPiA+PiAgMSBmaWxlIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25z KC0pCj4gPiA+Pgo+ID4gPj5kaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Ymlvcy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jCj4gPiA+PmluZGV4IDJm ZjllYjAwZmRlYy4uOGExZjNlMWZjNTk4IDEwMDY0NAo+ID4gPj4tLS0gYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9iaW9zLmMKPiA+ID4+KysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50 ZWxfYmlvcy5jCj4gPiA+PkBAIC0xMDE1LDE1ICsxMDE1LDMzIEBAIHBhcnNlX2RldmljZV9tYXBw aW5nKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiA+ID4+ICAgICAgIGNvbnN0 IHVuaW9uIGNoaWxkX2RldmljZV9jb25maWcgKnBfY2hpbGQ7Cj4gPiA+PiAgICAgICB1bmlvbiBj aGlsZF9kZXZpY2VfY29uZmlnICpjaGlsZF9kZXZfcHRyOwo+ID4gPj4gICAgICAgaW50IGksIGNo aWxkX2RldmljZV9udW0sIGNvdW50Owo+ID4gPj4tICAgICB1MTYgICAgIGJsb2NrX3NpemU7Cj4g PiA+PisgICAgIHU4IGV4cGVjdGVkX3NpemU7Cj4gPiA+PisgICAgIHUxNiBibG9ja19zaXplOwo+ ID4gPj4KPiA+ID4+ICAgICAgIHBfZGVmcyA9IGZpbmRfc2VjdGlvbihiZGIsIEJEQl9HRU5FUkFM X0RFRklOSVRJT05TKTsKPiA+ID4+ICAgICAgIGlmICghcF9kZWZzKSB7Cj4gPiA+PiAgICAgICAg ICAgICAgIERSTV9ERUJVR19LTVMoIk5vIGdlbmVyYWwgZGVmaW5pdGlvbiBibG9jayBpcyBmb3Vu ZCwgbm8gZGV2aWNlcyBkZWZpbmVkLlxuIik7Cj4gPiA+PiAgICAgICAgICAgICAgIHJldHVybjsK PiA+ID4+ICAgICAgIH0KPiA+ID4+LSAgICAgaWYgKHBfZGVmcy0+Y2hpbGRfZGV2X3NpemUgPCBz aXplb2YoKnBfY2hpbGQpKSB7Cj4gPiA+Pi0gICAgICAgICAgICAgRFJNX0VSUk9SKCJHZW5lcmFs IGRlZmluaXRvbiBibG9jayBjaGlsZCBkZXZpY2Ugc2l6ZSBpcyB0b28gc21hbGwuXG4iKTsKPiA+ ID4+KyAgICAgaWYgKGJkYi0+dmVyc2lvbiA8IDE5NSkgewo+ID4gPj4rICAgICAgICAgICAgIGV4 cGVjdGVkX3NpemUgPSAzMzsKPiA+ID4+KyAgICAgfSBlbHNlIGlmIChiZGItPnZlcnNpb24gPT0g MTk1KSB7Cj4gPiA+PisgICAgICAgICAgICAgZXhwZWN0ZWRfc2l6ZSA9IDM3Owo+ID4gPj4rICAg ICB9IGVsc2UgaWYgKGJkYi0+dmVyc2lvbiA8PSAxOTcpIHsKPiA+ID4+KyAgICAgICAgICAgICBl eHBlY3RlZF9zaXplID0gMzg7Cj4gPiA+PisgICAgIH0gZWxzZSB7Cj4gPiA+PisgICAgICAgICAg ICAgZXhwZWN0ZWRfc2l6ZSA9IDM4Owo+ID4gPj4rICAgICAgICAgICAgIERSTV9ERUJVR19EUklW RVIoIkV4cGVjdGVkIGNoaWxkX2RldmljZV9jb25maWcgc2l6ZSBmb3IgQkRCIHZlcnNpb24gJXUg bm90IGtub3duOyBhc3N1bWluZyAldVxuIiwgZXhwZWN0ZWRfc2l6ZSk7Cj4gPiAKPiA+IEhpLCB0 aGUgbGluZSBhYm92ZSB0aHJvd3MgYSB3YXJuaW5nIGJlY2F1c2UgdGhlcmUgYXJlIHR3byAnJXUn IGJ1dCBvbmx5IG9uZQo+ID4gdmFyaWFibGUuIExvb2tzIGxpa2UgYmRiLT52ZXJzaW9uIHNob3Vs ZCBiZSB0aGUgMXN0IHByaW50ZWQgdmFsdWUuCj4gCj4gR29vZCBjYXRjaCwgeW91ciBhbmFseXNp cyBpcyBpbmRlZWQgY29ycmVjdC4KPiAKPiBEYW5pZWwsIHdpbGwgeW91IGRvIHRoZSBmaXh1cCBv ciBzaG91bGQgSSBzdWJtaXQgYSBmaXhlZCB2ZXJzaW9uPwoKRml4ZWQgdXAgbG9jYWxseS4KLURh bmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRp b24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pbnRlbC1nZngK