From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH] drm/vblank: Use u32 consistently for vblank
	counters
Date: Fri, 7 Aug 2015 13:56:37 +0200
Message-ID: <20150807115636.GA24471@ulmo>
References: <1438943477-23537-1-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1551991099=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <1438943477-23537-1-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Michel =?utf-8?Q?D=C3=A4nzer?= <michel@daenzer.net>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org


--===============1551991099==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="huq684BweRXVnRxX"
Content-Disposition: inline


--huq684BweRXVnRxX
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 07, 2015 at 12:31:17PM +0200, Daniel Vetter wrote:
> In
>=20
> commit 99264a61dfcda41d86d0960cf2d4c0fc2758a773
> Author: Daniel Vetter <daniel.vetter@ffwll.ch>
> Date:   Wed Apr 15 19:34:43 2015 +0200
>=20
>     drm/vblank: Fixup and document timestamp update/read barriers
>=20
> I've switched vblank->count from atomic_t to unsigned long and
> accidentally created an integer comparison bug in
> drm_vblank_count_and_time since vblanke->count might overflow the u32
> local copy and hence the retry loop never succeed.
>=20
> Fix this by consistently using u32.
>=20
> Cc: Michel D=C3=A4nzer <michel@daenzer.net>
> Reported-by: Michel D=C3=A4nzer <michel@daenzer.net>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/drm_irq.c | 2 +-
>  include/drm/drmP.h        | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

--huq684BweRXVnRxX
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJVxJzxAAoJEN0jrNd/PrOhqoQP+gNZ63Rg4OB31nGvPPwIqynz
25bT0QuOa2QKtFm06YILabz31T6hUx0nyEkghquAOPlAUZyuWClx1NmM7WGcVhuL
tm4ofsuV+aYaSkIt6K/7B03DKcacV1a0It7sir8tZYjhK9OenAC0zfeLxeCtoHJ1
WBSD8N8KoAIllgTM5WvfwPjNgxgp9iiTZpQiqBt2cW1yWPVP64FXM4K6Xik0PtXX
f6kA+PLCnLwzDoE6fmO+7Uoki8fjAIyOKxBTcw3bkznFXTchEVh3+90WnDhLrnkt
5pREPOEp2YOhMneSXFF5DWrO9eJsN9AFq1Ubvc+Hh5+95RO8telX/gm2gph2taOb
Sm8lqq1onY0YAJruHRu4UNGDBcM44TXdEjKYQkU90gHDByN1ZexWaLCGO1fLKQQd
rFghU7DBTdx4OzqzrVOER7Q4HbURU9FYRtZNm/tiXmkheXzfGGCvJGqOQaGItU8e
IIZYstKiEjFJWcfsE/X5jxrXHQLdYCRGxZFcNdPNpYaeyyahhQ7U8PIh1HBMl9On
6dXxzwxb1edCZ7UShgsVDUyRihaE69ZVExAn1XpsXTMLAkG4IbGRcF/iGQWpOg2Y
rQ1LBq0qscx2pj3UPhi29uu/BgkrHG3lP0hvWKsSZreHzG7r9ZC1zNc22p74pgS8
NEAgT++aYOYW/C4OHpA7
=SLb8
-----END PGP SIGNATURE-----

--huq684BweRXVnRxX--

--===============1551991099==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK

--===============1551991099==--