Re: [PATCH] drm/i915: Retry port as HDMI if dp_is_edp turns out to be false

Chris Wilson
2015-08-12T14:14:57Z

On Wed, Aug 12, 2015 at 04:45:39PM +0300, Ville Syrjälä wrote:
> > - /*
> > - * For eDP we always set the encoder type to INTEL_OUTPUT_EDP, but
> > - * for DP the encoder type can be set by the caller to
> > - * INTEL_OUTPUT_UNKNOWN for DDI, so don't rewrite it.
> > - */
> > - if (type == DRM_MODE_CONNECTOR_eDP)
> > - intel_encoder->type = INTEL_OUTPUT_EDP;
>
> aux (and IIRC pps setup on vlv/chv) needs is_edp() to work. So I think
> this would break stuff.

Hmm, I was hoping that all the additional setup we do in init for edp
would be enough for it to use any and all sidebands as necessary.

The fallout will be that we simply cannot reuse the false eDP link as a
plain DP and just establish one HDMI connector for the port. Or maybe it
is still recoverable?
-Chris

--
Chris Wilson, Intel Open Source Technology Centre