From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thierry Reding <thierry.reding@gmail.com>
Subject: Re: [PATCH 16/18] drm/radeon: Don't take
 dev->struct_mutex in pm functions
Date: Mon, 10 Aug 2015 13:00:27 +0200
Message-ID: <20150810110026.GQ1262@ulmo.nvidia.com>
References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch>
 <1436477570-4936-17-git-send-email-daniel.vetter@ffwll.ch>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1047765712=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <1436477570-4936-17-git-send-email-daniel.vetter@ffwll.ch>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Alex Deucher <alexander.deucher@amd.com>, Daniel Vetter <daniel.vetter@intel.com>, Intel Graphics Development <intel-gfx@lists.freedesktop.org>, Christian =?utf-8?B?S8O2bmln?= <christian.koenig@amd.com>, DRI Development <dri-devel@lists.freedesktop.org>
List-Id: intel-gfx@lists.freedesktop.org


--===============1047765712==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="ZqRzwd/9tauJXEMK"
Content-Disposition: inline


--ZqRzwd/9tauJXEMK
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Jul 09, 2015 at 11:32:48PM +0200, Daniel Vetter wrote:
> We already grab 2 device-global locks (write-sema rdev->pm.mclk_lock
> and rdev->ring_lock), adding another global mutex won't serialize this
> code more. And since there's really nothing interesting that gets
> protected in radeon by dev->struct mutex (we only have the global z
> buffer owners and it's still serializing gem bo destruction in the drm
> core - which is irrelevant since radeon uses ttm anyway internally)
> this doesn't add protection. Remove it.
>=20
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/radeon/radeon_pm.c | 5 -----
>  1 file changed, 5 deletions(-)

Reviewed-by: Thierry Reding <treding@nvidia.com>

--ZqRzwd/9tauJXEMK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJVyIRJAAoJEN0jrNd/PrOhXkIP/3AmQY15heMOE8fKwSXd/Hvy
bjPJpBbXQsMr5cPw4HxV/qqGLpqDLFiYZE664P5Ga2j3dW34YAn9nm7efaHh9EYQ
TtZbxHIaFcpTdALQ69V6xxvqr7siuPzE9gu2SE2FCxdwD7D7SJuRQjRg00DMxUTf
VKpBZV0JOD7BkzuamWOEkwrSxwMKsAn0PphzCFEWqyFZWeLxtIs4YpZMWuoqq6VU
raN+EKejtGz+zicUSMAjuHt8xr3PHfZvBoZJTfhKpINxxCWuIzk9wY801AmQCnFL
uyDQZtWicagcGfZ5o+onxDFbKxUQGj1TsRpxNog+epQRWNzIxwsIqMMEpCE9eOeQ
/nDCf+x0dBKLmeuU3iNgOLXTCH3xJx5PYrYA0QMU4guJVIy4sUUyQ6NWguyUlLC6
8kUyfHhGXFVyTRZgLnXYh60WpdVx5ZlpalxH5IjUHY6rC3vLiUBICkYaKpRCOEFZ
geL9FejIvvWJh9JuzOG3/ZuezQdduD9KmPDm3EjaJGrB+33BkNfzv3tMtnRigroL
sZgJue4UomLXr25JjokrRHjINfc42q3SoK/wisAt4n3E0F8SoZbHolBod3R2UkTR
oHGSXd+C2cRzw36JM7zWXL0qvnEED1tcy+XYCnTEYUERt0kYf7hNM3eLBu+uCvsM
hQGO3b/vO0RuFJ6/GiI6
=hNuG
-----END PGP SIGNATURE-----

--ZqRzwd/9tauJXEMK--

--===============1047765712==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK

--===============1047765712==--