From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH 1/2] drm/tegra: don't take dev->struct_mutex in mmap offset ioctl Date: Mon, 10 Aug 2015 13:38:03 +0200 Message-ID: <20150810113802.GU1262@ulmo.nvidia.com> References: <1436477570-4936-1-git-send-email-daniel.vetter@ffwll.ch> <1436967532-13251-1-git-send-email-daniel.vetter@ffwll.ch> <20150810103019.GA1262@ulmo.nvidia.com> <20150810113142.GS17734@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2080334957==" Return-path: In-Reply-To: <20150810113142.GS17734@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org --===============2080334957== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="H5pgEA8DvTwLpheO" Content-Disposition: inline --H5pgEA8DvTwLpheO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2015 at 01:31:42PM +0200, Daniel Vetter wrote: > On Mon, Aug 10, 2015 at 12:30:21PM +0200, Thierry Reding wrote: > > On Wed, Jul 15, 2015 at 03:38:51PM +0200, Daniel Vetter wrote: > > > Since David Herrmann's mmap vma manager rework we don't need to grab > > > dev->struct_mutex any more to prevent races when looking up the mmap > > > offset. Drop it and instead don't forget to use the unref_unlocked > > > variant (since the drm core still cares). > > >=20 > > > While at it also fix a leak when this ioctl is called on an imported > > > buffer. > >=20 > > I don't see where the leak's fixed, but other than that this looks good > > to me. Shall I pick this up into the drm/tegra tree? >=20 > Copypaste in the commit message from armada, doesn't apply to tegra. Do > you also plan to pick up "drm/tegra: Use > drm_gem_object_reference_unlocked" directly? I don't mind much either way. I don't think they'll conflict with anything, but since you already said that they're all independent, I don't see a reason why I shouldn't pull them into drm/tegra. If you prefer to keep them together, that's fine with me too. Thanks, Thierry --H5pgEA8DvTwLpheO Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyI0aAAoJEN0jrNd/PrOhr4AP/iqwsuldHn3dy/xtoWe9gWKs WRG1dNmaukpfWb/SmQhiah2H+otlFwMlfIMLHGXpIlYaCnqcVuWeEvKbd9UEFgrY +J1+gWqdFVhkHoYerbaDC362/0TU06KqiV29h74sZEk+id6GUQ+gT+YbIwy7SeV+ l751A1X7h2F4XVF4l6vHjKM/zids31hwBfg5DMvdxabB3xcNXZ0Ak9lMJufTZWK5 Fo2EHZT8jyNCID3+/8D0BUJkz4EGuI2YPaxIA3KpR5+loagtKHGODEwrDUanOATT TUKQhjBMg61tmSDXyk3E5ZW/mSRUSChdJxpBQqjvlyMNuP0meckPcw+iYHnLITYx ZR4u+tehO/TFa5s3ajJYkDRNFmILFaygzxrVcOim6CKkGVPk1+CxVqW/U34VbRnf X4PXZkBraN+Xr0I2GNBLKQET7V0GklxHh0NuOkNBQZJ9DGgCMg0HIwECkZDZ5oI4 Z3qitZ5XOVtzwHsLAd65/il9Zw1hoGJgdUJ2L493n/v2xSKO8mvyXELe4eIJXTyQ J54MNe0hAO7pRhgEkvfewnl/ZxUUAtHYVjvt5fwmW8+OxRtdEes0bGecajCQbK32 R1z+4aOWQjAV1auQNyMlLrj5pA/8gUWYwuZlXUl/TB9usRlCZpS9wfwIDt+gQcWk WAcskm+Ep6KMyV7RsQf2 =UFLV -----END PGP SIGNATURE----- --H5pgEA8DvTwLpheO-- --===============2080334957== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============2080334957==--