From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [PATCH] drm/i915: Use CONFIG_DRM_FBDEV_EMULATION Date: Mon, 10 Aug 2015 13:48:53 +0200 Message-ID: <20150810114852.GV1262@ulmo.nvidia.com> References: <1439206448-8938-1-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0380965103==" Return-path: In-Reply-To: <1439206448-8938-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter Cc: Daniel Vetter , Intel Graphics Development , DRI Development List-Id: intel-gfx@lists.freedesktop.org --===============0380965103== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="U8v/hV883cEE9JJG" Content-Disposition: inline --U8v/hV883cEE9JJG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Aug 10, 2015 at 01:34:08PM +0200, Daniel Vetter wrote: > Instead of our own duplicated one. This fixes a bug in the driver > unload code if DRM_FBDEV_EMULATION=3Dn but DRM_I915_FBDEV=3Dy because we > try to unregister the nonexistent fbdev drm_framebuffer. >=20 > Cc: Archit Taneja > Cc: Maarten Lankhorst > Reported-by: Maarten Lankhorst > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/i915/Kconfig | 15 --------------- > drivers/gpu/drm/i915/Makefile | 2 +- > drivers/gpu/drm/i915/i915_debugfs.c | 2 +- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > drivers/gpu/drm/i915/intel_display.c | 4 ++-- > drivers/gpu/drm/i915/intel_dp_mst.c | 4 ++-- > drivers/gpu/drm/i915/intel_drv.h | 2 +- > 7 files changed, 8 insertions(+), 23 deletions(-) Isn't this going to cause some pain to users because .config may not have this symbol yet? Arguably this is somewhat mitigated by the fact that both symbols are "default y", but technically somebody could have DRM_I915_FBDEV=3Dn in their .config and after this change fbdev emulation will be switched on again. I'm not sure how to upgrade more sanely, though, so perhaps this is just a bullet that needs biting. Thierry --U8v/hV883cEE9JJG Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJVyI+hAAoJEN0jrNd/PrOhLH0P/0mfWB+zRN77uOZ+Ow8P2BxF zkhPlq1ggdaWH5Q4G6gHLXE/bmU+CHsoZ2CNwXaFBr38mqlwwb9Sq+N5Nv819T2l juyLPCZzJvPATIfzyti9RkgkDEw6wHRgRDJRA2e3o2g8vQ+e7yU/CIoe2El/7cnV BIlRDi9Jhk6pqFAh9Zi2e1iDeCFd7Pyfb1pKuEdVgWFTFpBwt48MjkSACankbtJ+ GMUwop9z80g9RZyar+7skqAu/YxxI8P8lODbh/HIoN2Lisk369yETIT/nufX6JVb jylB2S/31X1uZBZQcIyVvSYDFdlPNUOyxUeg1IVk2QfdJKO1fhXNz3/sicPQp/Kd FrPQfthDZnx1Qctw82nwCJNbe1Woe0Tjd/vkLy8CYKog7oYKxrf81MSy1MXQxvRd 5MkPOoBgqxEWvYqGfJYTQg6OlXZB09y138wnjHrPxXkiezMmr93O2aFfn24X5yKx vEN3aaO6fX2HAFGpTJ0h1ZlIgjxAdoYI4CabCzAkrhjS7MuGrQGBlHJyolCYnwPZ HwIw9KA8rIe1HpDaif2ioeh7eaHkDBoCc+HLjV4o8Y+q2WlffwpDoFBh9ZqgkUwl rz9pC6sA3i3Bqw5fygi6bg7SDVkZ/oUJULnTN7pyHe4ni3saGqM41uh6giAYJri3 UxCRsmE8/kyuYJeDIiHe =N18Z -----END PGP SIGNATURE----- --U8v/hV883cEE9JJG-- --===============0380965103== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK --===============0380965103==--