From: Daniel Vetter <daniel@ffwll.ch>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH 1/2] drm/edid: Use ARRAY_SIZE in drm_add_modes_noedid
Date: Mon, 10 Aug 2015 14:08:27 +0200 [thread overview]
Message-ID: <20150810120827.GY17734@phenom.ffwll.local> (raw)
In-Reply-To: <20150810115720.GX1262@ulmo.nvidia.com>
On Mon, Aug 10, 2015 at 01:57:21PM +0200, Thierry Reding wrote:
> On Mon, Aug 10, 2015 at 11:55:37AM +0200, Daniel Vetter wrote:
> > Spotted while reading code for random reasons.
> >
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> > drivers/gpu/drm/drm_edid.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> > index 4a403eb90ded..4780b1924bef 100644
> > --- a/drivers/gpu/drm/drm_edid.c
> > +++ b/drivers/gpu/drm/drm_edid.c
> > @@ -3810,7 +3810,7 @@ int drm_add_modes_noedid(struct drm_connector *connector,
> > struct drm_display_mode *mode;
> > struct drm_device *dev = connector->dev;
> >
> > - count = sizeof(drm_dmt_modes) / sizeof(struct drm_display_mode);
> > + count = ARRAY_SIZE(drm_dmt_modes);
> > if (hdisplay < 0)
> > hdisplay = 0;
> > if (vdisplay < 0)
>
>
> Reviewed-by: Thierry Reding <treding@nvidia.com>
Thanks for the review, applied to drm-misc.
-Danie
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-08-10 12:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 9:55 [PATCH 1/2] drm/edid: Use ARRAY_SIZE in drm_add_modes_noedid Daniel Vetter
2015-08-10 9:55 ` [PATCH 2/2] drm/doc: Update docs about device instance setup Daniel Vetter
2015-08-10 11:59 ` Thierry Reding
2015-08-10 12:07 ` Daniel Vetter
2015-08-10 12:34 ` Thierry Reding
2015-08-10 14:30 ` Daniel Vetter
2015-09-28 19:23 ` David Herrmann
2015-08-13 16:50 ` shuang.he
2015-09-28 15:31 ` Laurent Pinchart
2015-09-28 19:46 ` [PATCH] " Daniel Vetter
2015-09-29 13:28 ` Laurent Pinchart
2015-09-29 14:12 ` Daniel Vetter
2015-08-10 11:57 ` [PATCH 1/2] drm/edid: Use ARRAY_SIZE in drm_add_modes_noedid Thierry Reding
2015-08-10 12:08 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810120827.GY17734@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox