From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: clflush on pin_to_display after pwrite to UC bo in LLC Date: Tue, 11 Aug 2015 17:56:28 +0300 Message-ID: <20150811145628.GS5176@intel.com> References: <1439301554-6457-1-git-send-email-ville.syrjala@linux.intel.com> <20150811142827.GD3701@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id C373A6E1D9 for ; Tue, 11 Aug 2015 07:56:44 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150811142827.GD3701@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMTEsIDIwMTUgYXQgMDM6Mjg6MjdQTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdy b3RlOgo+IE9uIFR1ZSwgQXVnIDExLCAyMDE1IGF0IDA0OjU5OjE0UE0gKzAzMDAsIHZpbGxlLnN5 cmphbGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ID4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+IAo+ID4gQ3VycmVudGx5IHdlIGRvbid0 IGNsZmx1c2ggb24gcGluX3RvX2Rpc3BsYXkgaWYgdGhlIGJvIGlzIGFscmVhZHkKPiA+IFVDL1dU IGFuZCBpcyBub3QgaW4gdGhlIENQVSB3cml0ZSBkb21haW4uIFRoaXMgY2F1c2VzIHByb2JsZW1z IHdpdGgKPiA+IHB3cml0ZSBzaW5jZSBwd3JpdGUgZG9lc24ndCBjaGFuZ2UgdGhlIHdyaXRlIGRv bWFpbiwgYW5kIGl0IGF2b2lkcwo+ID4gY2xmbHVzaGluZyBvbiBVQy9XVCBidWZmZXJzIG9uIExM QyBwbGF0Zm9ybXMgdW5sZXNzIHRoZSBidWZmZXIgaXMKPiA+IGN1cnJlbnRseSBiZWluZyBzY2Fu bmVkIG91dC4KPiA+IAo+ID4gRml4IHRoZSBwcm9ibGVtIGJ5IG1hcmtpbmcgdGhlIGNhY2hlIGRp cnR5IGFuZCBhZGp1c3RpbmcKPiA+IGk5MTVfZ2VtX29iamVjdF9zZXRfY2FjaGVfbGV2ZWwoKSB0 byBjbGZsdXNoIHdoZW4gdGhlIGNhY2hlIGlzIGRpcnR5Cj4gPiBldmVuIGlmIHRoZSBjYWNoZV9s ZXZlbCBkb2Vzbid0IGNoYW5nZS4KPiA+IAo+ID4gTXkgbGFzdCBhdHRlbXB0IFsxXSBhdCBmaXhp bmcgdGhpcyB2aWEgd3JpdGUgZG9tYWluIGZyb2JiaW5nIHdhcyBzaG90Cj4gPiBkb3duLCBidXQg bm93IHdpdGggdGhlIGNhY2hlX2RpcnR5IGZsYWcgd2UgY2FuIGRvIHRoaW5ncyBpbiBhIG5pY2Vy IHdheS4KPiA+IAo+ID4gWzFdIGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMv aW50ZWwtZ2Z4LzIwMTQtTm92ZW1iZXIvMDU1MzkwLmh0bWwKPiA+IAo+ID4gQnVnemlsbGE6IGh0 dHBzOi8vYnVncy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NDIyCj4gPiBUZXN0 Y2FzZTogaWd0L2ttc19wd3JpdGVfY3JjCj4gPiBTaWduZWQtb2ZmLWJ5OiBWaWxsZSBTeXJqw6Rs w6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9nZW0uYyB8IDEwICsrKysrKystLS0KPiA+ICAxIGZpbGUgY2hhbmdl ZCwgNyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5 MTVfZ2VtLmMKPiA+IGluZGV4IDczMjkzYjQuLjczZWZmMmUgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pOTE1X2dlbS5jCj4gPiBAQCAtMTAwNSwxMiArMTAwNSwxNSBAQCBvdXQ6Cj4gPiAgCQlpZiAo IW5lZWRzX2NsZmx1c2hfYWZ0ZXIgJiYKPiA+ICAJCSAgICBvYmotPmJhc2Uud3JpdGVfZG9tYWlu ICE9IEk5MTVfR0VNX0RPTUFJTl9DUFUpIHsKPiA+ICAJCQlpZiAoaTkxNV9nZW1fY2xmbHVzaF9v YmplY3Qob2JqLCBvYmotPnBpbl9kaXNwbGF5KSkKPiA+IC0JCQkJaTkxNV9nZW1fY2hpcHNldF9m bHVzaChkZXYpOwo+ID4gKwkJCQluZWVkc19jbGZsdXNoX2FmdGVyID0gdHJ1ZTsKPiA+ICAJCX0K PiA+ICAJfQo+ID4gIAo+ID4gIAlpZiAobmVlZHNfY2xmbHVzaF9hZnRlcikKPiA+ICAJCWk5MTVf Z2VtX2NoaXBzZXRfZmx1c2goZGV2KTsKPiA+ICsJZWxzZSBpZiAob2JqLT5jYWNoZV9sZXZlbCA9 PSBJOTE1X0NBQ0hFX05PTkUgfHwKPiA+ICsJCSBvYmotPmNhY2hlX2xldmVsID09IEk5MTVfQ0FD SEVfV1QpCj4gPiArCQlvYmotPmNhY2hlX2RpcnR5ID0gdHJ1ZTsKPiA+ICAKPiA+ICAJaW50ZWxf ZmJfb2JqX2ZsdXNoKG9iaiwgZmFsc2UsIE9SSUdJTl9DUFUpOwo+ID4gIAlyZXR1cm4gcmV0Owo+ IAo+IE9rLCB0aGlzIHNlZW1zIHJlYXNvbmFibGUuCj4gCj4gPiBAQCAtMzYzOSwxMCArMzY0Miwx MCBAQCBpbnQgaTkxNV9nZW1fb2JqZWN0X3NldF9jYWNoZV9sZXZlbChzdHJ1Y3QgZHJtX2k5MTVf Z2VtX29iamVjdCAqb2JqLAo+ID4gIHsKPiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IG9i ai0+YmFzZS5kZXY7Cj4gPiAgCXN0cnVjdCBpOTE1X3ZtYSAqdm1hLCAqbmV4dDsKPiA+IC0JaW50 IHJldDsKPiA+ICsJaW50IHJldCA9IDA7Cj4gPiAgCj4gPiAgCWlmIChvYmotPmNhY2hlX2xldmVs ID09IGNhY2hlX2xldmVsKQo+ID4gLQkJcmV0dXJuIDA7Cj4gPiArCQlnb3RvIG91dDsKPiA+ICAK PiA+ICAJaWYgKGk5MTVfZ2VtX29ial9pc19waW5uZWQob2JqKSkgewo+ID4gIAkJRFJNX0RFQlVH KCJjYW4gbm90IGNoYW5nZSB0aGUgY2FjaGUgbGV2ZWwgb2YgcGlubmVkIG9iamVjdHNcbiIpOwo+ ID4gQEAgLTM2ODcsNiArMzY5MCw3IEBAIGludCBpOTE1X2dlbV9vYmplY3Rfc2V0X2NhY2hlX2xl dmVsKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gPiAgCQl2bWEtPm5vZGUuY29s b3IgPSBjYWNoZV9sZXZlbDsKPiA+ICAJb2JqLT5jYWNoZV9sZXZlbCA9IGNhY2hlX2xldmVsOwo+ ID4gIAo+ID4gK291dDoKPiA+ICAJaWYgKG9iai0+Y2FjaGVfZGlydHkgJiYKPiA+ICAJICAgIG9i ai0+YmFzZS53cml0ZV9kb21haW4gIT0gSTkxNV9HRU1fRE9NQUlOX0NQVSAmJgo+ID4gIAkgICAg Y3B1X3dyaXRlX25lZWRzX2NsZmx1c2gob2JqKSkgewo+IAo+IFRoaXMgd2UgY2FuIGRvIGJldHRl ciAoYW5kIEkga25vdyBJIGFtIGd1aWx0eSBvZiB0aGUgb3JpZ2luYWwgc2luKS4gSXQKPiBqdXN0 IGZlZWxzIGEgbGl0dGxlIHRvbyBsb29zZSB0aGF0IHdlIGV4cGVjdCBwaW4tdG8tZGlzcGxheS1w bGFuZSBzaG91bGQKPiBhbHdheXMgY2FsbCBzZXQtY2FjaGUtbGV2ZWwgKHllcywgaXQgaGFzIHRv LCBidXQgaXQgZmVlbHMgbGlrZSB3ZSBhcmUKPiBwdXR0aW5nIHBpbi10by1kaXNwbGF5LXBsYW5l IHNwZWNpZmljcyBpbnRvIHNldC1jYWNoZS1sZXZlbCkuCj4gCj4gSSB0aGluayB0aGlzIGNodW5r IGlzIG11Y2ggbW9yZSB1bmRlcnN0YW5kYWJsZSBpZiB3ZSBkaWQ6Cj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p OTE1X2dlbS5jCj4gaW5kZXggNWU3ZmNmNzdlNTdhLi5mYzZiY2MxOWNjYTEgMTAwNjQ0Cj4gLS0t IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZ2VtLmMKPiBAQCAtMzY1NiwxMyArMzY1Niw2IEBAIGludCBpOTE1X2dlbV9v YmplY3Rfc2V0X2NhY2hlX2xldmVsKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4g ICAgICAgICAgICAgICAgIHZtYS0+bm9kZS5jb2xvciA9IGNhY2hlX2xldmVsOwo+ICAgICAgICAg b2JqLT5jYWNoZV9sZXZlbCA9IGNhY2hlX2xldmVsOwo+ICAKPiAtICAgICAgIGlmIChvYmotPmNh Y2hlX2RpcnR5ICYmCj4gLSAgICAgICAgICAgb2JqLT5iYXNlLndyaXRlX2RvbWFpbiAhPSBJOTE1 X0dFTV9ET01BSU5fQ1BVICYmCj4gLSAgICAgICAgICAgY3B1X3dyaXRlX25lZWRzX2NsZmx1c2go b2JqKSkgewo+IC0gICAgICAgICAgICAgICBpZiAoaTkxNV9nZW1fY2xmbHVzaF9vYmplY3Qob2Jq LCB0cnVlKSkKPiAtICAgICAgICAgICAgICAgICAgICAgICBpOTE1X2dlbV9jaGlwc2V0X2ZsdXNo KG9iai0+YmFzZS5kZXYpOwo+IC0gICAgICAgfQo+IC0KPiAgICAgICAgIHJldHVybiAwOwo+ICB9 Cj4gIAo+IEBAIC0zNzk1LDYgKzM3ODgsMTAgQEAgaTkxNV9nZW1fb2JqZWN0X3Bpbl90b19kaXNw bGF5X3BsYW5lKHN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmosCj4gICAgICAgICBXQVJO X09OKG9iai0+cGluX2Rpc3BsYXkgPiB2bWEtPnBpbl9jb3VudCk7Cj4gIAo+ICAgICAgICAgaTkx NV9nZW1fb2JqZWN0X2ZsdXNoX2NwdV93cml0ZV9kb21haW4ob2JqKTsKPiArICAgICAgIGlmIChv YmotPmNhY2hlX2RpcnR5KSB7Cj4gKyAgICAgICAgICAgICAgIGlmIChpOTE1X2dlbV9jbGZsdXNo X29iamVjdChvYmosIHRydWUpKQo+ICsgICAgICAgICAgICAgICAgICAgICAgIGk5MTVfZ2VtX2No aXBzZXRfZmx1c2gob2JqLT5iYXNlLmRldik7Cj4gKyAgICAgICB9Cj4gIAo+ICAgICAgICAgLyog SXQgc2hvdWxkIG5vdyBiZSBvdXQgb2YgYW55IG90aGVyIHdyaXRlIGRvbWFpbnMsIGFuZCB3ZSBj YW4gdXBkYXRlCj4gICAgICAgICAgKiB0aGUgZG9tYWluIHZhbHVlcyBmb3Igb3VyIGNoYW5nZXMu Cj4gCj4gTWF5YmUgZXZlbgo+IAo+IC8qIFdoaWxzdCB0aGUgb2JqZWN0IHdhcyBhd2F5IGZyb20g dGhlIHNjYW5vdXQgd2UgbWF5IGhhdmUgYmVlbiBlbGlkaW5nIHRoZSBjb2hlcmVudAo+ICAqIHdy aXRlcyBpbnRvIHRoZSBDUFUgY2FjaGUuIEhvd2V2ZXIsIHRoZSBtb21lbnQgaXQgaGFzIHRvIGJl IHJlYWQgYnkgdGhlIGRpc3BsYXkKPiAgKiBlbmdpbmUsIHRob3NlIHdyaXRlcyBpbnRvIHRoZSBD UFUgY2FjaGUgYmVjb21lIGluYWNjZXNzaWJsZSBhbmQgc28gd2UgaGF2ZSB0byAKPiAgKiBjbGZs dXNoIHRoZW0gb3V0IHRvIG1haW4gbWVtb3J5LiBXZSB0cmFjayBlbGlkZWQgZmx1c2hlcyB3aXRo IG9iai0+Y2FjaGVfZGlydHkKPiAgKiBhbmQgaG9wZSB0aGV5IGFyZSByYXJlLgo+ICAqLwo+IAo+ IAo+IFRoZSBvdGhlciB1c2VyIG9mIHNldC1jYWNoZS1sZXZlbCAoc2V0X2NhY2hpbmdfaW9jdGwp IHNob3VsZCBub3QgY2FyZQo+IGFib3V0IHRoZSBjbGZsdXNoIHNpZGUtZWZmZWN0IGFuZCB0aGUg Y2xmbHVzaCBlbGlzaW9uIHNob3VsZCB3b3JrIGp1c3QKPiBmaW5lIGluc3RlYWQuCgpIbW0uIFNv IHdoYXQgd291bGQgaGFwcGVuIG9uICFMTEMgaWYgd2Ugc3RhcnQgd2l0aCBhIGNhY2hlZCBibywg dGhlbiBwd3JpdGUgaXQKYW5kIGFmdGVyd2FyZHMgbWFrZSBpdCB1bmNhY2hlZD8KCj4gCj4gRWl0 aGVyIHdheSwKPiBSZXZpZXdlZC1ieTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24u Y28udWs+Cj4gYnV0IEknZCBwcmVmZXIgYSB2MiB3aXRoIHRoZSBjb21tZW50cyA6KQo+IC1DaHJp cwo+IAo+IC0tIAo+IENocmlzIFdpbHNvbiwgSW50ZWwgT3BlbiBTb3VyY2UgVGVjaG5vbG9neSBD ZW50cmUKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==