From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: clflush on pin_to_display after pwrite to UC bo in LLC Date: Tue, 11 Aug 2015 18:10:29 +0300 Message-ID: <20150811151029.GT5176@intel.com> References: <1439301554-6457-1-git-send-email-ville.syrjala@linux.intel.com> <20150811142827.GD3701@nuc-i3427.alporthouse.com> <20150811145628.GS5176@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id D48BB6E7E0 for ; Tue, 11 Aug 2015 08:10:46 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150811145628.GS5176@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBBdWcgMTEsIDIwMTUgYXQgMDU6NTY6MjhQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgQXVnIDExLCAyMDE1IGF0IDAzOjI4OjI3UE0gKzAxMDAsIENocmlz IFdpbHNvbiB3cm90ZToKPiA+IE9uIFR1ZSwgQXVnIDExLCAyMDE1IGF0IDA0OjU5OjE0UE0gKzAz MDAsIHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tIHdyb3RlOgo+ID4gPiBGcm9tOiBWaWxs ZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiAKPiA+ID4g Q3VycmVudGx5IHdlIGRvbid0IGNsZmx1c2ggb24gcGluX3RvX2Rpc3BsYXkgaWYgdGhlIGJvIGlz IGFscmVhZHkKPiA+ID4gVUMvV1QgYW5kIGlzIG5vdCBpbiB0aGUgQ1BVIHdyaXRlIGRvbWFpbi4g VGhpcyBjYXVzZXMgcHJvYmxlbXMgd2l0aAo+ID4gPiBwd3JpdGUgc2luY2UgcHdyaXRlIGRvZXNu J3QgY2hhbmdlIHRoZSB3cml0ZSBkb21haW4sIGFuZCBpdCBhdm9pZHMKPiA+ID4gY2xmbHVzaGlu ZyBvbiBVQy9XVCBidWZmZXJzIG9uIExMQyBwbGF0Zm9ybXMgdW5sZXNzIHRoZSBidWZmZXIgaXMK PiA+ID4gY3VycmVudGx5IGJlaW5nIHNjYW5uZWQgb3V0Lgo+ID4gPiAKPiA+ID4gRml4IHRoZSBw cm9ibGVtIGJ5IG1hcmtpbmcgdGhlIGNhY2hlIGRpcnR5IGFuZCBhZGp1c3RpbmcKPiA+ID4gaTkx NV9nZW1fb2JqZWN0X3NldF9jYWNoZV9sZXZlbCgpIHRvIGNsZmx1c2ggd2hlbiB0aGUgY2FjaGUg aXMgZGlydHkKPiA+ID4gZXZlbiBpZiB0aGUgY2FjaGVfbGV2ZWwgZG9lc24ndCBjaGFuZ2UuCj4g PiA+IAo+ID4gPiBNeSBsYXN0IGF0dGVtcHQgWzFdIGF0IGZpeGluZyB0aGlzIHZpYSB3cml0ZSBk b21haW4gZnJvYmJpbmcgd2FzIHNob3QKPiA+ID4gZG93biwgYnV0IG5vdyB3aXRoIHRoZSBjYWNo ZV9kaXJ0eSBmbGFnIHdlIGNhbiBkbyB0aGluZ3MgaW4gYSBuaWNlciB3YXkuCj4gPiA+IAo+ID4g PiBbMV0gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9pbnRlbC1nZngvMjAx NC1Ob3ZlbWJlci8wNTUzOTAuaHRtbAo+ID4gPiAKPiA+ID4gQnVnemlsbGE6IGh0dHBzOi8vYnVn cy5mcmVlZGVza3RvcC5vcmcvc2hvd19idWcuY2dpP2lkPTg2NDIyCj4gPiA+IFRlc3RjYXNlOiBp Z3Qva21zX3B3cml0ZV9jcmMKPiA+ID4gU2lnbmVkLW9mZi1ieTogVmlsbGUgU3lyasOkbMOkIDx2 aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgMTAgKysrKysrKy0tLQo+ID4gPiAgMSBmaWxlIGNoYW5n ZWQsIDcgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiA+ID4gCj4gPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+ID4gPiBpbmRleCA3MzI5M2I0Li43M2VmZjJlIDEwMDY0NAo+ID4gPiAt LS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gPiA+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+ID4gQEAgLTEwMDUsMTIgKzEwMDUsMTUgQEAgb3V0 Ogo+ID4gPiAgCQlpZiAoIW5lZWRzX2NsZmx1c2hfYWZ0ZXIgJiYKPiA+ID4gIAkJICAgIG9iai0+ YmFzZS53cml0ZV9kb21haW4gIT0gSTkxNV9HRU1fRE9NQUlOX0NQVSkgewo+ID4gPiAgCQkJaWYg KGk5MTVfZ2VtX2NsZmx1c2hfb2JqZWN0KG9iaiwgb2JqLT5waW5fZGlzcGxheSkpCj4gPiA+IC0J CQkJaTkxNV9nZW1fY2hpcHNldF9mbHVzaChkZXYpOwo+ID4gPiArCQkJCW5lZWRzX2NsZmx1c2hf YWZ0ZXIgPSB0cnVlOwo+ID4gPiAgCQl9Cj4gPiA+ICAJfQo+ID4gPiAgCj4gPiA+ICAJaWYgKG5l ZWRzX2NsZmx1c2hfYWZ0ZXIpCj4gPiA+ICAJCWk5MTVfZ2VtX2NoaXBzZXRfZmx1c2goZGV2KTsK PiA+ID4gKwllbHNlIGlmIChvYmotPmNhY2hlX2xldmVsID09IEk5MTVfQ0FDSEVfTk9ORSB8fAo+ ID4gPiArCQkgb2JqLT5jYWNoZV9sZXZlbCA9PSBJOTE1X0NBQ0hFX1dUKQo+ID4gPiArCQlvYmot PmNhY2hlX2RpcnR5ID0gdHJ1ZTsKPiA+ID4gIAo+ID4gPiAgCWludGVsX2ZiX29ial9mbHVzaChv YmosIGZhbHNlLCBPUklHSU5fQ1BVKTsKPiA+ID4gIAlyZXR1cm4gcmV0Owo+ID4gCj4gPiBPaywg dGhpcyBzZWVtcyByZWFzb25hYmxlLgo+ID4gCj4gPiA+IEBAIC0zNjM5LDEwICszNjQyLDEwIEBA IGludCBpOTE1X2dlbV9vYmplY3Rfc2V0X2NhY2hlX2xldmVsKHN0cnVjdCBkcm1faTkxNV9nZW1f b2JqZWN0ICpvYmosCj4gPiA+ICB7Cj4gPiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IG9i ai0+YmFzZS5kZXY7Cj4gPiA+ICAJc3RydWN0IGk5MTVfdm1hICp2bWEsICpuZXh0Owo+ID4gPiAt CWludCByZXQ7Cj4gPiA+ICsJaW50IHJldCA9IDA7Cj4gPiA+ICAKPiA+ID4gIAlpZiAob2JqLT5j YWNoZV9sZXZlbCA9PSBjYWNoZV9sZXZlbCkKPiA+ID4gLQkJcmV0dXJuIDA7Cj4gPiA+ICsJCWdv dG8gb3V0Owo+ID4gPiAgCj4gPiA+ICAJaWYgKGk5MTVfZ2VtX29ial9pc19waW5uZWQob2JqKSkg ewo+ID4gPiAgCQlEUk1fREVCVUcoImNhbiBub3QgY2hhbmdlIHRoZSBjYWNoZSBsZXZlbCBvZiBw aW5uZWQgb2JqZWN0c1xuIik7Cj4gPiA+IEBAIC0zNjg3LDYgKzM2OTAsNyBAQCBpbnQgaTkxNV9n ZW1fb2JqZWN0X3NldF9jYWNoZV9sZXZlbChzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2Jq LAo+ID4gPiAgCQl2bWEtPm5vZGUuY29sb3IgPSBjYWNoZV9sZXZlbDsKPiA+ID4gIAlvYmotPmNh Y2hlX2xldmVsID0gY2FjaGVfbGV2ZWw7Cj4gPiA+ICAKPiA+ID4gK291dDoKPiA+ID4gIAlpZiAo b2JqLT5jYWNoZV9kaXJ0eSAmJgo+ID4gPiAgCSAgICBvYmotPmJhc2Uud3JpdGVfZG9tYWluICE9 IEk5MTVfR0VNX0RPTUFJTl9DUFUgJiYKPiA+ID4gIAkgICAgY3B1X3dyaXRlX25lZWRzX2NsZmx1 c2gob2JqKSkgewo+ID4gCj4gPiBUaGlzIHdlIGNhbiBkbyBiZXR0ZXIgKGFuZCBJIGtub3cgSSBh bSBndWlsdHkgb2YgdGhlIG9yaWdpbmFsIHNpbikuIEl0Cj4gPiBqdXN0IGZlZWxzIGEgbGl0dGxl IHRvbyBsb29zZSB0aGF0IHdlIGV4cGVjdCBwaW4tdG8tZGlzcGxheS1wbGFuZSBzaG91bGQKPiA+ IGFsd2F5cyBjYWxsIHNldC1jYWNoZS1sZXZlbCAoeWVzLCBpdCBoYXMgdG8sIGJ1dCBpdCBmZWVs cyBsaWtlIHdlIGFyZQo+ID4gcHV0dGluZyBwaW4tdG8tZGlzcGxheS1wbGFuZSBzcGVjaWZpY3Mg aW50byBzZXQtY2FjaGUtbGV2ZWwpLgo+ID4gCj4gPiBJIHRoaW5rIHRoaXMgY2h1bmsgaXMgbXVj aCBtb3JlIHVuZGVyc3RhbmRhYmxlIGlmIHdlIGRpZDoKPiA+IAo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1 X2dlbS5jCj4gPiBpbmRleCA1ZTdmY2Y3N2U1N2EuLmZjNmJjYzE5Y2NhMSAxMDA2NDQKPiA+IC0t LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZ2VtLmMKPiA+IEBAIC0zNjU2LDEzICszNjU2LDYgQEAgaW50IGk5MTVf Z2VtX29iamVjdF9zZXRfY2FjaGVfbGV2ZWwoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9i aiwKPiA+ICAgICAgICAgICAgICAgICB2bWEtPm5vZGUuY29sb3IgPSBjYWNoZV9sZXZlbDsKPiA+ ICAgICAgICAgb2JqLT5jYWNoZV9sZXZlbCA9IGNhY2hlX2xldmVsOwo+ID4gIAo+ID4gLSAgICAg ICBpZiAob2JqLT5jYWNoZV9kaXJ0eSAmJgo+ID4gLSAgICAgICAgICAgb2JqLT5iYXNlLndyaXRl X2RvbWFpbiAhPSBJOTE1X0dFTV9ET01BSU5fQ1BVICYmCj4gPiAtICAgICAgICAgICBjcHVfd3Jp dGVfbmVlZHNfY2xmbHVzaChvYmopKSB7Cj4gPiAtICAgICAgICAgICAgICAgaWYgKGk5MTVfZ2Vt X2NsZmx1c2hfb2JqZWN0KG9iaiwgdHJ1ZSkpCj4gPiAtICAgICAgICAgICAgICAgICAgICAgICBp OTE1X2dlbV9jaGlwc2V0X2ZsdXNoKG9iai0+YmFzZS5kZXYpOwo+ID4gLSAgICAgICB9Cj4gPiAt Cj4gPiAgICAgICAgIHJldHVybiAwOwo+ID4gIH0KPiA+ICAKPiA+IEBAIC0zNzk1LDYgKzM3ODgs MTAgQEAgaTkxNV9nZW1fb2JqZWN0X3Bpbl90b19kaXNwbGF5X3BsYW5lKHN0cnVjdCBkcm1faTkx NV9nZW1fb2JqZWN0ICpvYmosCj4gPiAgICAgICAgIFdBUk5fT04ob2JqLT5waW5fZGlzcGxheSA+ IHZtYS0+cGluX2NvdW50KTsKPiA+ICAKPiA+ICAgICAgICAgaTkxNV9nZW1fb2JqZWN0X2ZsdXNo X2NwdV93cml0ZV9kb21haW4ob2JqKTsKPiA+ICsgICAgICAgaWYgKG9iai0+Y2FjaGVfZGlydHkp IHsKPiA+ICsgICAgICAgICAgICAgICBpZiAoaTkxNV9nZW1fY2xmbHVzaF9vYmplY3Qob2JqLCB0 cnVlKSkKPiA+ICsgICAgICAgICAgICAgICAgICAgICAgIGk5MTVfZ2VtX2NoaXBzZXRfZmx1c2go b2JqLT5iYXNlLmRldik7Cj4gPiArICAgICAgIH0KPiA+ICAKPiA+ICAgICAgICAgLyogSXQgc2hv dWxkIG5vdyBiZSBvdXQgb2YgYW55IG90aGVyIHdyaXRlIGRvbWFpbnMsIGFuZCB3ZSBjYW4gdXBk YXRlCj4gPiAgICAgICAgICAqIHRoZSBkb21haW4gdmFsdWVzIGZvciBvdXIgY2hhbmdlcy4KPiA+ IAo+ID4gTWF5YmUgZXZlbgo+ID4gCj4gPiAvKiBXaGlsc3QgdGhlIG9iamVjdCB3YXMgYXdheSBm cm9tIHRoZSBzY2Fub3V0IHdlIG1heSBoYXZlIGJlZW4gZWxpZGluZyB0aGUgY29oZXJlbnQKPiA+ ICAqIHdyaXRlcyBpbnRvIHRoZSBDUFUgY2FjaGUuIEhvd2V2ZXIsIHRoZSBtb21lbnQgaXQgaGFz IHRvIGJlIHJlYWQgYnkgdGhlIGRpc3BsYXkKPiA+ICAqIGVuZ2luZSwgdGhvc2Ugd3JpdGVzIGlu dG8gdGhlIENQVSBjYWNoZSBiZWNvbWUgaW5hY2Nlc3NpYmxlIGFuZCBzbyB3ZSBoYXZlIHRvIAo+ ID4gICogY2xmbHVzaCB0aGVtIG91dCB0byBtYWluIG1lbW9yeS4gV2UgdHJhY2sgZWxpZGVkIGZs dXNoZXMgd2l0aCBvYmotPmNhY2hlX2RpcnR5Cj4gPiAgKiBhbmQgaG9wZSB0aGV5IGFyZSByYXJl Lgo+ID4gICovCj4gPiAKPiA+IAo+ID4gVGhlIG90aGVyIHVzZXIgb2Ygc2V0LWNhY2hlLWxldmVs IChzZXRfY2FjaGluZ19pb2N0bCkgc2hvdWxkIG5vdCBjYXJlCj4gPiBhYm91dCB0aGUgY2xmbHVz aCBzaWRlLWVmZmVjdCBhbmQgdGhlIGNsZmx1c2ggZWxpc2lvbiBzaG91bGQgd29yayBqdXN0Cj4g PiBmaW5lIGluc3RlYWQuCj4gCj4gSG1tLiBTbyB3aGF0IHdvdWxkIGhhcHBlbiBvbiAhTExDIGlm IHdlIHN0YXJ0IHdpdGggYSBjYWNoZWQgYm8sIHRoZW4gcHdyaXRlIGl0Cj4gYW5kIGFmdGVyd2Fy ZHMgbWFrZSBpdCB1bmNhY2hlZD8KCkluIGZhY3QgdGhhdCB3b3VsZCBzdGlsbCBmYWlsIGV2ZW4g d2l0aCBteSBwYXRjaCwgYW5kIHdvdWxkbid0IHdvcmsgd2l0aCBjdXJyZW50CnVwc3RyZWFtIGNv ZGUgZWl0aGVyLiBUbyBmaXggdGhhdCBJJ2QgbmVlZCB0byBkcm9wIHRoZSBJOTE1X0NBQ0hFX05P TkUvV1QgY2hlY2tzCmZyb20gcHdyaXRlIGluIG15IHBhdGNoIGFuZCBhbHdheXMgc2V0IGNhY2hl X2RpcnR5PXRydWUgd2hlbiBpdCBkaWRuJ3QKY2xmbHVzaC4gRG9pbmcgdGhhdCB3b3VsZCBzZWVt IHBlcmZlY3RseSByZWFzb25hYmxlIHRvIG1lLgoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBP VEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwt Z2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK