From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Weinehall Subject: Re: [PATCH 1/2 v2 addendum v2] drm/i915: Allow parsing of variable size child device entries from VBT Date: Thu, 13 Aug 2015 16:14:15 +0300 Message-ID: <20150813131415.GO6150@boom> References: <1436526655-2965-1-git-send-email-antti.koskipaa@linux.intel.com> <1436526655-2965-2-git-send-email-antti.koskipaa@linux.intel.com> <20150804135552.GC6150@boom> <20150805085900.GM17734@phenom.ffwll.local> <55C3682E.6080103@intel.com> <20150806140855.GE6150@boom> <20150806153102.GW17734@phenom.ffwll.local> <20150812102917.GL6150@boom> <8737zotwqw.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 90DB56EDB7 for ; Thu, 13 Aug 2015 06:15:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <8737zotwqw.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: "intel-gfx@lists.freedesktop.org" List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBBdWcgMTIsIDIwMTUgYXQgMDU6MTk6MzVQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gV2VkLCAxMiBBdWcgMjAxNSwgRGF2aWQgV2VpbmVoYWxsIDxkYXZpZC53ZWluZWhh bGxAbGludXguaW50ZWwuY29tPiB3cm90ZToKPiA+IFNvbWUgbW9yZSBmaXh1cCBpcyBuZWVkZWQ7 IHRoZSBiaXRzIGZyb20gQW50dGkncyBwYXRjaAo+ID4gdGhhdCBhY3R1YWxseSBleHBhbmRlZCB0 aGUgc3RydWN0IHRvIGZ1bGx5IGZpdCB0aGUgbmV3ZXIKPiA+IHZlcnNpb25zIG9mIHRoZSBjaGls ZF9kZXZpY2VfY29uZmlnIHdhcyBwYXJ0IG9mIHRoZSBzZWNvbmQKPiA+IHBhdGNoOyBzaW5jZSB0 aGF0IHBhdGNoIGhhc24ndCBiZWVuIG1lcmdlZCB5ZXQgd2UgbmVlZCB0aGlzIGJpdDoKPiA+Cj4g PiBUaGlzIGFwcGxpZXMgb24gdG9wIG9mIHRoZSBwYXRjaCB5b3UgYWxyZWFkeSBtZXJnZWQKPiA+ ICh0aGUgSWJvb3N0IHBhdGNoIHdpbGwgbmVlZCBjb3JyZXNwb25kaW5nIGFkanVzdG1lbnQgdG8K PiA+ICByZW1vdmUgdGhlIGNoYW5nZXMgSSBzcGxpdCBvdXQpOgo+ID4KPiA+IEV4cGFuZCBjb21t b25fY2hpbGRfZGV2X2NvbmZpZyB0byBiZSBhYmxlIHRvIGZpdCBhbGwgaW5mb3JtYXRpb24KPiA+ IGRlZmluZWQgYnkgdGhlIGxhdGVzdCBWQlQgc3BlY2lmaWNhdGlvbi4KPiA+Cj4gPiBTaWduZWQt b2ZmLWJ5OiBEYXZpZCBXZWluZWhhbGwgPGRhdmlkLndlaW5laGFsbEBsaW51eC5pbnRlbC5jb20+ Cj4gPiBDQzogQW50dGkgS29za2lwYWEgPGFudHRpLmtvc2tpcGFhQGxpbnV4LmludGVsLmNvbT4K PiA+IC0tLQo+ID4gIGludGVsX2Jpb3MuYyB8ICAgIDcgKysrKysrLQo+ID4gIGludGVsX2Jpb3Mu aCB8ICAgIDQgKysrKwo+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbigtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9iaW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMKPiA+IGluZGV4IDk5 MGFjYzIwNzcxYS4uNDBlMmNjNGU3NDE5IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfYmlvcy5jCj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9i aW9zLmMKPiA+IEBAIC0xMDM4LDYgKzEwMzgsMTAgQEAgcGFyc2VfZGV2aWNlX21hcHBpbmcoc3Ry dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ID4gIAkJRFJNX0RFQlVHX0tNUygiTm8g Z2VuZXJhbCBkZWZpbml0aW9uIGJsb2NrIGlzIGZvdW5kLCBubyBkZXZpY2VzIGRlZmluZWQuXG4i KTsKPiA+ICAJCXJldHVybjsKPiA+ICAJfQo+ID4gKwkvKiBSZW1lbWJlciB0byBrZWVwIHRoaXMg aW4gc3luYyB3aXRoIGNoaWxkX2RldmljZV9jb25maWc7Cj4gPiArCSAqIHdoZW5ldmVyIGEgbmV3 IGZlYXR1cmUgaXMgYWRkZWQgdG8gQkRCIHRoYXQgY2F1c2VzIHRoYXQKPiA+ICsJICogc3RydWN0 IHRvIGdyb3cgdGhpcyBuZWVkcyB0byBiZSB1cGRhdGVkIHRvbwo+ID4gKwkgKi8KPiA+ICAJaWYg KGJkYi0+dmVyc2lvbiA8IDE5NSkgewo+ID4gIAkJZXhwZWN0ZWRfc2l6ZSA9IDMzOwo+ID4gIAl9 IGVsc2UgaWYgKGJkYi0+dmVyc2lvbiA9PSAxOTUpIHsKPiA+IEBAIC0xMDUxLDcgKzEwNTUsOCBA QCBwYXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4gPiAgCX0KPiA+ICAKPiA+ICAJaWYgKGV4cGVjdGVkX3NpemUgPiBzaXplb2YoKnBfY2hpbGQp KSB7Cj4gPiAtCQlEUk1fRVJST1IoImNoaWxkX2RldmljZV9jb25maWcgY2Fubm90IGZpdCBpbiBw X2NoaWxkXG4iKTsKPiA+ICsJCURSTV9FUlJPUigiY2hpbGRfZGV2aWNlX2NvbmZpZyAoc2l6ZSAl dSkgY2Fubm90IGZpdCBpbiBwX2NoaWxkIChzaXplICV1KTsgYmRiLT52ZXJzaW9uOiAldVxuIiwK PiA+ICsJCQkgIGV4cGVjdGVkX3NpemUsIHNpemVvZigqcF9jaGlsZCksIGJkYi0+dmVyc2lvbik7 Cj4gCj4gZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfYmlvcy5jOiBJbiBmdW5jdGlvbiDigJhw YXJzZV9kZXZpY2VfbWFwcGluZ+KAmToKPiBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9z LmM6MTA1ODozOiB3YXJuaW5nOiBmb3JtYXQg4oCYJXXigJkgZXhwZWN0cyBhcmd1bWVudCBvZiB0 eXBlIOKAmHVuc2lnbmVkIGludOKAmSwgYnV0IGFyZ3VtZW50IDMgaGFzIHR5cGUg4oCYbG9uZyB1 bnNpZ25lZCBpbnTigJkgWy1XZm9ybWF0PV0KPiAgICBEUk1fRVJST1IoImNoaWxkX2RldmljZV9j b25maWcgKHNpemUgJXUpIGNhbm5vdCBmaXQgaW4gcF9jaGlsZCAoc2l6ZSAldSk7IGJkYi0+dmVy c2lvbjogJXVcbiIsCj4gICAgXgo+ICAgQ0MgW01dICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9maWZvX3VuZGVycnVuLm8KCldlbGwgc3BvdHRlZC4gIE9yIHJhdGhlciwgc3R1cGlkIG9mIG1l IHRvIGZvcmdldCB0aGF0IHNpemVvZiB5aWVsZHMKc2l6ZV90IGFzIHR5cGUsIHRodXMgbmVjZXNz aXRhdGluZyAlenUgYXMgY29udmVyc2lvbiBzcGVjaWZpZXIuCgpGaXhlZCB2ZXJzaW9uOgoKRXhw YW5kIGNvbW1vbl9jaGlsZF9kZXZfY29uZmlnIHRvIGJlIGFibGUgdG8gZml0IGFsbCBpbmZvcm1h dGlvbgpkZWZpbmVkIGJ5IHRoZSBsYXRlc3QgVkJUIHNwZWNpZmljYXRpb24uCgp2MjogVXNlIHBy b3BlciBjb252ZXJzaW9uIHNwZWNpZmllciBmb3Igc2l6ZV90ICglenUpCgpTaWduZWQtb2ZmLWJ5 OiBEYXZpZCBXZWluZWhhbGwgPGRhdmlkLndlaW5laGFsbEBsaW51eC5pbnRlbC5jb20+CkNDOiBB bnR0aSBLb3NraXBhYSA8YW50dGkua29za2lwYWFAbGludXguaW50ZWwuY29tPgoKIGludGVsX2Jp b3MuYyB8ICAgIDcgKysrKysrLQogaW50ZWxfYmlvcy5oIHwgICAgNCArKysrCiAyIGZpbGVzIGNo YW5nZWQsIDEwIGluc2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9iaW9zLmMKaW5kZXggOTkwYWNjMjA3NzFhLi41NjczZWQ1Mzc5N2IgMTAwNjQ0Ci0tLSBhL2Ry aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jpb3MuYworKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9iaW9zLmMKQEAgLTEwMzgsNiArMTAzOCwxMCBAQCBwYXJzZV9kZXZpY2VfbWFwcGlu ZyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCiAJCURSTV9ERUJVR19LTVMoIk5v IGdlbmVyYWwgZGVmaW5pdGlvbiBibG9jayBpcyBmb3VuZCwgbm8gZGV2aWNlcyBkZWZpbmVkLlxu Iik7CiAJCXJldHVybjsKIAl9CisJLyogUmVtZW1iZXIgdG8ga2VlcCB0aGlzIGluIHN5bmMgd2l0 aCBjaGlsZF9kZXZpY2VfY29uZmlnOworCSAqIHdoZW5ldmVyIGEgbmV3IGZlYXR1cmUgaXMgYWRk ZWQgdG8gQkRCIHRoYXQgY2F1c2VzIHRoYXQKKwkgKiBzdHJ1Y3QgdG8gZ3JvdyB0aGlzIG5lZWRz IHRvIGJlIHVwZGF0ZWQgdG9vCisJICovCiAJaWYgKGJkYi0+dmVyc2lvbiA8IDE5NSkgewogCQll eHBlY3RlZF9zaXplID0gMzM7CiAJfSBlbHNlIGlmIChiZGItPnZlcnNpb24gPT0gMTk1KSB7CkBA IC0xMDUxLDcgKzEwNTUsOCBAQCBwYXJzZV9kZXZpY2VfbWFwcGluZyhzdHJ1Y3QgZHJtX2k5MTVf cHJpdmF0ZSAqZGV2X3ByaXYsCiAJfQogCiAJaWYgKGV4cGVjdGVkX3NpemUgPiBzaXplb2YoKnBf Y2hpbGQpKSB7Ci0JCURSTV9FUlJPUigiY2hpbGRfZGV2aWNlX2NvbmZpZyBjYW5ub3QgZml0IGlu IHBfY2hpbGRcbiIpOworCQlEUk1fRVJST1IoImNoaWxkX2RldmljZV9jb25maWcgKHNpemUgJXUp IGNhbm5vdCBmaXQgaW4gcF9jaGlsZCAoc2l6ZSAlenUpOyBiZGItPnZlcnNpb246ICV1XG4iLAor CQkJICBleHBlY3RlZF9zaXplLCBzaXplb2YoKnBfY2hpbGQpLCBiZGItPnZlcnNpb24pOwogCQly ZXR1cm47CiAJfQogCmRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9z LmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmgKaW5kZXggZjdhZDZhNTg1MTI5 Li43MWNiOTZmNzc4NzAgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Jp b3MuaAorKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9iaW9zLmgKQEAgLTIzOSw2ICsy MzksMTAgQEAgc3RydWN0IGNvbW1vbl9jaGlsZF9kZXZfY29uZmlnIHsKIAl1OCBub3RfY29tbW9u MlsyXTsKIAl1OCBkZGNfcGluOwogCXUxNiBlZGlkX3B0cjsKKwl1OCBvYnNvbGV0ZTsKKwl1OCBm bGFnc18xOworCXU4IG5vdF9jb21tb24zWzEzXTsKKwl1OCBpYm9vc3RfbGV2ZWw7CiB9IF9fcGFj a2VkOwogCiAvKiBUaGlzIGZpZWxkIGNoYW5nZXMgZGVwZW5kaW5nIG9uIHRoZSBCREIgdmVyc2lv biwgc28gdGhlIG1vc3QgcmVsaWFibGUgd2F5IHRvCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==