Re: [PATCH 13/18] tests/kms_vblank: mark accuracy test as basic

Daniel Vetter
2015-08-14T12:47:36Z

On Fri, Aug 14, 2015 at 02:44:14PM +0200, Daniel Vetter wrote:
> On Thu, Aug 13, 2015 at 01:31:36PM -0700, Jesse Barnes wrote:
> > Need some simple vblank coverage in the BAT list.
> >
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
>
> This testcase relies upon fbcon to have enabled pipe 0, which means it
> spuriously skips (when fbcon is disabled or when it's blanked the screen)
> until that's fixed. Same problem happens with drm_read.
>
> Until that's addressed imo Nack for basic igt testcase list. I'll do a
> jira about this issue.

Meanwhile for a basic vblank testcase I think we should pick one of the
kms_flip ones.
-Daniel

> -Daniel
> > ---
> > tests/kms_vblank.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> > index 6946177..ef2f7ca 100644
> > --- a/tests/kms_vblank.c
> > +++ b/tests/kms_vblank.c
> > @@ -188,7 +188,7 @@ igt_main
> > igt_require(crtc0_active(fd));
> > }
> >
> > - igt_subtest("accuracy")
> > + igt_subtest("basic-accuracy")
> > accuracy(fd);
> >
> > igt_subtest("query-idle")
> > --
> > 1.9.1
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch

--
Daniel Vetter
Software Engineer, Intel Corporation