Re: [PATCH 08/18] tests/gem_mmap: mark basic object creation tests as basic

Daniel Vetter
2015-08-14T16:05:06Z

On Fri, Aug 14, 2015 at 08:31:53AM -0700, Jesse Barnes wrote:
> On 08/14/2015 05:33 AM, Daniel Vetter wrote:
> > On Thu, Aug 13, 2015 at 01:31:31PM -0700, Jesse Barnes wrote:
> >> We should be able to create small and moderate sized objects quickly and
> >> without errors.
> >>
> >> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >
> > They're all super-fast basic testcases for api cornercases. I'd vote to
> > rename the entire testcase to gem_mmap_basic.
>
> Not quite, the huge ones were pretty slow in my measurements... Not as
> bad as suspend/resume, but not super fast either.

Right I missed those two at the bottom. But everything above small-bo
looks very basic, so perhaps just include them all with a basic-* prefix?
And keep the first one as basic-new-object?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation