Re: [PATCH 15/18] tests/pm_rpm: mark RTE and D3 tests as basic

Daniel Vetter
2015-08-14T16:06:22Z

On Fri, Aug 14, 2015 at 08:48:42AM -0700, Jesse Barnes wrote:
> On 08/14/2015 05:50 AM, Daniel Vetter wrote:
> > On Thu, Aug 13, 2015 at 01:31:38PM -0700, Jesse Barnes wrote:
> >> These always need to pass for basic PM functionality.
> >>
> >> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> >> ---
> >> tests/pm_rpm.c | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c
> >> index d509fa8..7ae5806 100644
> >> --- a/tests/pm_rpm.c
> >> +++ b/tests/pm_rpm.c
> >> @@ -1832,11 +1832,11 @@ int main(int argc, char *argv[])
> >> stay_subtest();
> >>
> >> /* Essential things */
> >> - igt_subtest("rte")
> >> + igt_subtest("basic-rte")
> >
> > I thought our BAT criteria would be basic|rte?
> >
> > rte is runtime environment check and more along the lines of "did QA set
> > up their machine correctly", so imo good to keep separate.
>
> I was hoping to keep the BAT in the 'basic' namespace only, so rte tests
> would be included as well, but we'd need to prefix them with basic- too.
> Sounds like Paulo is ok with that, so I'll keep it here. Makes test
> running that much simpler. :)

Yeah makes sense, ok with me if we go with just "basic".
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation