Re: [PATCH 06/18] tests/drv_suspend: mark sysfs tests as basic

Daniel Vetter
2015-08-14T12:29:43Z

On Thu, Aug 13, 2015 at 01:31:29PM -0700, Jesse Barnes wrote:
> debugfs may not be mounted, but sysfs should always be restored after
> suspend or hibernate.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

We already have a suspend/resume testcase in kms_pipc_crc_basic. Do we
have enough budget for this one?
> ---
> tests/drv_suspend.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/drv_suspend.c b/tests/drv_suspend.c
> index d67a794..60ca8e3 100644
> --- a/tests/drv_suspend.c
> +++ b/tests/drv_suspend.c
> @@ -193,7 +193,7 @@ igt_main
> igt_subtest("debugfs-reader")
> test_debugfs_reader(false);
>
> - igt_subtest("sysfs-reader")
> + igt_subtest("basic-sysfs-reader")
> test_sysfs_reader(false);
>
> igt_subtest("forcewake")
> @@ -208,7 +208,7 @@ igt_main
> igt_subtest("debugfs-reader-hibernate")
> test_debugfs_reader(true);
>
> - igt_subtest("sysfs-reader-hibernate")
> + igt_subtest("basic-sysfs-reader-hibernate")
> test_sysfs_reader(true);

Hibernate is a giantic can of worms. We have a big pile of issues here
that we never fixed. Otoh not testing hibernate is definitely an
oversight. Assuming we have the testing budget:

Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> igt_subtest("forcewake-hibernate")
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation