Re: [PATCH 08/18] tests/gem_mmap: mark basic object creation tests as basic

Daniel Vetter
2015-08-14T12:33:29Z

On Thu, Aug 13, 2015 at 01:31:31PM -0700, Jesse Barnes wrote:
> We should be able to create small and moderate sized objects quickly and
> without errors.
>
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

They're all super-fast basic testcases for api cornercases. I'd vote to
rename the entire testcase to gem_mmap_basic.
-Daniel

> ---
> tests/gem_mmap.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/gem_mmap.c b/tests/gem_mmap.c
> index 095f5b9..dd66ad6 100644
> --- a/tests/gem_mmap.c
> +++ b/tests/gem_mmap.c
> @@ -118,7 +118,7 @@ igt_main
> igt_assert(ret == -1 && errno == ENOENT);
> }
>
> - igt_subtest("new-object") {
> + igt_subtest("basic") {
> arg.handle = gem_create(fd, OBJECT_SIZE);
> arg.offset = 0;
> arg.size = OBJECT_SIZE;
> @@ -154,7 +154,7 @@ igt_main
> gem_close(fd, arg.handle);
> }
>
> - igt_subtest("small-bo")
> + igt_subtest("basic-small-bo")
> test_huge_bo(fd, -1);
> igt_subtest("big-bo")
> test_huge_bo(fd, 0);
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

--
Daniel Vetter
Software Engineer, Intel Corporation