From: Daniel Vetter <daniel@ffwll.ch>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, mika.westerberg@intel.com
Subject: Re: [PATCH] drm/i915/skl: WaIgnoreDDIAStrap is forever, always init DDI A
Date: Fri, 14 Aug 2015 11:29:05 +0200 [thread overview]
Message-ID: <20150814092905.GX17734@phenom.ffwll.local> (raw)
In-Reply-To: <1439538797-13824-1-git-send-email-jani.nikula@intel.com>
On Fri, Aug 14, 2015 at 10:53:17AM +0300, Jani Nikula wrote:
> There is currently conflicting documentation on which steppings the
> workaround is needed, up to C vs. forever. However there is post-C
> stepping hardware that doesn't report port presence on DDI A, leading to
> black screen on eDP. Assume the strap isn't connected, and try to enable
> DDI A on these machines. (We'll still check the VBT for the info in DDI
> init.)
>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Mika Westerberg <mika.westerberg@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_display.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 21aa745caed1..aa208a2cfafc 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13949,8 +13949,7 @@ static void intel_setup_outputs(struct drm_device *dev)
> */
> found = I915_READ(DDI_BUF_CTL_A) & DDI_INIT_DISPLAY_DETECTED;
> /* WaIgnoreDDIAStrap: skl */
> - if (found ||
> - (IS_SKYLAKE(dev) && INTEL_REVID(dev) < SKL_REVID_D0))
> + if (found || IS_SKYLAKE(dev))
> intel_ddi_init(dev, PORT_A);
>
> /* DDI B, C and D detection is indicated by the SFUSE_STRAP
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-14 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 7:53 [PATCH] drm/i915/skl: WaIgnoreDDIAStrap is forever, always init DDI A Jani Nikula
2015-08-14 9:29 ` Daniel Vetter [this message]
2015-08-16 0:27 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150814092905.GX17734@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=mika.westerberg@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox