Re: [PATCH 13/18] tests/kms_vblank: mark accuracy test as basic

From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 13/18] tests/kms_vblank: mark accuracy test as basic
Date: Fri, 14 Aug 2015 14:44:14 +0200	[thread overview]
Message-ID: <20150814124414.GL17734@phenom.ffwll.local> (raw)
In-Reply-To: <1439497901-14310-13-git-send-email-jbarnes@virtuousgeek.org>

On Thu, Aug 13, 2015 at 01:31:36PM -0700, Jesse Barnes wrote:
> Need some simple vblank coverage in the BAT list.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

This testcase relies upon fbcon to have enabled pipe 0, which means it
spuriously skips (when fbcon is disabled or when it's blanked the screen)
until that's fixed. Same problem happens with drm_read.

Until that's addressed imo Nack for basic igt testcase list. I'll do a
jira about this issue.
-Daniel
> ---
>  tests/kms_vblank.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_vblank.c b/tests/kms_vblank.c
> index 6946177..ef2f7ca 100644
> --- a/tests/kms_vblank.c
> +++ b/tests/kms_vblank.c
> @@ -188,7 +188,7 @@ igt_main
>  		igt_require(crtc0_active(fd));
>  	}
>  
> -	igt_subtest("accuracy")
> +	igt_subtest("basic-accuracy")
>  		accuracy(fd);
>  
>  	igt_subtest("query-idle")
> -- 
> 1.9.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx