From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Michel Thierry <michel.thierry@intel.com>,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/mm: Do DRM_MM_CREATE_TOP adj_start calculation after color_adjust
Date: Tue, 25 Aug 2015 10:24:53 +0200 [thread overview]
Message-ID: <20150825082453.GR20434@phenom.ffwll.local> (raw)
In-Reply-To: <20150816075253.GA26025@nuc-i3427.alporthouse.com>
On Sun, Aug 16, 2015 at 08:52:54AM +0100, Chris Wilson wrote:
> On Sun, Aug 16, 2015 at 04:02:28AM +0100, Michel Thierry wrote:
> > The adj_start calculation for DRM_MM_CREATE_TOP should happen after
> > mm->color_adjust. There was an inconsistency between
> > drm_mm_insert_helper_range
> > and drm_mm_insert_helper, as the later was already updating after
> > color_adjust.
> >
> > Didn't spot it before, as color_adjust is only done in systems without
> > LLC. But I'm not aware of anybody using this test case yet.
> >
> > Signed-off-by: Michel Thierry <michel.thierry@intel.com>
>
> I sent this patch a few years ago, when I was using a top-down
> allocator before llc and I have a similar patch in my tree which I kept
> meaning to polish up and warn you about before PIN_HIGH.
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Applied to drm-misc, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-25 8:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-16 3:02 [PATCH] drm/mm: Do DRM_MM_CREATE_TOP adj_start calculation after color_adjust Michel Thierry
2015-08-16 7:52 ` Chris Wilson
2015-08-25 8:24 ` Daniel Vetter [this message]
2015-08-16 20:42 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150825082453.GR20434@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=michel.thierry@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox