From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mike Frysinger <vapier@gentoo.org>
Subject: Re: [PATCH v4 1/5] drm: Add config for detecting libdrm
Date: Tue, 25 Aug 2015 17:09:29 -0400
Message-ID: <20150825210929.GC12316@vapier>
References: <1440420170-13337-1-git-send-email-patrik.jakobsson@linux.intel.com>
 <1440420170-13337-2-git-send-email-patrik.jakobsson@linux.intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0115498755=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from smtp.gentoo.org (smtp.gentoo.org [140.211.166.183])
 by gabe.freedesktop.org (Postfix) with ESMTPS id E802A6E0B3
 for <intel-gfx@lists.freedesktop.org>; Tue, 25 Aug 2015 14:09:31 -0700 (PDT)
In-Reply-To: <1440420170-13337-2-git-send-email-patrik.jakobsson@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: strace development list <strace-devel@lists.sourceforge.net>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org


--===============0115498755==
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Pk6IbRAofICFmK5e"
Content-Disposition: inline


--Pk6IbRAofICFmK5e
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline

On 24 Aug 2015 14:42, Patrik Jakobsson wrote:
> +PKG_CHECK_MODULES([LIBDRM], [libdrm],
> +		  [CPPFLAGS="$CPPFLAGS $LIBDRM_CFLAGS"
> +		   AC_CHECK_HEADERS([drm.h i915_drm.h])],
> +		  [AC_CHECK_HEADERS([drm/drm.h drm/i915_drm.h])])

i would make the drm/xxx headers unconditional -- add them to the big
block that does:
AC_CHECK_HEADERS(m4_normalize([
	...
]))

otherwise seems fine
-mike

--Pk6IbRAofICFmK5e
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJV3NmJAAoJEEFjO5/oN/WB5cMQAOUGAqcoGwbPurtM6pjLczrz
aVJqCfa8lqeOHplelxhb/QLerVxaVqWBtm4E4iFHA1POW2ep2VLlBYWgEA4ql8DO
gF8tE+lz62gasUMXNI5IDEBHNj1R7qhIz9hB6NOQEgiuN+a34U/sNjr+1A/zObJL
DJR6w8bYeXUMe4QuPSMb5rvhuQNKKIKjWr+0j/t9kMyIi0qkOXDdDsH2lEo1pCeq
PRDjXbSEUvGyyTGFr9M/2jLrop+/d6l+TPbfI2M8cv/E/JNDBi6o3ZEBeuQ1t4Qq
QlkkKqx+SFoKnpiYCNx3te66KRqX/IckouSVebnTxZuu9/3PTRSvx9VmTiQa8TyH
oYEAW8CygP7AT6gybAR2v0///Eug9zg8M+hPju1ot1rmcD+kvUQxtjmXtehbay8d
CKQjT2ILL+VidJtWkRnSnqooH3ILzmGt13/rmF4lejSVBFYMueeCi36nL/XvMXz5
uxc7qYm1MiKMnbwXHYHriMz5PKZHlLEe75Qt9+cscctoueOc4MgMkUS/euMti7UG
6Q0QbOLCGCMufnf5l0FAJEKCImwum+bU0ZcSXtwTM8UKJ4htue1AKTHBTKIrhnS7
98Ty0lBUslfm2XMr5jSCPLUu1Q0sokaf28qx1Z1dbqePBfiSs8FUu/mziK2ZWW0O
JjkeLhrioA6LFp+anbFB
=yOSk
-----END PGP SIGNATURE-----

--Pk6IbRAofICFmK5e--

--===============0115498755==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK

--===============0115498755==--