From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Imre Deak <imre.deak@intel.com>,
intel-gfx@lists.freedesktop.org,
Mika Kuoppala <mika.kuoppala@intel.com>,
Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v3 2/2] drm/i915/bxt: don't allow cached GEM mappings on A stepping
Date: Wed, 26 Aug 2015 09:13:53 +0200 [thread overview]
Message-ID: <20150826071353.GP20434@phenom.ffwll.local> (raw)
In-Reply-To: <20150814161827.GG27217@nuc-i3427.alporthouse.com>
On Fri, Aug 14, 2015 at 05:18:27PM +0100, Chris Wilson wrote:
> On Fri, Aug 14, 2015 at 06:43:30PM +0300, Imre Deak wrote:
> > Due to a coherency issue on BXT A steppings we can't guarantee a
> > coherent view of cached (CPU snooped) GPU mappings, so fail such
> > requests. User space is supposed to fall back to uncached mappings in
> > this case.
> >
> > v2:
> > - limit the WA to A steppings, on later stepping this HW issue is fixed
> > v3:
> > - return error instead of trying to work around the issue in kernel,
> > since that could confuse user space (Chris)
> >
> > Testcast: igt/gem_store_dword_batches_loop/cached-mapping
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
>
> I checked in the two userspaces where I have used snooping that both
> handle an error correctly, so
>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Both patches applied, thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-26 7:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 12:38 [PATCH v2 0/2] drm/i915/bxt: work around HW coherency issue Imre Deak
2015-08-14 12:38 ` [PATCH v2 1/2] drm/i915/bxt: work around HW coherency issue when accessing GPU seqno Imre Deak
2015-08-14 13:12 ` Chris Wilson
2015-08-14 13:31 ` Imre Deak
2015-08-14 15:35 ` [PATCH v3 " Imre Deak
2015-08-14 16:21 ` Chris Wilson
2015-08-14 12:38 ` [PATCH v2 2/2] drm/i915/bxt: work around HW coherency issue for cached GEM mappings Imre Deak
2015-08-14 13:11 ` Chris Wilson
2015-08-14 13:29 ` Imre Deak
2015-08-14 15:43 ` [PATCH v3 2/2] drm/i915/bxt: don't allow cached GEM mappings on A stepping Imre Deak
2015-08-14 16:18 ` Chris Wilson
2015-08-26 7:13 ` Daniel Vetter [this message]
2015-08-16 11:45 ` [PATCH v2 2/2] drm/i915/bxt: work around HW coherency issue for cached GEM mappings shuang.he
2015-08-14 12:49 ` [PATCH v2 0/2] drm/i915/bxt: work around HW coherency issue Chris Wilson
2015-08-14 13:26 ` Imre Deak
2015-08-14 13:31 ` Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826071353.GP20434@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=mika.kuoppala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox