From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Nick Hoath <nicholas.hoath@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"daniel.vetter@ffwll.ch" <daniel.vetter@ffwll.ch>
Subject: Re: [PATCH] drm/i915: Split alloc from init for lrc
Date: Wed, 26 Aug 2015 10:32:01 +0200 [thread overview]
Message-ID: <20150826083201.GD20434@phenom.ffwll.local> (raw)
In-Reply-To: <20150818150617.GI8742@nuc-i3427.alporthouse.com>
On Tue, Aug 18, 2015 at 04:06:17PM +0100, Chris Wilson wrote:
> On Tue, Aug 18, 2015 at 03:55:07PM +0100, Nick Hoath wrote:
> > >This is the wrong location. Just kill set_seqno, the experiment has run
> > >its course and we now have a n igt to exercise seqno wraparound.
> > It has to be here as the seqno has to be initialised before it is
> > used to create requests for the initialisation.
>
> It is the wrong location as init_hw() is called as part of resume and
> reset, both times where we don't want to actually touch seqno.
Hm I thought it also makes sure to update the hws to avoid the driver
getting confused, which is probably something we should be doing on resume
(since the hws is in stolen) because hibernate.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-26 8:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 14:23 [PATCH] drm/i915: Split alloc from init for lrc Nick Hoath
2015-08-18 14:31 ` Chris Wilson
2015-08-18 14:55 ` Nick Hoath
2015-08-18 15:06 ` Chris Wilson
2015-08-26 8:32 ` Daniel Vetter [this message]
2015-08-26 8:49 ` Chris Wilson
2015-08-28 8:12 ` shuang.he
-- strict thread matches above, loose matches on Subject: below --
2015-08-19 12:24 Nick Hoath
2015-08-19 12:37 ` Chris Wilson
2015-08-19 14:40 ` Nick Hoath
2015-08-28 13:25 ` shuang.he
2015-09-04 13:49 Nick Hoath
2015-09-09 13:54 ` Daniel, Thomas
2015-09-10 13:32 Nick Hoath
2015-09-11 11:53 Nick Hoath
2015-09-11 13:09 ` Daniel, Thomas
2015-09-21 10:25 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826083201.GD20434@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=nicholas.hoath@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox