From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rob Clark <robdclark@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Daniel Stone <daniels@collabora.com>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/atomic: refuse changing CRTC for planes directly
Date: Wed, 26 Aug 2015 20:53:10 +0300 [thread overview]
Message-ID: <20150826175310.GW5176@intel.com> (raw)
In-Reply-To: <CAF6AEGv2XwVfkWL4qJVHd7C4gy1LDH3NT9VcOp7UzJX6zCmbyg@mail.gmail.com>
On Wed, Aug 26, 2015 at 01:38:36PM -0400, Rob Clark wrote:
> On Wed, Aug 26, 2015 at 12:30 PM, Ville Syrjälä
> <ville.syrjala@linux.intel.com> wrote:
> > On Wed, Aug 26, 2015 at 12:07:30PM -0400, Rob Clark wrote:
> >> On Wed, Aug 26, 2015 at 12:03 PM, Rob Clark <robdclark@gmail.com> wrote:
> >> > On Wed, Aug 26, 2015 at 11:41 AM, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> >> >> Very strictly speaking this is possible if you have special hw and
> >> >> genlocked CRTCs. In general switching a plane between two active CRTC
> >> >> just won't work so well and is probably not tested at all. Just forbid
> >> >> it.
> >> >
> >> > So, I expect msm should actually be able to do this w/ dual-dsi (where
> >> > we are using two CRTC's, w/ synchronized flushes)..
> >> >
> >> > Probably someone who has a dual-dsi panel should actually test that to
> >> > confirm. But it seems like it should work. Maybe we need something
> >> > in 'struct drm_crtc' so core can realize that two CRTC's are locked
> >> > together..
> >>
> >> oh, and for most drivers, switching plane between CRTCs without an
> >> off-cycle would probably also work for DSI cmd mode..
> >
> > You'd need to wait for any ongoing transfer on the old crtc to finish
> > before moving the plane. So that's not really any different than the
> > driver doing the dance with a vblank wait on a video mode display.
>
> except that update would need to block from previous xfer anyways, so
> there isn't really a race w/ frame n+1 like there would be with video
> mode..
Why would it block if it's on a separate crtc?
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-08-26 17:53 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 12:01 [PATCH 1/3] drm/atomic-helper: Add option to update planes only on active crtc Daniel Vetter
2015-07-29 12:01 ` [PATCH 2/3] drm/rcar: Only update planes " Daniel Vetter
2015-07-29 12:01 ` [PATCH 3/3] drm/atomic: refuse changing CRTC for planes while active Daniel Vetter
2015-07-30 10:37 ` shuang.he
2015-08-26 15:41 ` [PATCH] drm/atomic: refuse changing CRTC for planes directly Daniel Vetter
2015-08-26 15:53 ` [Intel-gfx] " Ville Syrjälä
2015-08-26 16:33 ` Daniel Stone
2015-08-26 16:03 ` Rob Clark
2015-08-26 16:07 ` Rob Clark
2015-08-26 16:30 ` Ville Syrjälä
2015-08-26 17:38 ` Rob Clark
2015-08-26 17:53 ` Ville Syrjälä [this message]
2015-08-26 17:58 ` Rob Clark
2015-08-26 19:49 ` Daniel Vetter
2015-08-26 21:51 ` [Intel-gfx] " Rob Clark
2015-08-27 7:45 ` Daniel Vetter
2015-08-27 6:08 ` Maarten Lankhorst
2015-08-31 2:12 ` shuang.he
2015-08-30 21:46 ` shuang.he
2015-07-30 16:28 ` [PATCH 1/3] drm/atomic-helper: Add option to update planes only on active crtc Maarten Lankhorst
2015-08-26 14:02 ` [PATCH] " Daniel Vetter
2015-09-08 10:02 ` Daniel Vetter
2015-09-08 11:10 ` Thierry Reding
2015-09-08 11:50 ` Daniel Vetter
2015-09-08 11:27 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150826175310.GW5176@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=robdclark@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).