From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v2 3/3] drm/i915/dp: move TPS3 logic to where it's used Date: Thu, 27 Aug 2015 15:15:07 +0300 Message-ID: <20150827121507.GA5176@intel.com> References: <1440671138-17174-1-git-send-email-jani.nikula@intel.com> <1440671138-17174-3-git-send-email-jani.nikula@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id C55126ECCD for ; Thu, 27 Aug 2015 05:15:25 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1440671138-17174-3-git-send-email-jani.nikula@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBdWcgMjcsIDIwMTUgYXQgMDE6MjU6MzhQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gVGhlcmUgaXMgbm8gbmVlZCB0byBoYXZlIGEgc2VwYXJhdGUgZmxhZyBmb3IgdHBzMyBh cyB0aGUgaW5mb3JtYXRpb24gaXMKPiBvbmx5IHVzZWQgYXQgb25lIGxvY2F0aW9uLiBNb3ZlIHRo ZSBsb2dpYyB0aGVyZSB0byBtYWtlIGl0IGVhc2llciB0bwo+IGZvbGxvdy4KPiAKPiBTaWduZWQt b2ZmLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IC0tLQo+ICBkcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jICB8IDMxICsrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggfCAgMSAtCj4gIDIg ZmlsZXMgY2hhbmdlZCwgMTcgaW5zZXJ0aW9ucygrKSwgMTUgZGVsZXRpb25zKC0pCj4gCj4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kcC5jCj4gaW5kZXggNTBiYTUyNzc2M2U5Li4xMmJjZTM2MDY1YTEgMTAw NjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiBAQCAtMzg0OCwxMyArMzg0OCwyNSBAQCBpbnRl bF9kcF9zdGFydF9saW5rX3RyYWluKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIHZvaWQK PiAgaW50ZWxfZHBfY29tcGxldGVfbGlua190cmFpbihzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw KQo+ICB7Cj4gKwlzdHJ1Y3QgaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCA9IGRwX3RvX2Rp Z19wb3J0KGludGVsX2RwKTsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBkaWdfcG9ydC0+ YmFzZS5iYXNlLmRldjsKPiAgCWJvb2wgY2hhbm5lbF9lcSA9IGZhbHNlOwo+ICAJaW50IHRyaWVz LCBjcl90cmllczsKPiAgCXVpbnQzMl90IERQID0gaW50ZWxfZHAtPkRQOwo+ICAJdWludDMyX3Qg dHJhaW5pbmdfcGF0dGVybiA9IERQX1RSQUlOSU5HX1BBVFRFUk5fMjsKPiAgCj4gLQkvKiBUcmFp bmluZyBQYXR0ZXJuIDMgZm9yIEhCUjIgb3IgMS4yIGRldmljZXMgdGhhdCBzdXBwb3J0IGl0Ki8K PiAtCWlmIChpbnRlbF9kcC0+bGlua19yYXRlID09IDU0MDAwMCB8fCBpbnRlbF9kcC0+dXNlX3Rw czMpCj4gKwkvKgo+ICsJICogVHJhaW5pbmcgUGF0dGVybiAzIGZvciBIQlIyIG9yIDEuMiBkZXZp Y2VzIHRoYXQgc3VwcG9ydCBpdC4KPiArCSAqCj4gKwkgKiBJbnRlbCBwbGF0Zm9ybXMgdGhhdCBz dXBwb3J0IEhCUjIgYWxzbyBzdXBwb3J0IFRQUzMuIFRQUzMgc3VwcG9ydCBpcwo+ICsJICogYWxz byBtYW5kYXRvcnkgZm9yIGRvd25zdHJlYW0gZGV2aWNlcyB0aGF0IHN1cHBvcnQgSEJSMi4KPiAr CSAqCj4gKwkgKiBEdWUgdG8gV2FEaXNhYmxlSEJSMiBTS0wgPCBCMCBpcyB0aGUgb25seSBleGNl cHRpb24gd2hlcmUgVFBTMyBpcwo+ICsJICogc3VwcG9ydGVkIGJ1dCBzdGlsbCBub3QgZW5hYmxl ZC4KPiArCSAqLwo+ICsJaWYgKGludGVsX2RwLT5saW5rX3JhdGUgPT0gNTQwMDAwIHx8Cj4gKwkg ICAgKGludGVsX2RwX3NvdXJjZV9zdXBwb3J0c19oYnIyKGRldikgJiYKPiArCSAgICAgaW50ZWxf ZHBfdHBzM19zdXBwb3J0ZWQoaW50ZWxfZHAtPmRwY2QpKSkKCkknbSB0aGlua2luZyB3ZSBjb3Vs ZCBqdXN0IGtpbGwgdGhlIGxpbmtfcmF0ZSBjaGVjayBoZXJlLiBJdCB3b3VsZApvbmx5IG1ha2Ug YSBkaWZmZXJlbmNlIGlmIHRoZSBzaW5rIGxpZWQgaW4gaXRzIERQQ0QuCgo+ICAJCXRyYWluaW5n X3BhdHRlcm4gPSBEUF9UUkFJTklOR19QQVRURVJOXzM7Cj4gIAo+ICAJLyogY2hhbm5lbCBlcXVh bGl6YXRpb24gKi8KPiBAQCAtNDAzNiwxOCArNDA0OCw5IEBAIGludGVsX2RwX2dldF9kcGNkKHN0 cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApCj4gIAkJfQo+ICAJfQo+ICAKPiAtCS8qIFRyYWluaW5n IFBhdHRlcm4gMyBzdXBwb3J0LCBJbnRlbCBwbGF0Zm9ybXMgdGhhdCBzdXBwb3J0IEhCUjIgYWxv bmUKPiAtCSAqIGhhdmUgc3VwcG9ydCBmb3IgVFAzIGhlbmNlIHRoYXQgY2hlY2sgaXMgdXNlZCBh bG9uZyB3aXRoIGRwY2QgY2hlY2sKPiAtCSAqIHRvIGVuc3VyZSBUUDMgY2FuIGJlIGVuYWJsZWQu Cj4gLQkgKiBTS0wgPCBCMDogZHVlIGl0J3MgV2FEaXNhYmxlSEJSMiBpcyB0aGUgb25seSBleGNl cHRpb24gd2hlcmUgVFAzIGlzCj4gLQkgKiBzdXBwb3J0ZWQgYnV0IHN0aWxsIG5vdCBlbmFibGVk Lgo+IC0JICovCj4gLQlpZiAoaW50ZWxfZHBfdHBzM19zdXBwb3J0ZWQoaW50ZWxfZHAtPmRwY2Qp ICYmCj4gLQkgICAgaW50ZWxfZHBfc291cmNlX3N1cHBvcnRzX2hicjIoZGV2KSkgewo+IC0JCWlu dGVsX2RwLT51c2VfdHBzMyA9IHRydWU7Cj4gLQkJRFJNX0RFQlVHX0tNUygiRGlzcGxheXBvcnQg VFBTMyBzdXBwb3J0ZWRcbiIpOwo+IC0JfSBlbHNlCj4gLQkJaW50ZWxfZHAtPnVzZV90cHMzID0g ZmFsc2U7Cj4gKwlEUk1fREVCVUdfS01TKCJEaXNwbGF5IFBvcnQgVFBTMyBzdXBwb3J0OiBzb3Vy Y2UgJXMsIHNpbmsgJXNcbiIsCj4gKwkJICAgICAgaW50ZWxfZHBfc291cmNlX3N1cHBvcnRzX2hi cjIoZGV2KSA/ICJ5ZXMiIDogIm5vIiwKPiArCQkgICAgICBpbnRlbF9kcF90cHMzX3N1cHBvcnRl ZChpbnRlbF9kcC0+ZHBjZCkgPyAieWVzIiA6ICJubyIpOwoKSSBndWVzcyB3ZSBkb24ndCBoYXZl IGEgb25lIHRydWUgeWVzbm8oKSBtYWNyby4gSSB0aGluayB3ZSBoYXZlIHN1Y2gKdGhpbmdzIGlu IHNwZWNpZmljIGZpbGVzLiBNYXliZSBtYWtlIGl0IGF2YWlsYWJsZSBldmVyeXdoZXJlPwoKQnV0 IGFueXdheSwgdGhvc2UgYXJlIGp1c3QgZm9vZCBmb3IgdGhvdWdodCwgYW5kIHRoZSBzZXJpZXMg bG9va3MgZ29vZApzbwpSZXZpZXdlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KCj4gIAo+ICAJLyogSW50ZXJtZWRpYXRlIGZyZXF1ZW5jeSBzdXBw b3J0ICovCj4gIAlpZiAoaXNfZWRwKGludGVsX2RwKSAmJgo+IGRpZmYgLS1naXQgYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Ry di5oCj4gaW5kZXggYzYxYmE0N2VkYTdjLi5mYTk4NDBmYmNjYmEgMTAwNjQ0Cj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9kcnYuaAo+IEBAIC03NDQsNyArNzQ0LDYgQEAgc3RydWN0IGludGVsX2RwIHsKPiAg CWVudW0gcGlwZSBwcHNfcGlwZTsKPiAgCXN0cnVjdCBlZHBfcG93ZXJfc2VxIHBwc19kZWxheXM7 Cj4gIAo+IC0JYm9vbCB1c2VfdHBzMzsKPiAgCWJvb2wgY2FuX21zdDsgLyogdGhpcyBwb3J0IHN1 cHBvcnRzIG1zdCAqLwo+ICAJYm9vbCBpc19tc3Q7Cj4gIAlpbnQgYWN0aXZlX21zdF9saW5rczsK PiAtLSAKPiAyLjEuNAo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=