From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH] drm/i915: Fix module initialisation, v2. Date: Mon, 31 Aug 2015 15:13:41 -0700 Message-ID: <20150831221341.GY13406@intel.com> References: <55D1B0C6.3030906@linux.intel.com> <20150826075150.GU20434@phenom.ffwll.local> <55DD7179.208@linux.intel.com> <20150826081208.GY20434@phenom.ffwll.local> <55DF0D63.9000308@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 33BE76E427 for ; Mon, 31 Aug 2015 15:13:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: <55DF0D63.9000308@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBBdWcgMjcsIDIwMTUgYXQgMDM6MTU6MTVQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gU2V0IERSSVZFUl9NT0RFU0VUIGFuZCBEUklWRVJfQVRPTUlDIGJ5IGRlZmF1 bHQuIFRoZSBkcml2ZXIgaXMgZnVsbHkgYXRvbWljLgo+IFJlbW92ZSB0aGUgbGVnYWN5IHN1c3Bl bmQvcmVzdW1lLCB0byBmaXggYSB3YXJuaW5nIGludHJvZHVjZWQgYnk6Cj4gCj4gImRybTogV0FS Tl9PTiBpZiBhIG1vZGVzZXQgZHJpdmVyIHVzZXMgbGVnYWN5IHN1c3BlbmQvcmVzdW1lIGhlbHBl cnMiCj4gCj4gYW5kIHJlbW92aW5nIHRoZSAuZ2V0X3ZibGFua190aW1lc3RhbXAgcmVzZXQgdG8g TlVMTC4gSXQncyBhIG5vb3Agd2l0aG91dCBVTVMuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFhcnRl biBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNvbT4KClJldmlld2Vk LWJ5OiBNYXR0IFJvcGVyIDxtYXR0aGV3LmQucm9wZXJAaW50ZWwuY29tPgoKPiAtLS0KPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYyBiL2RyaXZlcnMvZ3B1L2Ry bS9pOTE1L2k5MTVfZG1hLmMKPiBpbmRleCAwOTdkNGJhMDQyMWMuLmYwZWFhNmY4ODI2YiAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RtYS5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9kbWEuYwo+IEBAIC0zNjQsMTIgKzM2NCwxMiBAQCBzdGF0aWMg dm9pZCBpOTE1X3N3aXRjaGVyb29fc2V0X3N0YXRlKHN0cnVjdCBwY2lfZGV2ICpwZGV2LCBlbnVt IHZnYV9zd2l0Y2hlcm9vXwo+ICAJCWRldi0+c3dpdGNoX3Bvd2VyX3N0YXRlID0gRFJNX1NXSVRD SF9QT1dFUl9DSEFOR0lORzsKPiAgCQkvKiBpOTE1IHJlc3VtZSBoYW5kbGVyIGRvZXNuJ3Qgc2V0 IHRvIEQwICovCj4gIAkJcGNpX3NldF9wb3dlcl9zdGF0ZShkZXYtPnBkZXYsIFBDSV9EMCk7Cj4g LQkJaTkxNV9yZXN1bWVfbGVnYWN5KGRldik7Cj4gKwkJaTkxNV9yZXN1bWVfc3dpdGNoZXJvbyhk ZXYpOwo+ICAJCWRldi0+c3dpdGNoX3Bvd2VyX3N0YXRlID0gRFJNX1NXSVRDSF9QT1dFUl9PTjsK PiAgCX0gZWxzZSB7Cj4gIAkJcHJfZXJyKCJzd2l0Y2hlZCBvZmZcbiIpOwo+ICAJCWRldi0+c3dp dGNoX3Bvd2VyX3N0YXRlID0gRFJNX1NXSVRDSF9QT1dFUl9DSEFOR0lORzsKPiAtCQlpOTE1X3N1 c3BlbmRfbGVnYWN5KGRldiwgcG1tKTsKPiArCQlpOTE1X3N1c3BlbmRfc3dpdGNoZXJvbyhkZXYs IHBtbSk7Cj4gIAkJZGV2LT5zd2l0Y2hfcG93ZXJfc3RhdGUgPSBEUk1fU1dJVENIX1BPV0VSX09G RjsKPiAgCX0KPiAgfQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Ry di5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuYwo+IGluZGV4IGNlM2JkMGM3MTNi OS4uNDY0NmZlMWEwNDk5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf ZHJ2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5jCj4gQEAgLTY3OSw3 ICs2NzksNyBAQCBzdGF0aWMgaW50IGk5MTVfZHJtX3N1c3BlbmRfbGF0ZShzdHJ1Y3QgZHJtX2Rl dmljZSAqZHJtX2RldiwgYm9vbCBoaWJlcm5hdGlvbikKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ IC1pbnQgaTkxNV9zdXNwZW5kX2xlZ2FjeShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBwbV9tZXNz YWdlX3Qgc3RhdGUpCj4gK2ludCBpOTE1X3N1c3BlbmRfc3dpdGNoZXJvbyhzdHJ1Y3QgZHJtX2Rl dmljZSAqZGV2LCBwbV9tZXNzYWdlX3Qgc3RhdGUpCj4gIHsKPiAgCWludCBlcnJvcjsKPiAgCj4g QEAgLTgxMiw3ICs4MTIsNyBAQCBzdGF0aWMgaW50IGk5MTVfZHJtX3Jlc3VtZV9lYXJseShzdHJ1 Y3QgZHJtX2RldmljZSAqZGV2KQo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAKPiAtaW50IGk5MTVf cmVzdW1lX2xlZ2FjeShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICtpbnQgaTkxNV9yZXN1bWVf c3dpdGNoZXJvbyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+ICB7Cj4gIAlpbnQgcmV0Owo+ICAK PiBAQCAtMTY0OSw3ICsxNjQ5LDcgQEAgc3RhdGljIHN0cnVjdCBkcm1fZHJpdmVyIGRyaXZlciA9 IHsKPiAgCSAqLwo+ICAJLmRyaXZlcl9mZWF0dXJlcyA9Cj4gIAkgICAgRFJJVkVSX0hBVkVfSVJR IHwgRFJJVkVSX0lSUV9TSEFSRUQgfCBEUklWRVJfR0VNIHwgRFJJVkVSX1BSSU1FIHwKPiAtCSAg ICBEUklWRVJfUkVOREVSLAo+ICsJICAgIERSSVZFUl9SRU5ERVIgfCBEUklWRVJfTU9ERVNFVCwK PiAgCS5sb2FkID0gaTkxNV9kcml2ZXJfbG9hZCwKPiAgCS51bmxvYWQgPSBpOTE1X2RyaXZlcl91 bmxvYWQsCj4gIAkub3BlbiA9IGk5MTVfZHJpdmVyX29wZW4sCj4gQEAgLTE2NTgsMTAgKzE2NTgs NiBAQCBzdGF0aWMgc3RydWN0IGRybV9kcml2ZXIgZHJpdmVyID0gewo+ICAJLnBvc3RjbG9zZSA9 IGk5MTVfZHJpdmVyX3Bvc3RjbG9zZSwKPiAgCS5zZXRfYnVzaWQgPSBkcm1fcGNpX3NldF9idXNp ZCwKPiAgCj4gLQkvKiBVc2VkIGluIHBsYWNlIG9mIGk5MTVfcG1fb3BzIGZvciBub24tRFJJVkVS X01PREVTRVQgKi8KPiAtCS5zdXNwZW5kID0gaTkxNV9zdXNwZW5kX2xlZ2FjeSwKPiAtCS5yZXN1 bWUgPSBpOTE1X3Jlc3VtZV9sZWdhY3ksCj4gLQo+ICAjaWYgZGVmaW5lZChDT05GSUdfREVCVUdf RlMpCj4gIAkuZGVidWdmc19pbml0ID0gaTkxNV9kZWJ1Z2ZzX2luaXQsCj4gIAkuZGVidWdmc19j bGVhbnVwID0gaTkxNV9kZWJ1Z2ZzX2NsZWFudXAsCj4gQEAgLTE3MDQsNyArMTcwMCw2IEBAIHN0 YXRpYyBpbnQgX19pbml0IGk5MTVfaW5pdCh2b2lkKQo+ICAJICogZWl0aGVyIHRoZSBpOTE1Lm1v ZGVzZXQgcHJhcmFtZXRlciBvciBieSB0aGUKPiAgCSAqIHZnYV90ZXh0X21vZGVfZm9yY2UgYm9v dCBvcHRpb24uCj4gIAkgKi8KPiAtCWRyaXZlci5kcml2ZXJfZmVhdHVyZXMgfD0gRFJJVkVSX01P REVTRVQ7Cj4gIAo+ICAJaWYgKGk5MTUubW9kZXNldCA9PSAwKQo+ICAJCWRyaXZlci5kcml2ZXJf ZmVhdHVyZXMgJj0gfkRSSVZFUl9NT0RFU0VUOwo+IEBAIC0xNzE1LDE3ICsxNzEwLDExIEBAIHN0 YXRpYyBpbnQgX19pbml0IGk5MTVfaW5pdCh2b2lkKQo+ICAjZW5kaWYKPiAgCj4gIAlpZiAoIShk cml2ZXIuZHJpdmVyX2ZlYXR1cmVzICYgRFJJVkVSX01PREVTRVQpKSB7Cj4gLQkJZHJpdmVyLmdl dF92YmxhbmtfdGltZXN0YW1wID0gTlVMTDsKPiAgCQkvKiBTaWxlbnRseSBmYWlsIGxvYWRpbmcg dG8gbm90IHVwc2V0IHVzZXJzcGFjZS4gKi8KPiAgCQlEUk1fREVCVUdfRFJJVkVSKCJLTVMgYW5k IFVNUyBkaXNhYmxlZC5cbiIpOwo+ICAJCXJldHVybiAwOwo+ICAJfQo+ICAKPiAtCS8qCj4gLQkg KiBGSVhNRTogTm90ZSB0aGF0IHdlJ3JlIGx5aW5nIHRvIHRoZSBEUk0gY29yZSBoZXJlIHNvIHRo YXQgd2UgY2FuIGdldCBhY2Nlc3MKPiAtCSAqIHRvIHRoZSBhdG9taWMgaW9jdGwgYW5kIHRoZSBh dG9taWMgcHJvcGVydGllcy4gIE9ubHkgcGxhbmUgb3BlcmF0aW9ucyBvbgo+IC0JICogYSBzaW5n bGUgQ1JUQyB3aWxsIGFjdHVhbGx5IHdvcmsuCj4gLQkgKi8KPiAgCWlmIChpOTE1Lm51Y2xlYXJf cGFnZWZsaXApCj4gIAkJZHJpdmVyLmRyaXZlcl9mZWF0dXJlcyB8PSBEUklWRVJfQVRPTUlDOwo+ ICAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaCBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2k5MTVfZHJ2LmgKPiBpbmRleCA4YzkzODQ1MWEwNWUuLjVjMjU0MWRk ZjIxMiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+IEBAIC0yNjA3LDggKzI2MDcsOCBA QCBzdHJ1Y3QgZHJtX2k5MTVfY21kX3RhYmxlIHsKPiAgZXh0ZXJuIGNvbnN0IHN0cnVjdCBkcm1f aW9jdGxfZGVzYyBpOTE1X2lvY3Rsc1tdOwo+ICBleHRlcm4gaW50IGk5MTVfbWF4X2lvY3RsOwo+ ICAKPiAtZXh0ZXJuIGludCBpOTE1X3N1c3BlbmRfbGVnYWN5KHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYsIHBtX21lc3NhZ2VfdCBzdGF0ZSk7Cj4gLWV4dGVybiBpbnQgaTkxNV9yZXN1bWVfbGVnYWN5 KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpOwo+ICtleHRlcm4gaW50IGk5MTVfc3VzcGVuZF9zd2l0 Y2hlcm9vKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHBtX21lc3NhZ2VfdCBzdGF0ZSk7Cj4gK2V4 dGVybiBpbnQgaTkxNV9yZXN1bWVfc3dpdGNoZXJvbyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KTsK PiAgCj4gIC8qIGk5MTVfcGFyYW1zLmMgKi8KPiAgc3RydWN0IGk5MTVfcGFyYW1zIHsKPiAKPiBf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+IEludGVsLWdm eCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCk1h dHQgUm9wZXIKR3JhcGhpY3MgU29mdHdhcmUgRW5naW5lZXIKSW9URyBQbGF0Zm9ybSBFbmFibGlu ZyAmIERldmVsb3BtZW50CkludGVsIENvcnBvcmF0aW9uCig5MTYpIDM1Ni0yNzk1Cl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5n IGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==