From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [DMC_BUGFIX_SKL_V2 4/5] drm/i915/skl: Do not disable cdclk PLL if csr firmware is present Date: Wed, 2 Sep 2015 10:58:28 +0200 Message-ID: <20150902085828.GI1367@phenom.ffwll.local> References: <1440533169-32265-1-git-send-email-animesh.manna@intel.com> <1440533169-32265-5-git-send-email-animesh.manna@intel.com> <20150826131159.GS1367@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAF796E05C for ; Wed, 2 Sep 2015 01:58:32 -0700 (PDT) Received: by wiclp12 with SMTP id lp12so11247153wic.1 for ; Wed, 02 Sep 2015 01:58:31 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Hindman, Gavin" Cc: "Bhardwaj, Rajneesh" , "intel-gfx@lists.freedesktop.org" , "Vetter, Daniel" List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCBBdWcgMzEsIDIwMTUgYXQgMDE6MDM6MDNBTSArMDAwMCwgSGluZG1hbiwgR2F2aW4g d3JvdGU6Cj4gVW5sZXNzIEknbSBtaXNyZWFkaW5nIHRoYXQgd291bGQgaW1wbHkgdGhhdCB3ZSBh cmUgbW92aW5nIGF3YXkgZnJvbSBvdXIKPiBwcmV2aW91cyBwb3NpdGlvbiB0aGF0IERNQyBGVyBp cyBvcHRpb25hbCwgY29ycmVjdD8gICAgV291bGQgdGhpcyBub3QKPiByZW5kZXIgcG93ZXItc2Vx dWVuY2luZyBicm9rZW4gaWYgYSBkaXN0cm8gY2hvc2Ugbm90IHRvIGluY2x1ZGUgRE1DIEZXPwoK Rm9yIHVwc3RyZWFtIHdlIG5ldmVyIGhhZCB0aGUgc3RhbmNlIChhbmQgSSB3b3VsZG4ndCBhY2Nl cHQgdGhlIHBhdGNoZXMKcmVhbGx5IHdpdGhvdXQgYSByZWFsbHkgZ29vZCByZWFzb24pIHRoYXQg d2UnbGwgc3VwcG9ydCBydW50aW1lIHBtIHdpdGhvdXQKRE1DIGZpcm13YXJlLgoKV2UgYWxyZWFk eSBoYXZlIGEgcmVhbGx5IGJhZCB0aW1lIGp1c3QgdHJ5aW5nIHRvIGtlZXAgdGhpbmdzIHdvcmtp bmcgaW4gMQpjb25maWd1cmF0aW9uICh0aGVyZSdzIGEgcGF0Y2ggZnJvbSBtZSB0byBlbmFibGUg cnVudGltZSBwbSBieSBkZWZhdWx0CmJsb2NrZWQgb24gdW5maXhlZCByZWdyZXNzaW9ucyB3aGlj aCBhcmUgb3BlbiBzaW5jZSBtb250aHMgYW5kIG5vIG9uZSdzCndvcmtpbmcgb24gdGhlbSksIHdl IGFic29sdXRlbHkgZG9uJ3QgaGF2ZSB0aGUgcmVzb3VyY2VzIHRvIHN1cHBvcnQgYW55CmNyYXp5 IGNvbmZpZ3VyYXRpb25zIHRoYXQncyB0aGVvcmV0aWNhbGx5IHBvc3NpYmxlLiBJZiBhIGRpc3Ry byB3b24ndAppbmNsdWRlIERNQyB0aGVuIHRoZXkgd29uJ3QgZ2V0IHByb3BlciBydW50aW1lIHBt IGFuZCB0aGF0J3MgaXQuCgpZZXMgdGhlIG9yaWdpbmFsIERNQyBwYXRjaGVzIChhbmQgdGhlIGNv ZGUgc3RpbGwgaW4gdHJlZSkgaGFkIGNvZGUgdG8KaGFuZGxlIHRoYXQgY2FzZSwgYnV0IGZvbGxv dy11cCBwYXRjaGVzIHJpcCB0aGF0IGNvbXBsZXhpdHkgb3V0LgoKSWYgd2UgYXJlIGluIHBvc2l0 aW9uIHdoZXJlIHdlIGNhbiBhY3R1YWxseSBzaGlwIGFsbCB0aGUgcG93ZXIgZmVhdHVyZXMgd2UK ZGV2ZWxvcCB0aGVuIHdlIGNvdWxkIGNvbnNpZGVyIHN1cHBvcnRpbmcgbW9yZSBjb21iaW5hdGlv bnMgb2YgZmVhdHVyZXMsCmJ1dCByaWdodCBub3cgSSB0aGluayB0aGF0J3MgaW4gdGhlIHZlcnkg ZGlzdGFudCBmdXR1cmUuCgpUaGFua3MsIERhbmllbAoKPiAKPiBHYXZpbiBIaW5kbWFuCj4gU2Vu aW9yIFByb2dyYW0gTWFuYWdlcgo+IFNTRy9PVEMg4oCTIE9wZW4gU291cmNlIFRlY2hub2xvZ3kg Q2VudGVyCj4gCj4gCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiBGcm9tOiBJbnRlbC1n ZnggW21haWx0bzppbnRlbC1nZngtYm91bmNlc0BsaXN0cy5mcmVlZGVza3RvcC5vcmddIE9uIEJl aGFsZiBPZiBEYW5pZWwgVmV0dGVyCj4gU2VudDogV2VkbmVzZGF5LCBBdWd1c3QgMjYsIDIwMTUg NjoxMiBBTQo+IFRvOiBNYW5uYSwgQW5pbWVzaAo+IENjOiBCaGFyZHdhaiwgUmFqbmVlc2g7IGlu dGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmc7IFZldHRlciwgRGFuaWVsCj4gU3ViamVjdDog UmU6IFtJbnRlbC1nZnhdIFtETUNfQlVHRklYX1NLTF9WMiA0LzVdIGRybS9pOTE1L3NrbDogRG8g bm90IGRpc2FibGUgY2RjbGsgUExMIGlmIGNzciBmaXJtd2FyZSBpcyBwcmVzZW50Cj4gCj4gT24g V2VkLCBBdWcgMjYsIDIwMTUgYXQgMDE6MzY6MDhBTSArMDUzMCwgQW5pbWVzaCBNYW5uYSB3cm90 ZToKPiA+IFdoaWxlIGRpc3BsYXkgZW5naW5lIGVudGVyaW5nIGludG8gbG93IHBvd2VyIHN0YXRl IG5vIG5lZWQgdG8gZGlzYWJsZSAKPiA+IGNkY2xrIHBsbCBhcyBDU1IgZmlybXdhcmUgb2YgZG1j IHdpbGwgdGFrZSBjYXJlLiBJZiBwbGwgaXMgYWxyZWFkeSAKPiA+IGVuYWJsZWQgZmlybXdhcmUg ZXhlY3V0aW9uIHNlcXVlbmNlIHdpbGwgYmUgYmxvY2tlZC4gVGhpcyBpcyBvbmUgb2YgCj4gPiB0 aGUgY3JpdGVyaWEgZm9yIGRtYyB0byB3b3JrIHByb3Blcmx5Lgo+ID4gCj4gPiB2MTogSW5pdGlh bCB2ZXJzaW9uLgo+ID4gCj4gPiB2MjogQmFzZWQgb24gcmV2aWV3IGNvbW1lbnQgZnJvbSBEYW5p ZWwgYWRkZWQgY29kZSBjb21tbmVudC4KPiA+IAo+ID4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmll bC52ZXR0ZXJAaW50ZWwuY29tPgo+ID4gQ2M6IERhbWllbiBMZXNwaWF1IDxkYW1pZW4ubGVzcGlh dUBpbnRlbC5jb20+Cj4gPiBDYzogSW1yZSBEZWFrIDxpbXJlLmRlYWtAaW50ZWwuY29tPgo+ID4g Q2M6IFN1bmlsIEthbWF0aCA8c3VuaWwua2FtYXRoQGludGVsLmNvbT4KPiA+IFNpZ25lZC1vZmYt Ynk6IEFuaW1lc2ggTWFubmEgPGFuaW1lc2gubWFubmFAaW50ZWwuY29tPgo+ID4gU2lnbmVkLW9m Zi1idDogVmF0aHNhbGEgTmFnYXJhanUgPHZhdGhzYWxhLm5hZ2FyYWp1QGludGVsLmNvbT4KPiA+ IFNpZ25lZC1vZmYtYnk6IFJham5lZXNoIEJoYXJkd2FqIDxyYWpuZWVzaC5iaGFyZHdhakBpbnRl bC5jb20+Cj4gPiAtLS0KPiA+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMg fCAxNCArKysrKysrKysrLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAxMCBpbnNlcnRpb25zKCsp LCA0IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jIAo+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiA+IGluZGV4IGY2MDRjZTEuLmI2YmVmMjAgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gQEAgLTU2ODcsMTAgKzU2ODcsMTYgQEAgdm9pZCBza2xf dW5pbml0X2NkY2xrKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdikKPiA+ICAJaWYg KEk5MTVfUkVBRChEQlVGX0NUTCkgJiBEQlVGX1BPV0VSX1NUQVRFKQo+ID4gIAkJRFJNX0VSUk9S KCJEQnVmIHBvd2VyIGRpc2FibGUgdGltZW91dFxuIik7Cj4gPiAgCj4gPiAtCS8qIGRpc2FibGUg RFBMTDAgKi8KPiA+IC0JSTkxNV9XUklURShMQ1BMTDFfQ1RMLCBJOTE1X1JFQUQoTENQTEwxX0NU TCkgJiB+TENQTExfUExMX0VOQUJMRSk7Cj4gPiAtCWlmICh3YWl0X2ZvcighKEk5MTVfUkVBRChM Q1BMTDFfQ1RMKSAmIExDUExMX1BMTF9MT0NLKSwgMSkpCj4gPiAtCQlEUk1fRVJST1IoIkNvdWxk bid0IGRpc2FibGUgRFBMTDBcbiIpOwo+ID4gKwkvKgo+ID4gKwkgKiBETUMgYXNzdW1lcyBvd25l cnNoaXAgb2YgTENQTEwgYW5kIHdpbGwgZ2V0IGNvbmZ1c2VkIGlmIHdlIHRvdWNoIGl0Lgo+IAo+ IFRoaXMgc2hvdWxkIGdldCBhIEZJWE1FIC0gb25jZSB3ZSBoYXZlIGRtYyBsb2FkaW5nIGZpeGVk IHVwIHdlIHJlcXVpcmUgdGhlIGZpcm13YXJlIGFuZCB0aGVyZSdzIG5vIHBvaW50IGluIHRoaXMg Y2hlY2sgYW55IG1vcmUuIEZsZXhpYmlsdHkganVzdCBiZWNhdXNlIGlzIHNvbWV0aGluZyB3ZSBz aW1wbHkgZG9uJ3QgaGF2ZSB0aGUgZGV2ZWxvcGVyIGFuZCB2YWxpZGF0aW9uIHJlc291cmNlcyBm b3IuCj4gLURhbmllbAo+IAo+ID4gKwkgKi8KPiA+ICsJaWYgKGRldl9wcml2LT5jc3IuZG1jX3Bh eWxvYWQpIHsKPiA+ICsJCS8qIGRpc2FibGUgRFBMTDAgKi8KPiA+ICsJCUk5MTVfV1JJVEUoTENQ TEwxX0NUTCwgSTkxNV9SRUFEKExDUExMMV9DVEwpICYKPiA+ICsJCQkJCX5MQ1BMTF9QTExfRU5B QkxFKTsKPiA+ICsJCWlmICh3YWl0X2ZvcighKEk5MTVfUkVBRChMQ1BMTDFfQ1RMKSAmIExDUExM X1BMTF9MT0NLKSwgMSkpCj4gPiArCQkJRFJNX0VSUk9SKCJDb3VsZG4ndCBkaXNhYmxlIERQTEww XG4iKTsKPiA+ICsJfQo+ID4gIAo+ID4gIAlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJp diwgUE9XRVJfRE9NQUlOX1BMTFMpOyAgfQo+ID4gLS0KPiA+IDIuMC4yCj4gPiAKPiA+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1nZngg bWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBodHRw Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cj4gCj4g LS0KPiBEYW5pZWwgVmV0dGVyCj4gU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9u Cj4gaHR0cDovL2Jsb2cuZmZ3bGwuY2gKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==