From: Daniel Vetter <daniel@ffwll.ch>
To: Zhiyuan Lv <zhiyuan.lv@intel.com>
Cc: intel-gfx@lists.freedesktop.org, igvt-g@lists.01.org
Subject: Re: [PATCH v2 6/6] drm/i915: Allow Broadwell guest with Intel GVT-g
Date: Wed, 2 Sep 2015 11:47:30 +0200 [thread overview]
Message-ID: <20150902094730.GS1367@phenom.ffwll.local> (raw)
In-Reply-To: <1440747679-20716-7-git-send-email-zhiyuan.lv@intel.com>
On Fri, Aug 28, 2015 at 03:41:19PM +0800, Zhiyuan Lv wrote:
> I915 Broadwell guest driver is now supported to run inside a VM with
> Intel GVT-g
>
> v2:
> - Introduce HAS_VGPU macro (Zhenyu Wang)
>
> Signed-off-by: Zhiyuan Lv <zhiyuan.lv@intel.com>
> Signed-off-by: Zhi Wang <zhi.a.wang@intel.com>
> Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
I'll hold of on this one for the polished version of patch 2, but all
others are merged to dinq.
Thanks, Daniel
> ---
> drivers/gpu/drm/i915/i915_vgpu.c | 2 +-
> drivers/gpu/drm/i915/i915_vgpu.h | 2 ++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_vgpu.c b/drivers/gpu/drm/i915/i915_vgpu.c
> index 5eee75b..f98a979 100644
> --- a/drivers/gpu/drm/i915/i915_vgpu.c
> +++ b/drivers/gpu/drm/i915/i915_vgpu.c
> @@ -66,7 +66,7 @@ void i915_check_vgpu(struct drm_device *dev)
>
> BUILD_BUG_ON(sizeof(struct vgt_if) != VGT_PVINFO_SIZE);
>
> - if (!IS_HASWELL(dev))
> + if (!HAS_VGPU(dev))
> return;
>
> magic = readq(dev_priv->regs + vgtif_reg(magic));
> diff --git a/drivers/gpu/drm/i915/i915_vgpu.h b/drivers/gpu/drm/i915/i915_vgpu.h
> index 21c97f4..9a9eb57 100644
> --- a/drivers/gpu/drm/i915/i915_vgpu.h
> +++ b/drivers/gpu/drm/i915/i915_vgpu.h
> @@ -114,6 +114,8 @@ struct vgt_if {
> #define VGT_DRV_DISPLAY_NOT_READY 0
> #define VGT_DRV_DISPLAY_READY 1 /* ready for display switch */
>
> +#define HAS_VGPU(dev) (IS_HASWELL(dev) || IS_BROADWELL(dev))
> +
> extern void i915_check_vgpu(struct drm_device *dev);
> extern int intel_vgt_balloon(struct drm_device *dev);
> extern void intel_vgt_deballoon(void);
> --
> 1.9.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-02 9:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 7:41 [PATCH v2 0/6] drm/intel: guest i915 changes for Broadwell to run inside VM with Intel GVT-g Zhiyuan Lv
2015-08-28 7:41 ` [PATCH v2 1/6] drm/i915: preallocate pdps for 32 bit vgpu Zhiyuan Lv
2015-08-28 7:41 ` [PATCH v2 2/6] drm/i915: Enable full ppgtt for vgpu on Broadwell Zhiyuan Lv
2015-08-31 12:55 ` Joonas Lahtinen
2015-09-02 9:45 ` Daniel Vetter
2015-08-28 7:41 ` [PATCH v2 3/6] drm/i915: Always enable execlists on BDW for vgpu Zhiyuan Lv
2015-08-31 12:50 ` Joonas Lahtinen
2015-08-28 7:41 ` [PATCH v2 4/6] drm/i915: Update PV INFO page definition for Intel GVT-g Zhiyuan Lv
2015-08-28 7:41 ` [PATCH v2 5/6] drm/i915: guest i915 notification " Zhiyuan Lv
2015-08-31 12:46 ` Joonas Lahtinen
2015-08-28 7:41 ` [PATCH v2 6/6] drm/i915: Allow Broadwell guest with " Zhiyuan Lv
2015-09-02 9:47 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902094730.GS1367@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=igvt-g@lists.01.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox