From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 4/4] drm/i915: Avoid race of intel_crt_detect_hotplug() with HPD interrupt Date: Wed, 2 Sep 2015 14:06:12 +0200 Message-ID: <20150902120612.GD1367@phenom.ffwll.local> References: <1441138895-23732-1-git-send-email-eich@suse.de> <1441138895-23732-5-git-send-email-eich@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f180.google.com (mail-wi0-f180.google.com [209.85.212.180]) by gabe.freedesktop.org (Postfix) with ESMTPS id 961256E05A for ; Wed, 2 Sep 2015 05:06:16 -0700 (PDT) Received: by wiclp12 with SMTP id lp12so16692339wic.1 for ; Wed, 02 Sep 2015 05:06:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1441138895-23732-5-git-send-email-eich@suse.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Egbert Eich Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBTZXAgMDEsIDIwMTUgYXQgMTA6MjE6MzVQTSArMDIwMCwgRWdiZXJ0IEVpY2ggd3Jv dGU6Cj4gQSBIUEQgaW50ZXJydXB0IG1heSBmaXJlIGR1cmluZyBpbnRlbF9jcnRfZGV0ZWN0X2hv dHBsdWcoKSAtIGVzcGVjaWFsbHkKPiB3aGVuIEhQRCBpbnRlcnJ1cHQgc3Rvcm1zIG9jY3VyLgo+ IFNpbmNlIHRoZSBpbnRlcnJ1cHQgaGFuZGxlciBjaGFuZ2VzIHRoZSBlbmFibGVkIGludGVycnVw dCBsaW5lcyB3aGVuIGl0Cj4gZGV0ZWN0cyBhIHN0b3JtIHRoaXMgcmFjZXMgd2l0aCBpbnRlbF9j cnRfZGV0ZWN0X2hvdHBsdWcoKS4KPiBUbyBhdm9pZCB0aGlzLCBzaGlsZWQgdGhlIHJtdyBjeWNs ZXMgd2l0aCBJUlEgc2F2ZSBzcGlubG9ja3MuCj4gCj4gU2lnbmVkLW9mZi1ieTogRWdiZXJ0IEVp Y2ggPGVpY2hAc3VzZS5kZT4KCkkgdGhpbmsgdGhpcyBvbmx5IHJlZHVjZXMgb25lIHNvdXJjZSBv ZiBzdWNoIHJhY2VzLCBidXQgZnVuZGFtZW50YWxseSB3ZQpjYW4ndCBhdm9pZCB0aGVtLiBFLmcu IGlmIHlvdSdyZSBfdmVyeV8gdW5sdWNreSB5b3UgbWlnaHQgY2F1c2UgYSByZWFsIGhwZApyaWdo dCB3aGVuIHRoZSBzdHJvbSBjb2RlIGZyb2JzIGFyb3VuZC4gUGx1Z2dpbmcgdGhlIHJhY2Ugd2l0 aCB0aGlzIGtub3duCmludGVycnVwdCBzb3VyY2UgaGVyZSBkb2Vzbid0IGZpeCB0aGUgZnVuZGFt ZW50YWwgaXNzdWUuCgpBbHNvIEkgdGhpbmsgdGhlIGFjdHVhbCBpbnRlcnJ1cHQgZGVsaXZlciBp cyBmYWlybHkgYXN5bmNocm9ub3VzLCBib3RoIGluCnRoZSBoYXJkd2FyZSBhbmQgaW4gdGhlIHN3 IGhhbmRsaW5nLiBFLmcuIHNwaW5fbG9ja19pcnEgZG9lcyBub3QKc3luY2hyb25pemUgd2l0aCB0 aGUgaW50ZXJydXB0IGhhbmRsZXIgb24gU01QIHN5c3RlbXMsIGl0IG9ubHkgZ3VhcmFudGVlcwp0 aGF0IGl0J3Mgbm90IHJ1bm5pbmcgY29uY3VycmVudGx5IG9uIHRoZSBzYW1lIGNwdSAod2hpY2gg d291bGQgZGVhZGxvY2spLgoKSSB0aGluayBmdW5kYW1lbnRhbGx5IHRoaXMgcmFjZSBpcyB1bmZp eGFibGUuCi1EYW5pZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2NydC5j IHwgMTcgKysrKysrKysrKysrLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDEyIGluc2VydGlvbnMo KyksIDUgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2NydC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3J0LmMKPiBpbmRleCBh ZjVlNDNiLi42ODVmM2RlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2NydC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfY3J0LmMKPiBAQCAtMzc2 LDkgKzM3NiwxMCBAQCBzdGF0aWMgYm9vbCBpbnRlbF9jcnRfZGV0ZWN0X2hvdHBsdWcoc3RydWN0 IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiAgewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRl diA9IGNvbm5lY3Rvci0+ZGV2Owo+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2 ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAtCXUzMiBob3RwbHVnX2VuLCBvcmlnLCBzdGF0Owo+ICsJ dTMyIGhvdHBsdWdfZW4sIHN0YXQ7Cj4gIAlib29sIHJldCA9IGZhbHNlOwo+ICAJaW50IGksIHRy aWVzID0gMDsKPiArCXVuc2lnbmVkIGxvbmcgaXJxZmxhZ3M7Cj4gIAo+ICAJaWYgKEhBU19QQ0hf U1BMSVQoZGV2KSkKPiAgCQlyZXR1cm4gaW50ZWxfaXJvbmxha2VfY3J0X2RldGVjdF9ob3RwbHVn KGNvbm5lY3Rvcik7Cj4gQEAgLTM5NSwxMiArMzk2LDE0IEBAIHN0YXRpYyBib29sIGludGVsX2Ny dF9kZXRlY3RfaG90cGx1ZyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJCXRy aWVzID0gMjsKPiAgCWVsc2UKPiAgCQl0cmllcyA9IDE7Cj4gLQlob3RwbHVnX2VuID0gb3JpZyA9 IEk5MTVfUkVBRChQT1JUX0hPVFBMVUdfRU4pOwo+IC0JaG90cGx1Z19lbiB8PSBDUlRfSE9UUExV R19GT1JDRV9ERVRFQ1Q7Cj4gIAo+ICAJZm9yIChpID0gMDsgaSA8IHRyaWVzIDsgaSsrKSB7Cj4g IAkJLyogdHVybiBvbiB0aGUgRk9SQ0VfREVURUNUICovCj4gLQkJSTkxNV9XUklURShQT1JUX0hP VFBMVUdfRU4sIGhvdHBsdWdfZW4pOwo+ICsJCXNwaW5fbG9ja19pcnFzYXZlKCZkZXZfcHJpdi0+ aXJxX2xvY2ssIGlycWZsYWdzKTsKPiArCQlob3RwbHVnX2VuID0gSTkxNV9SRUFEKFBPUlRfSE9U UExVR19FTik7Cj4gKwkJSTkxNV9XUklURShQT1JUX0hPVFBMVUdfRU4sIGhvdHBsdWdfZW4gfAo+ ICsJCQkgICBDUlRfSE9UUExVR19GT1JDRV9ERVRFQ1QpOwo+ICsJCXNwaW5fdW5sb2NrX2lycXJl c3RvcmUoJmRldl9wcml2LT5pcnFfbG9jaywgaXJxZmxhZ3MpOwo+ICAJCS8qIHdhaXQgZm9yIEZP UkNFX0RFVEVDVCB0byBnbyBvZmYgKi8KPiAgCQlpZiAod2FpdF9mb3IoKEk5MTVfUkVBRChQT1JU X0hPVFBMVUdfRU4pICYKPiAgCQkJICAgICAgQ1JUX0hPVFBMVUdfRk9SQ0VfREVURUNUKSA9PSAw LAo+IEBAIC00MTYsNyArNDE5LDExIEBAIHN0YXRpYyBib29sIGludGVsX2NydF9kZXRlY3RfaG90 cGx1ZyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKQo+ICAJSTkxNV9XUklURShQT1JU X0hPVFBMVUdfU1RBVCwgQ1JUX0hPVFBMVUdfSU5UX1NUQVRVUyk7Cj4gIAo+ICAJLyogYW5kIHB1 dCB0aGUgYml0cyBiYWNrICovCj4gLQlJOTE1X1dSSVRFKFBPUlRfSE9UUExVR19FTiwgb3JpZyk7 Cj4gKwlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2X3ByaXYtPmlycV9sb2NrLCBpcnFmbGFncyk7Cj4g Kwlob3RwbHVnX2VuID0gSTkxNV9SRUFEKFBPUlRfSE9UUExVR19FTik7Cj4gKwlob3RwbHVnX2Vu ICY9IH5DUlRfSE9UUExVR19GT1JDRV9ERVRFQ1Q7Cj4gKwlJOTE1X1dSSVRFKFBPUlRfSE9UUExV R19FTiwgaG90cGx1Z19lbik7Cj4gKwlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXZfcHJpdi0+ aXJxX2xvY2ssIGlycWZsYWdzKTsKPiAgCj4gIAlyZXR1cm4gcmV0Owo+ICB9Cj4gLS0gCj4gMS44 LjQuNQo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBv cmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz dGluZm8vaW50ZWwtZ2Z4Cg==