From: Daniel Vetter <daniel@ffwll.ch>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: daniel.vetter@intel.com, Artem Savkov <asavkov@redhat.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] uapi/drm/i915_drm.h: fix userspace compilation.
Date: Wed, 2 Sep 2015 14:20:26 +0200 [thread overview]
Message-ID: <20150902122026.GG1367@phenom.ffwll.local> (raw)
In-Reply-To: <20150902115219.GO29811@intel.com>
On Wed, Sep 02, 2015 at 02:52:19PM +0300, Ville Syrjälä wrote:
> On Wed, Sep 02, 2015 at 01:41:18PM +0200, Artem Savkov wrote:
> > Patch "drm/i915: Use expcitly fixed type in compat32 structs" changed the type
> > of param field in drm_i915_getparam from int to s32. This header is exported to
> > userspace and needs to use userspace type __s32 instead.
> >
> > This fixes userspace compilation errors like the following:
> > include/drm/i915_drm.h:361:2: error: unknown type name 's32'
> > s32 param;
> >
> > Signed-off-by: Artem Savkov <asavkov@redhat.com>
> > ---
> > include/uapi/drm/i915_drm.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
> > index dbd16a2..fd5aa47 100644
> > --- a/include/uapi/drm/i915_drm.h
> > +++ b/include/uapi/drm/i915_drm.h
> > @@ -358,7 +358,7 @@ typedef struct drm_i915_irq_wait {
> > #define I915_PARAM_HAS_RESOURCE_STREAMER 36
> >
> > typedef struct drm_i915_getparam {
> > - s32 param;
> > + __s32 param;
>
> Hmm. I don't understand why this one in particular got changed to s32
> when there are other ioctl structs still using int.
Mostly me being incompetent.
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch> on this one, not that
it seems to be worth much ...
-Daniel
>
> > /*
> > * WARNING: Using pointers instead of fixed-size u64 means we need to write
> > * compat32 code. Don't repeat this mistake.
> > --
> > 2.1.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel OTC
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-02 12:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-02 11:41 [PATCH] uapi/drm/i915_drm.h: fix userspace compilation Artem Savkov
2015-09-02 11:52 ` Ville Syrjälä
2015-09-02 12:20 ` Daniel Vetter [this message]
2015-09-02 13:30 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150902122026.GG1367@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=asavkov@redhat.com \
--cc=daniel.vetter@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox