intel-gfx.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Vetter <daniel@ffwll.ch>
To: "Konduru, Chandra" <chandra.konduru@intel.com>
Cc: "Vetter, Daniel" <daniel.vetter@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"Syrjala, Ville" <ville.syrjala@intel.com>
Subject: Re: [PATCH 14/15] drm/i915: skl nv12 workarounds
Date: Fri, 4 Sep 2015 09:40:46 +0200	[thread overview]
Message-ID: <20150904074046.GD22430@phenom.ffwll.local> (raw)
In-Reply-To: <76A9B330A4D78C4D99CB292C4CC06C0E370CDAF3@fmsmsx101.amr.corp.intel.com>

On Thu, Sep 03, 2015 at 06:33:25PM +0000, Konduru, Chandra wrote:
> 
> > -----Original Message-----
> > From: Daniel Vetter [mailto:daniel.vetter@ffwll.ch] On Behalf Of Daniel Vetter
> > Sent: Wednesday, September 02, 2015 1:02 AM
> > To: Konduru, Chandra
> > Cc: Daniel Vetter; intel-gfx@lists.freedesktop.org; Vetter, Daniel; Syrjala, Ville
> > Subject: Re: [Intel-gfx] [PATCH 14/15] drm/i915: skl nv12 workarounds
> > 
> > On Thu, Aug 27, 2015 at 01:44:06AM +0000, Konduru, Chandra wrote:
> > > > > -static char intel_get_stepping(struct drm_device *dev)
> > > > > +char intel_get_stepping(struct drm_device *dev)
> > > >
> > > > I guess we should have a new home for this now that it's used outside of
> > > > intel_csr.c Plus kerneldoc, as usual.
> > >
> > > Will add kerneldoc header and respun, but where do you want to move to?
> > 
> > If you want my dice-roll, I'd shovel it into intel_uncore.c for lack of
> > better home.
> > -Daniel
> I sent updated patch series couple days ago moving to intel_display.c.
> I hope that is fine. 

Imo intel_display.c is the wrong place since this isn't display-specific
really - stepping is for the entire device. intel_uncore.c, i915_drv.c or
i915_dma.c would all be suitable places.

> By the way, can you start giving RB tags for the patches you reviewed?

This isn't a full review, just a small thing I spotted while reading
patches.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-09-04  7:38 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20  1:02 [PATCH 00/15] drm/i915: Adding NV12 for skylake display Chandra Konduru
2015-08-20  1:02 ` [PATCH 01/15] drm/i915: Allocate min dbuf blocks per bspec Chandra Konduru
2015-09-04  8:17   ` Ville Syrjälä
2015-08-20  1:02 ` [PATCH 02/15] drm/i915: In DBUF/WM calcs for 90/270, swap w & h Chandra Konduru
2015-09-04  8:31   ` Ville Syrjälä
2015-08-20  1:02 ` [PATCH 03/15] drm/i915: Add register definitions for NV12 support Chandra Konduru
2015-09-04  8:40   ` Ville Syrjälä
2015-08-20  1:02 ` [PATCH 04/15] drm/i915: Set scaler mode for NV12 Chandra Konduru
2015-09-04  8:53   ` Ville Syrjälä
2015-09-04 15:03     ` Daniel Vetter
2015-08-20  1:02 ` [PATCH 05/15] drm/i915: Stage scaler request for NV12 as src format Chandra Konduru
2015-09-04 10:17   ` Ville Syrjälä
2015-08-20  1:02 ` [PATCH 06/15] drm/i915: Update format_is_yuv() to include NV12 Chandra Konduru
2015-09-04 10:17   ` Ville Syrjälä
2015-08-20  1:02 ` [PATCH 07/15] drm/i915: Upscale scaler max scale for NV12 Chandra Konduru
2015-09-04 10:22   ` Ville Syrjälä
2015-08-20  1:02 ` [PATCH 08/15] drm/i915: Add NV12 as supported format for primary plane Chandra Konduru
2015-08-26  8:40   ` Daniel Vetter
2015-08-27  1:40     ` Konduru, Chandra
2015-08-20  1:02 ` [PATCH 09/15] drm/i915: Add NV12 as supported format for sprite plane Chandra Konduru
2015-09-04 10:28   ` Ville Syrjälä
2015-08-20  1:02 ` [PATCH 10/15] drm/i915: Add NV12 support to intel_framebuffer_init Chandra Konduru
2015-09-04 10:40   ` Ville Syrjälä
2015-08-20  1:02 ` [PATCH 11/15] drm/i915: Add NV12 to primary plane programming Chandra Konduru
2015-09-04 11:09   ` Ville Syrjälä
2015-09-04 15:06     ` Daniel Vetter
2015-09-05  1:10     ` Konduru, Chandra
2015-09-05 14:59       ` Ville Syrjälä
2015-09-08 23:30         ` Konduru, Chandra
2015-09-09 11:41           ` Ville Syrjälä
2015-09-09 17:12             ` Konduru, Chandra
2015-09-09 18:05               ` Ville Syrjälä
2015-09-09 20:10                 ` Konduru, Chandra
2015-09-09 20:40                   ` Ville Syrjälä
2015-09-09 21:09                     ` Konduru, Chandra
2015-09-09 22:27                       ` Ville Syrjälä
2015-09-09 23:31                         ` Konduru, Chandra
2015-08-20  1:02 ` [PATCH 12/15] drm/i915: Add NV12 to sprite " Chandra Konduru
2015-08-20  1:02 ` [PATCH 13/15] drm/i915: Set initial phase & trip for NV12 scaler Chandra Konduru
2015-09-04 11:15   ` Ville Syrjälä
2015-08-20  1:02 ` [PATCH 14/15] drm/i915: skl nv12 workarounds Chandra Konduru
2015-08-26  8:42   ` Daniel Vetter
2015-08-27  1:44     ` Konduru, Chandra
2015-09-02  8:02       ` Daniel Vetter
2015-09-03 18:33         ` Konduru, Chandra
2015-09-04  7:40           ` Daniel Vetter [this message]
2015-09-05  2:09             ` Konduru, Chandra
2015-09-04 11:26   ` Ville Syrjälä
2015-09-05  1:28     ` Konduru, Chandra
2015-09-05 14:52       ` Ville Syrjälä
2015-09-08 23:51         ` Konduru, Chandra
2015-09-09 11:46           ` Ville Syrjälä
2015-09-09 17:20             ` Konduru, Chandra
2015-08-20  1:02 ` [PATCH 15/15] drm/i915: Add 90/270 rotation for NV12 format Chandra Konduru
2015-09-04 11:30   ` Ville Syrjälä
2015-09-05  1:38     ` Konduru, Chandra
2015-09-05 14:48       ` Ville Syrjälä

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150904074046.GD22430@phenom.ffwll.local \
    --to=daniel@ffwll.ch \
    --cc=chandra.konduru@intel.com \
    --cc=daniel.vetter@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=ville.syrjala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).