Re: [PATCH 01/10] drm/i915: Use atomic plane state in the primary plane update.

Maarten Lankhorst
2015-09-14T13:40:49Z

Op 14-09-15 om 15:27 schreef Ville Syrjälä:
> On Thu, Sep 10, 2015 at 04:07:56PM +0200, Maarten Lankhorst wrote:
>> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_display.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
>> index 80a98bffd5ba..33200403a5db 100644
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -13448,7 +13448,9 @@ intel_commit_primary_plane(struct drm_plane *plane,
>> if (!crtc->state->active)
>> return;
>>
>> - dev_priv->display.update_primary_plane(crtc, fb, crtc->x, crtc->y);
>> + dev_priv->display.update_primary_plane(crtc, fb,
>> + state->src.x1 >> 16,
>> + state->src.y1 >> 16);
>> }
> You know I posted a pile of patches last spring to start cleaning up
> this mess. Maybe someone wants to rescue the patches and avoid some
> duplicate work?
>
> http://lists.freedesktop.org/archives/intel-gfx/2015-March/061715.html
>
Yeah I've seen it, watermarks will have to be solved another way.
I've been considering passing to the primary plane state instead. :-)