Re: [PATCH 2/2] drm/i915: add more debug info for when atomic updates fail

Daniel Vetter
2015-09-14T09:02:10Z

On Thu, Sep 10, 2015 at 01:23:53PM -0700, Jesse Barnes wrote:
> On 09/10/2015 09:05 AM, Ville Syrjälä wrote:
> > On Thu, Sep 10, 2015 at 08:34:23AM -0700, Jesse Barnes wrote:
> >> I used these additional fields to track down the issue I saw on HSW.
> >
> > We already have the tracepoints with the scanline information. Not sure
> > what extra this would give.
>
> Also when this hits users or test runners, the needed info will be
> immediately available, rather than having to enable trace points and
> re-run. I think that's important for error cases like this, as opposed
> to runtime debugging where tracepoints are fine.

I agree with Jesse here, if things go south we should be able to print
useful debug info. And we do have a bunch of rather mysterious pipe update
failure backtraces all over already.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation