From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2 4/5] drm/i915: Make updating pipe without modeset atomic.
Date: Mon, 14 Sep 2015 10:05:16 +0200 [thread overview]
Message-ID: <20150914080516.GF3383@phenom.ffwll.local> (raw)
In-Reply-To: <55F1DA77.2070606@virtuousgeek.org>
On Thu, Sep 10, 2015 at 12:31:03PM -0700, Jesse Barnes wrote:
> On 08/27/2015 06:44 AM, Maarten Lankhorst wrote:
> > + /* on skylake this is done by detaching scalers */
> > + if (INTEL_INFO(dev)->gen == 9) {
> > + skl_detach_scalers(crtc);
> > +
> > + if (pipe_config->pch_pfit.enabled)
> > + skylake_pfit_enable(crtc);
> > + }
> > + else if (INTEL_INFO(dev)->gen < 9 &&
> > + HAS_PCH_SPLIT(dev)) {
> > + if (pipe_config->pch_pfit.enabled)
> > + ironlake_pfit_enable(crtc);
> > + else if (old_crtc_state->pch_pfit.enabled)
> > + ironlake_pfit_disable(crtc, true);
> > }
>
> Funky coding style, but otherwise looks ok...
Yeah I simplified this and future-proved it to make the skl_* be called
for gen9+.
But I did spot that the check for scaler_id in the pipe config compare
function is not in the !adjust block ... does fastboot on skl actually
work?
Thanks, Daniel
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-14 8:02 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 13:44 [PATCH v2 0/5] Faster modeset support Maarten Lankhorst
2015-08-27 13:44 ` [PATCH v2 1/5] drm/i915: Set csc coefficients in update_pipe_size Maarten Lankhorst
2015-09-10 19:25 ` Jesse Barnes
2015-09-10 19:27 ` Jesse Barnes
2015-08-27 13:44 ` [PATCH v2 2/5] drm/i915: Remove references to crtc->active from intel_fbdev.c Maarten Lankhorst
2015-09-10 19:26 ` Jesse Barnes
2015-08-27 13:44 ` [PATCH v2 3/5] drm/i915: Always try to inherit the initial fb Maarten Lankhorst
2015-09-10 19:26 ` Jesse Barnes
2015-08-27 13:44 ` [PATCH v2 4/5] drm/i915: Make updating pipe without modeset atomic Maarten Lankhorst
2015-08-27 13:58 ` Ville Syrjälä
2015-08-27 14:06 ` Maarten Lankhorst
2015-08-27 14:33 ` Ville Syrjälä
2015-09-10 19:31 ` Jesse Barnes
2015-09-14 8:05 ` Daniel Vetter [this message]
2015-08-27 13:44 ` [PATCH v2 5/5] drm/i915: skip modeset if compatible for everyone Maarten Lankhorst
2015-08-29 23:57 ` shuang.he
2015-09-10 19:31 ` Jesse Barnes
2015-09-14 8:08 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914080516.GF3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox