From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: add more debug info for when atomic updates fail
Date: Mon, 14 Sep 2015 11:04:53 +0200 [thread overview]
Message-ID: <20150914090453.GQ3383@phenom.ffwll.local> (raw)
In-Reply-To: <55F1E6D9.3090404@virtuousgeek.org>
On Thu, Sep 10, 2015 at 01:23:53PM -0700, Jesse Barnes wrote:
> On 09/10/2015 09:05 AM, Ville Syrjälä wrote:
> > On Thu, Sep 10, 2015 at 08:34:23AM -0700, Jesse Barnes wrote:
> >> I used these additional fields to track down the issue I saw on HSW.
> >
> > We already have the tracepoints with the scanline information. Not sure
> > what extra this would give.
>
> Also when this hits users or test runners, the needed info will be
> immediately available, rather than having to enable trace points and
> re-run. I think that's important for error cases like this, as opposed
> to runtime debugging where tracepoints are fine.
I agree with Jesse here, if things go south we should be able to print
useful debug info. And we do have a bunch of rather mysterious pipe update
failure backtraces all over already.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-14 9:02 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 15:34 [PATCH 1/2] drm/i915: workaround bad DSL readout in start of pipe update Jesse Barnes
2015-09-10 15:34 ` [PATCH 2/2] drm/i915: add more debug info for when atomic updates fail Jesse Barnes
2015-09-10 16:05 ` Ville Syrjälä
2015-09-10 16:14 ` Jesse Barnes
2015-09-10 20:23 ` Jesse Barnes
2015-09-14 9:04 ` Daniel Vetter [this message]
2015-09-15 17:03 ` [PATCH] drm/i915: add more debug info for when atomic updates fail v2 Jesse Barnes
2015-09-15 17:47 ` Ville Syrjälä
2015-09-10 16:11 ` [PATCH 1/2] drm/i915: workaround bad DSL readout in start of pipe update Ville Syrjälä
2015-09-10 16:17 ` Jesse Barnes
2015-09-10 16:27 ` Ville Syrjälä
2015-09-10 21:38 ` [PATCH] drm/i915: workaround bad DSL readout v2 Jesse Barnes
2015-09-10 21:53 ` Ville Syrjälä
2015-09-10 21:57 ` Jesse Barnes
2015-09-10 22:33 ` Ville Syrjälä
2015-09-14 9:10 ` Daniel Vetter
2015-09-14 13:02 ` Ville Syrjälä
2015-09-14 14:29 ` Daniel Vetter
2015-09-15 21:00 ` Jesse Barnes
2015-09-14 18:47 ` Ville Syrjälä
2015-09-22 16:41 ` Ville Syrjälä
2015-09-22 19:15 ` [PATCH] drm/i915: workaround bad DSL readout v3 Jesse Barnes
2015-09-23 7:48 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150914090453.GQ3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox