Re: [PATCH] drm/i915/skl: Don't clear all watermarks when updating. (v2)

[Daniel Vetter <daniel@ffwll.ch>]

On Mon, Sep 21, 2015 at 02:48:56PM +0100, Damien Lespiau wrote:
> On Tue, Jul 21, 2015 at 10:42:53AM -0700, Bob Paauwe wrote:
> > Clearing the watermarks for all pipes/planes when updating the
> > watermarks for a single CRTC change seems like the wrong thing to
> > do here. As is, this code will ony update any pipe/plane watermarks
> > that need updating and leave the remaining set to zero.  Later, the
> > watermark checks in check_wm_state() will flag these zero'd out pipe/plane
> > watermarks and throw errors.
> > 
> > By clearing only the watermark values associated with the specific crtc
> > the other watermark values may remain unchanged.
> > 
> > v2: Make sure all the dirty flags are cleared. Damien
> >     Clear all values assoicated with crtc/pipe being updated.  Damien
> > 
> > Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
> 
> Reviewed-by: Damien Lespiau <damien.lespiau@intel.com>
> 
> - Moving to a "array of structs" from a "struct of arrays" organization
>   as suggested by Ville would make that much better
> - I'd move clearing the dirty flag right after writing the registers

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx