From: Daniel Vetter <daniel@ffwll.ch>
To: Yu Dai <yu.dai@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/5] drm/i915: Increase maximum polling time to 50ms for forcewake request/clear ack
Date: Wed, 23 Sep 2015 10:04:39 +0200 [thread overview]
Message-ID: <20150923080439.GH3383@phenom.ffwll.local> (raw)
In-Reply-To: <5600339A.7030500@intel.com>
On Mon, Sep 21, 2015 at 09:43:06AM -0700, Yu Dai wrote:
> Looks fine to me.
> Reviewed by: Alex Dai <yu.dai@intel.com>.
>
> On 08/23/2015 05:22 AM, Sagar Arun Kamble wrote:
> >On BXT, We Observe timeout for forcewake request completion with 2ms polling period as given here:
> >[drm:fw_domains_get] ERROR render: timed out waiting for forcewake ack request.
> >Polling for 50ms is recommended to avoid these timeouts.
> >
> >Change-Id: Ie715b0069a3049606e9602bc5e97a6511890864d
> >Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> >---
> > drivers/gpu/drm/i915/intel_uncore.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c
> >index 9d3c2e4..2df03b1 100644
> >--- a/drivers/gpu/drm/i915/intel_uncore.c
> >+++ b/drivers/gpu/drm/i915/intel_uncore.c
> >@@ -27,7 +27,7 @@
> > #include <linux/pm_runtime.h>
> >-#define FORCEWAKE_ACK_TIMEOUT_MS 2
> >+#define FORCEWAKE_ACK_TIMEOUT_MS 50
> > #define __raw_i915_read8(dev_priv__, reg__) readb((dev_priv__)->regs + (reg__))
> > #define __raw_i915_write8(dev_priv__, reg__, val__) writeb(val__, (dev_priv__)->regs + (reg__))
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-09-23 8:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-23 12:22 [PATCH 0/5] RC6/Forcewake/Turbo related changes for Gen9 Sagar Arun Kamble
2015-08-23 12:22 ` [PATCH 1/5] drm/i915: Increase maximum polling time to 50ms for forcewake request/clear ack Sagar Arun Kamble
2015-08-26 9:26 ` Daniel Vetter
2015-09-22 9:06 ` Tvrtko Ursulin
2015-09-22 9:15 ` Chris Wilson
2015-09-22 9:48 ` Tvrtko Ursulin
2015-09-21 16:43 ` Yu Dai
2015-09-23 8:04 ` Daniel Vetter [this message]
2015-08-23 12:22 ` [PATCH 2/5] drm/i915/bxt: WaGsvDisableTurbo Sagar Arun Kamble
2015-09-11 6:23 ` Kamble, Sagar A
2015-09-11 12:24 ` Kamble, Sagar A
2015-09-21 16:43 ` Yu Dai
2015-09-23 7:46 ` Daniel Vetter
2015-08-23 12:22 ` [PATCH 3/5] drm/i915: WaRsDisableCoarsePowerGating Sagar Arun Kamble
2015-09-11 6:22 ` Kamble, Sagar A
2015-09-11 9:11 ` [PATCH 1/2] drm/i915: Add IS_SKL_GT3 and IS_SKL_GT4 macro Sagar Arun Kamble
2015-09-11 9:11 ` [PATCH 2/2] drm/i915: WaRsDisableCoarsePowerGating Sagar Arun Kamble
2015-09-11 11:46 ` [PATCH v2 1/1] " Sagar Arun Kamble
2015-09-21 16:43 ` [PATCH 3/5] " Yu Dai
2015-09-23 7:47 ` Daniel Vetter
2015-08-23 12:22 ` [PATCH 4/5] drm/i915: Use only blitter forcewake Sagar Arun Kamble
2015-08-23 12:30 ` Chris Wilson
2015-09-11 13:23 ` Kamble, Sagar A
2015-09-11 13:37 ` Ville Syrjälä
2015-09-11 13:54 ` Kamble, Sagar A
2015-09-11 14:02 ` Ville Syrjälä
2015-09-12 18:15 ` Kamble, Sagar A
2015-08-23 12:22 ` [PATCH 5/5] drm/i915: Notify Coarse Power Gating changes to GuC Sagar Arun Kamble
2015-08-27 19:55 ` O'Rourke, Tom
2015-09-11 6:16 ` Kamble, Sagar A
2015-09-11 17:17 ` Yu Dai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923080439.GH3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=yu.dai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox