From: Daniel Vetter <daniel@ffwll.ch>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/i915: Fix fastboot scalers for skylake.
Date: Wed, 23 Sep 2015 10:55:07 +0200 [thread overview]
Message-ID: <20150923085507.GY3383@phenom.ffwll.local> (raw)
In-Reply-To: <55F9B8C2.1040302@virtuousgeek.org>
On Wed, Sep 16, 2015 at 11:45:22AM -0700, Jesse Barnes wrote:
> On 09/14/2015 02:30 AM, Maarten Lankhorst wrote:
> > The scaler_id in intel_pipe_config_compare should not be checked
> > when adjusting in intel_pipe_config_compare. The hw scaler id may
> > be changed in intel_update_pipe_config.
> >
> > Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_display.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> > index 452e8f77151d..deb76c84a307 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -12467,9 +12467,9 @@ intel_pipe_config_compare(struct drm_device *dev,
> > PIPE_CONF_CHECK_X(pch_pfit.pos);
> > PIPE_CONF_CHECK_X(pch_pfit.size);
> > }
> > - }
> >
> > - PIPE_CONF_CHECK_I(scaler_state.scaler_id);
> > + PIPE_CONF_CHECK_I(scaler_state.scaler_id);
> > + }
> >
> > /* BDW+ don't expose a synchronous way to read the state */
> > if (IS_HASWELL(dev))
> >
>
> Reviewed-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Queued for -next, thanks for the patch. Still looking for that
kms_fastmodeset igt ...
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-09-23 8:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 9:30 [PATCH 1/2] drm/i915: Fix fastboot scalers for skylake Maarten Lankhorst
2015-09-14 9:30 ` [PATCH 2/2] drm/i915: Only check pipe state for fast modeset when it's possible Maarten Lankhorst
2015-09-14 13:55 ` Daniel Vetter
2015-09-14 17:10 ` Daniel Stone
2015-09-23 13:35 ` Maarten Lankhorst
2015-09-16 18:48 ` Jesse Barnes
2015-09-23 11:38 ` Maarten Lankhorst
2015-09-16 18:45 ` [PATCH 1/2] drm/i915: Fix fastboot scalers for skylake Jesse Barnes
2015-09-23 8:55 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150923085507.GY3383@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jbarnes@virtuousgeek.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox