Re: [PATCH 2/2] drm/i915: Only check pipe state for fast modeset when it's possible.

Maarten Lankhorst
2015-09-23T11:38:40Z

Op 16-09-15 om 20:48 schreef Jesse Barnes:
> On 09/14/2015 02:30 AM, Maarten Lankhorst wrote:
>> + if (!crtc_state->connectors_changed &&
>> + !crtc_state->active_changed &&
>> + crtc_state->active &&
>> + intel_pipe_config_compare(state->dev,
>> + to_intel_crtc_state(crtc->state),
>> + pipe_config, true)) {
>> crtc_state->mode_changed = false;
>> - to_intel_crtc_state(crtc_state)->update_pipe = true;
>> - }
> Doesn't needs_modeset() cover the connectors and active changed cases? Could we just hoist that up earlier in this function instead?
>
Not sure what you're saying, since needs_modeset is always true here.

~Maarten